Qual: Fix notices for htdocs/admin/* (#30982)

* Fix (Possibly)UndeclaredGlobalVariable

* Update phan baseline

* Fix (Possibly)UndeclaredGlobalVariable (2)

* Qual: Fix notices for htdocs/admin/*

# Qual: Fix notices for htdocs/admin/*

Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
This commit is contained in:
MDW
2024-09-18 03:27:25 +02:00
committed by GitHub
parent 9552b344cc
commit 099dbd9c1e
111 changed files with 873 additions and 501 deletions

View File

@@ -104,6 +104,7 @@ if ($action == 'add' || GETPOST("modify")) {
}
$result1 = dolibarr_set_const($db, "EXTERNAL_RSS_TITLE_".GETPOSTINT("norss"), GETPOST($external_rss_title), 'chaine', 0, '', $conf->entity);
$result2 = 0;
if ($result1) {
$consttosave = "EXTERNAL_RSS_URLRSS_".GETPOSTINT("norss");
$urltosave = GETPOST($external_rss_urlrss, 'alpha');
@@ -164,6 +165,7 @@ if (GETPOST("delete")) {
$result1 = dolibarr_del_const($db, "EXTERNAL_RSS_TITLE_".GETPOSTINT("norss"), $conf->entity);
$result2 = 0;
if ($result1) {
$result2 = dolibarr_del_const($db, "EXTERNAL_RSS_URLRSS_".GETPOSTINT("norss"), $conf->entity);
}
@@ -212,7 +214,7 @@ print '</tr>';
print '<tr class="oddeven">';
print '<td>'.$langs->trans('RSSUrl').'</td>';
print '<td><input type="text" class="flat minwidth300" name="external_rss_urlrss_'.($lastexternalrss + 1).'" value=""></td>';
print '<td>http://news.google.com/news?ned=us&topic=h&output=rss<br>http://www.dolibarr.org/rss</td>';
print '<td>https://news.google.com/news?ned=us&topic=h&output=rss<br>https://www.dolibarr.org/rss</td>';
print '</tr>';
print '</table>';
@@ -298,7 +300,7 @@ if ($resql) {
print '</tr>'."\n";
// Logo
if ($result > 0 && empty($rss->error)) {
if ($result > 0 && empty($rssparser->error)) {
print '<tr class="oddeven">';
print "<td>".$langs->trans("Logo")."</td>";
print '<td>';
@@ -348,9 +350,9 @@ $db->close();
/**
* Check if the given RSS feed if inside the list of boxes/widgets
*
* @param int $idrss The id of the RSS feed
* @param array $boxlist A list with boxes/widgets
* @return bool true if the rss feed is inside the box/widget list, otherwise false
* @param int $idrss The id of the RSS feed
* @param ModeleBoxes[] $boxlist A list with boxes/widgets
* @return bool true if the rss feed is inside the box/widget list, otherwise false
*/
function _isInBoxList($idrss, array $boxlist)
{