diff --git a/htdocs/admin/dict.php b/htdocs/admin/dict.php
index 6fc03a62189..2e4b88c2287 100644
--- a/htdocs/admin/dict.php
+++ b/htdocs/admin/dict.php
@@ -713,12 +713,12 @@ if (GETPOST('actionadd') || GETPOST('actionmodify')) {
continue; // For a column name 'sortorder', we use the field name 'position'
}
if ((!GETPOSTISSET($value) || GETPOST($value) == '')
- && (!in_array($listfield[$f], array('decalage', 'module', 'accountancy_code', 'accountancy_code_sell', 'accountancy_code_buy', 'tracking', 'picto')) // Fields that are not mandatory
- && ($id != 10 || ($listfield[$f] != 'code' && $listfield[$f] != 'note')) // Field code and note is not mandatory for dictionary table 10
+ && (!in_array($value, array('decalage', 'module', 'accountancy_code', 'accountancy_code_sell', 'accountancy_code_buy', 'tracking', 'picto')) // Fields that are not mandatory
+ && ($id != 10 || ($value != 'code' && $value != 'note')) // Field code and note is not mandatory for dictionary table 10
)
) {
$ok = 0;
- $fieldnamekey = $listfield[$f];
+ $fieldnamekey = $value;
// We take translate key of field
if ($fieldnamekey == 'libelle' || ($fieldnamekey == 'label')) {
$fieldnamekey = 'Label';
@@ -1211,26 +1211,26 @@ if ($id) {
// Line for title
$tdsoffields = '
';
foreach ($fieldlist as $field => $value) {
- if ($fieldlist[$field] == 'entity') {
+ if ($value == 'entity') {
$withentity = getEntity($tabname[$id]);
continue;
}
// Define field friendly name from its technical name
- $valuetoshow = ucfirst($fieldlist[$field]); // Par defaut
+ $valuetoshow = ucfirst($value); // Par defaut
$valuetoshow = $langs->trans($valuetoshow); // try to translate
$class = '';
- if ($fieldlist[$field] == 'pos') {
+ if ($value == 'pos') {
$valuetoshow = $langs->trans("Position"); $class = 'maxwidth100';
}
- if ($fieldlist[$field] == 'source') {
+ if ($value == 'source') {
$valuetoshow = $langs->trans("Contact");
}
- if ($fieldlist[$field] == 'price') {
+ if ($value == 'price') {
$valuetoshow = $langs->trans("PriceUHT");
}
- if ($fieldlist[$field] == 'taux') {
+ if ($value == 'taux') {
if ($tabname[$id] != MAIN_DB_PREFIX."c_revenuestamp") {
$valuetoshow = $langs->trans("Rate");
} else {
@@ -1238,175 +1238,175 @@ if ($id) {
}
$class = 'center';
}
- if ($fieldlist[$field] == 'localtax1_type') {
+ if ($value == 'localtax1_type') {
$valuetoshow = $langs->trans("UseLocalTax")." 2"; $class = "center"; $sortable = 0;
}
- if ($fieldlist[$field] == 'localtax1') {
+ if ($value == 'localtax1') {
$valuetoshow = $langs->trans("Rate")." 2"; $class = "center";
}
- if ($fieldlist[$field] == 'localtax2_type') {
+ if ($value == 'localtax2_type') {
$valuetoshow = $langs->trans("UseLocalTax")." 3"; $class = "center"; $sortable = 0;
}
- if ($fieldlist[$field] == 'localtax2') {
+ if ($value == 'localtax2') {
$valuetoshow = $langs->trans("Rate")." 3"; $class = "center";
}
- if ($fieldlist[$field] == 'organization') {
+ if ($value == 'organization') {
$valuetoshow = $langs->trans("Organization");
}
- if ($fieldlist[$field] == 'lang') {
+ if ($value == 'lang') {
$valuetoshow = $langs->trans("Language");
}
- if ($fieldlist[$field] == 'type') {
+ if ($value == 'type') {
if ($tabname[$id] == MAIN_DB_PREFIX."c_paiement") {
$valuetoshow = $form->textwithtooltip($langs->trans("Type"), $langs->trans("TypePaymentDesc"), 2, 1, img_help(1, ''));
} else {
$valuetoshow = $langs->trans("Type");
}
}
- if ($fieldlist[$field] == 'code') {
+ if ($value == 'code') {
$valuetoshow = $langs->trans("Code"); $class = 'maxwidth100';
}
- if ($fieldlist[$field] == 'libelle' || $fieldlist[$field] == 'label') {
+ if ($value == 'libelle' || $value == 'label') {
$valuetoshow = $form->textwithtooltip($langs->trans("Label"), $langs->trans("LabelUsedByDefault"), 2, 1, img_help(1, ''));
}
- if ($fieldlist[$field] == 'libelle_facture') {
+ if ($value == 'libelle_facture') {
$valuetoshow = $form->textwithtooltip($langs->trans("LabelOnDocuments"), $langs->trans("LabelUsedByDefault"), 2, 1, img_help(1, ''));
}
- if ($fieldlist[$field] == 'country') {
+ if ($value == 'country') {
if (in_array('region_id', $fieldlist)) {
print '
'; continue;
} // For region page, we do not show the country input
$valuetoshow = $langs->trans("Country");
}
- if ($fieldlist[$field] == 'recuperableonly') {
+ if ($value == 'recuperableonly') {
$valuetoshow = $langs->trans("NPR"); $class = "center";
}
- if ($fieldlist[$field] == 'nbjour') {
+ if ($value == 'nbjour') {
$valuetoshow = $langs->trans("NbOfDays");
}
- if ($fieldlist[$field] == 'type_cdr') {
+ if ($value == 'type_cdr') {
$valuetoshow = $langs->trans("AtEndOfMonth"); $class = "center";
}
- if ($fieldlist[$field] == 'decalage') {
+ if ($value == 'decalage') {
$valuetoshow = $langs->trans("Offset");
}
- if ($fieldlist[$field] == 'width' || $fieldlist[$field] == 'nx') {
+ if ($value == 'width' || $value == 'nx') {
$valuetoshow = $langs->trans("Width");
}
- if ($fieldlist[$field] == 'height' || $fieldlist[$field] == 'ny') {
+ if ($value == 'height' || $value == 'ny') {
$valuetoshow = $langs->trans("Height");
}
- if ($fieldlist[$field] == 'unit' || $fieldlist[$field] == 'metric') {
+ if ($value == 'unit' || $value == 'metric') {
$valuetoshow = $langs->trans("MeasuringUnit");
}
- if ($fieldlist[$field] == 'region_id' || $fieldlist[$field] == 'country_id') {
+ if ($value == 'region_id' || $value == 'country_id') {
$valuetoshow = '';
}
- if ($fieldlist[$field] == 'accountancy_code') {
+ if ($value == 'accountancy_code') {
$valuetoshow = $langs->trans("AccountancyCode");
}
- if ($fieldlist[$field] == 'accountancy_code_sell') {
+ if ($value == 'accountancy_code_sell') {
$valuetoshow = $langs->trans("AccountancyCodeSell");
}
- if ($fieldlist[$field] == 'accountancy_code_buy') {
+ if ($value == 'accountancy_code_buy') {
$valuetoshow = $langs->trans("AccountancyCodeBuy");
}
- if ($fieldlist[$field] == 'pcg_version' || $fieldlist[$field] == 'fk_pcg_version') {
+ if ($value == 'pcg_version' || $value == 'fk_pcg_version') {
$valuetoshow = $langs->trans("Pcg_version");
}
- if ($fieldlist[$field] == 'account_parent') {
+ if ($value == 'account_parent') {
$valuetoshow = $langs->trans("Accountparent");
}
- if ($fieldlist[$field] == 'pcg_type') {
+ if ($value == 'pcg_type') {
$valuetoshow = $langs->trans("Pcg_type");
}
- if ($fieldlist[$field] == 'pcg_subtype') {
+ if ($value == 'pcg_subtype') {
$valuetoshow = $langs->trans("Pcg_subtype");
}
- if ($fieldlist[$field] == 'sortorder') {
+ if ($value == 'sortorder') {
$valuetoshow = $langs->trans("SortOrder");
}
- if ($fieldlist[$field] == 'short_label') {
+ if ($value == 'short_label') {
$valuetoshow = $langs->trans("ShortLabel");
}
- if ($fieldlist[$field] == 'range_account') {
+ if ($value == 'range_account') {
$valuetoshow = $langs->trans("Range");
}
- if ($fieldlist[$field] == 'sens') {
+ if ($value == 'sens') {
$valuetoshow = $langs->trans("Sens");
}
- if ($fieldlist[$field] == 'category_type') {
+ if ($value == 'category_type') {
$valuetoshow = $langs->trans("Calculated");
}
- if ($fieldlist[$field] == 'formula') {
+ if ($value == 'formula') {
$valuetoshow = $langs->trans("Formula");
}
- if ($fieldlist[$field] == 'paper_size') {
+ if ($value == 'paper_size') {
$valuetoshow = $langs->trans("PaperSize");
}
- if ($fieldlist[$field] == 'orientation') {
+ if ($value == 'orientation') {
$valuetoshow = $langs->trans("Orientation");
}
- if ($fieldlist[$field] == 'leftmargin') {
+ if ($value == 'leftmargin') {
$valuetoshow = $langs->trans("LeftMargin");
}
- if ($fieldlist[$field] == 'topmargin') {
+ if ($value == 'topmargin') {
$valuetoshow = $langs->trans("TopMargin");
}
- if ($fieldlist[$field] == 'spacex') {
+ if ($value == 'spacex') {
$valuetoshow = $langs->trans("SpaceX");
}
- if ($fieldlist[$field] == 'spacey') {
+ if ($value == 'spacey') {
$valuetoshow = $langs->trans("SpaceY");
}
- if ($fieldlist[$field] == 'font_size') {
+ if ($value == 'font_size') {
$valuetoshow = $langs->trans("FontSize");
}
- if ($fieldlist[$field] == 'custom_x') {
+ if ($value == 'custom_x') {
$valuetoshow = $langs->trans("CustomX");
}
- if ($fieldlist[$field] == 'custom_y') {
+ if ($value == 'custom_y') {
$valuetoshow = $langs->trans("CustomY");
}
- if ($fieldlist[$field] == 'percent') {
+ if ($value == 'percent') {
$valuetoshow = $langs->trans("Percentage");
}
- if ($fieldlist[$field] == 'affect') {
+ if ($value == 'affect') {
$valuetoshow = $langs->trans("WithCounter");
}
- if ($fieldlist[$field] == 'delay') {
+ if ($value == 'delay') {
$valuetoshow = $langs->trans("NoticePeriod");
}
- if ($fieldlist[$field] == 'newbymonth') {
+ if ($value == 'newbymonth') {
$valuetoshow = $langs->trans("NewByMonth");
}
- if ($fieldlist[$field] == 'fk_tva') {
+ if ($value == 'fk_tva') {
$valuetoshow = $langs->trans("VAT");
}
- if ($fieldlist[$field] == 'range_ik') {
+ if ($value == 'range_ik') {
$valuetoshow = $langs->trans("RangeIk");
}
- if ($fieldlist[$field] == 'fk_c_exp_tax_cat') {
+ if ($value == 'fk_c_exp_tax_cat') {
$valuetoshow = $langs->trans("CarCategory");
}
- if ($fieldlist[$field] == 'revenuestamp_type') {
+ if ($value == 'revenuestamp_type') {
$valuetoshow = $langs->trans('TypeOfRevenueStamp');
}
- if ($fieldlist[$field] == 'use_default') {
+ if ($value == 'use_default') {
$valuetoshow = $langs->trans('Default'); $class = 'center';
}
- if ($fieldlist[$field] == 'unit_type') {
+ if ($value == 'unit_type') {
$valuetoshow = $langs->trans('TypeOfUnit');
}
- if ($fieldlist[$field] == 'public' && $tablib[$id] == 'TicketDictCategory') {
+ if ($value == 'public' && $tablib[$id] == 'TicketDictCategory') {
$valuetoshow = $langs->trans('TicketGroupIsPublic'); $class = 'center';
}
if ($id == 2) { // Special case for state page
- if ($fieldlist[$field] == 'region_id') {
+ if ($value == 'region_id') {
$valuetoshow = ' '; $showfield = 1;
}
- if ($fieldlist[$field] == 'region') {
+ if ($value == 'region') {
$valuetoshow = $langs->trans("Country").'/'.$langs->trans("Region"); $showfield = 1;
}
}
@@ -1513,13 +1513,13 @@ if ($id) {
print '
';
$filterfound = 0;
foreach ($fieldlist as $field => $value) {
- if ($fieldlist[$field] == 'entity') {
+ if ($value == 'entity') {
continue;
}
$showfield = 1; // By default
- if ($fieldlist[$field] == 'region_id' || $fieldlist[$field] == 'country_id') {
+ if ($value == 'region_id' || $value == 'country_id') {
$showfield = 0;
}
@@ -1555,7 +1555,7 @@ if ($id) {
// Title of lines
print '