From 101c5a2dca5eff6739d9f9b48ece03f0d34d37c2 Mon Sep 17 00:00:00 2001 From: atm-florian Date: Tue, 30 Jan 2024 16:21:51 +0100 Subject: [PATCH] FIX 17.0 - php8 warnings: test for $field existence before checking if it is null or empty --- htdocs/core/class/commonobject.class.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/htdocs/core/class/commonobject.class.php b/htdocs/core/class/commonobject.class.php index 547f2b90e3d..a2c07ecaf47 100644 --- a/htdocs/core/class/commonobject.class.php +++ b/htdocs/core/class/commonobject.class.php @@ -9086,7 +9086,7 @@ abstract class CommonObject foreach ($this->fields as $field => $info) { if ($this->isDate($info)) { - if (is_null($obj->{$field}) || $obj->{$field} === '' || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') { + if (!isset($obj->{$field}) || is_null($obj->{$field}) || $obj->{$field} === '' || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') { $this->{$field} = ''; } else { $this->{$field} = $db->jdate($obj->{$field}); @@ -9102,7 +9102,7 @@ abstract class CommonObject $this->{$field} = (double) $obj->{$field}; } } else { - if (!is_null($obj->{$field}) || (isset($info['notnull']) && $info['notnull'] == 1)) { + if (isset($obj->{$field}) && (!is_null($obj->{$field}) || (isset($info['notnull']) && $info['notnull'] == 1))) { $this->{$field} = (int) $obj->{$field}; } else { $this->{$field} = null; @@ -9117,7 +9117,7 @@ abstract class CommonObject $this->{$field} = (double) $obj->{$field}; } } else { - if (!is_null($obj->{$field}) || (isset($info['notnull']) && $info['notnull'] == 1)) { + if (isset($obj->{$field}) && (!is_null($obj->{$field}) || (isset($info['notnull']) && $info['notnull'] == 1))) { $this->{$field} = (double) $obj->{$field}; } else { $this->{$field} = null;