Fix warning

htdocs/bom/tpl/objectline_view.tpl.php

@@ -34,6 +34,8 @@
  * $type, $text, $description, $line
  */
 
+/** var ObjectLine $line */
+
 require_once DOL_DOCUMENT_ROOT.'/workstation/class/workstation.class.php';
 
 // Protection to avoid direct call of template

htdocs/compta/facture/class/facture-rec.class.php

@@ -1035,6 +1035,10 @@ class FactureRec extends CommonInvoice
 				$this->error = $this->db->lasterror();
 				return -1;
 			}
+		} else {
+			$this->error = 'Recurring Invoice is suspended. adding lines not allowed.';
+
+			return -1;
 		}
 	}
 

htdocs/core/class/html.form.class.php

@@ -813,7 +813,6 @@ class Form
 	{
 		global $conf, $langs, $hookmanager;
 
-
 		$disabled = 0;
 		$ret = '<div class="centpercent center">';
 		$ret .= '<select class="flat' . (empty($conf->use_javascript_ajax) ? '' : ' hideobject') . ' ' . $name . ' ' . $name . 'select valignmiddle alignstart" id="' . $name . '" name="' . $name . '"' . ($disabled ? ' disabled="disabled"' : '') . '>';

htdocs/core/class/html.formother.class.php

@@ -782,7 +782,7 @@ class FormOther
 	 *
 	 *  @param	string		$color				String with hex (FFFFFF) or comma RGB ('255,255,255')
 	 *  @param	string		$textifnotdefined	Text to show if color not defined
-	 *  @return	string							HTML code for color thumb
+	 *  @return	void
 	 *  @see selectColor()
 	 */
 	public static function showColor($color, $textifnotdefined = '')
@@ -1091,7 +1091,7 @@ class FormOther
 	 *  @param	string		$option			Option
 	 *  @param	string		$morecss		More CSS
 	 *  @param  bool		$addjscombo		Add js combo
-	 *  @return	string
+	 *  @return	void
 	 *  @deprecated
 	 */
 	public function select_year($selected = '', $htmlname = 'yearid', $useempty = 0, $min_year = 10, $max_year = 5, $offset = 0, $invert = 0, $option = '', $morecss = 'valignmiddle maxwidth75imp', $addjscombo = false)

htdocs/core/filemanagerdol/connectors/php/connector.lib.php

@@ -127,6 +127,7 @@ function SendErrorNode($number, $text)
 	} else {
 		echo '<Error number="'.$number.'" />';
 	}
+	return '';
 }
 
 

htdocs/core/modules/asset/doc/pdf_standard_asset.modules.php

@@ -1181,7 +1181,7 @@ class pdf_standard_asset extends ModelePDFAsset
 	 *  @param	int			   $hidedetails		Do not show line details
 	 *  @param	int			   $hidedesc		Do not show desc
 	 *  @param	int			   $hideref			Do not show ref
-	 *  @return	null
+	 *  @return	void
 	 */
 	public function defineColumnField($object, $outputlangs, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
 	{

htdocs/core/modules/commande/doc/pdf_einstein.modules.php

@@ -706,6 +706,7 @@ class pdf_einstein extends ModelePDFCommandes
 	protected function _tableau_versements(&$pdf, $object, $posy, $outputlangs)
 	{
 		// phpcs:enable
+		return 1;
 	}
 
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore

htdocs/core/modules/commande/doc/pdf_eratosthene.modules.php

@@ -927,6 +927,7 @@ class pdf_eratosthene extends ModelePDFCommandes
 	 */
 	protected function drawPaymentsTable(&$pdf, $object, $posy, $outputlangs)
 	{
+		return 0;
 	}
 
 	/**
@@ -1733,7 +1734,7 @@ class pdf_eratosthene extends ModelePDFCommandes
 	 *      @param	int				$hidedetails	Do not show line details
 	 *      @param	int				$hidedesc		Do not show desc
 	 *      @param	int				$hideref		Do not show ref
-	 *      @return	null
+	 *      @return	void
 	 */
 	public function defineColumnField($object, $outputlangs, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
 	{

htdocs/core/modules/delivery/doc/pdf_storm.modules.php

@@ -933,7 +933,7 @@ class pdf_storm extends ModelePDFDeliveryOrder
 	 *      @param	int			   $hidedetails		Do not show line details
 	 *      @param	int			   $hidedesc		Do not show desc
 	 *      @param	int			   $hideref			Do not show ref
-	 *      @return	null
+	 *      @return	void
 	 */
 	public function defineColumnField($object, $outputlangs, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
 	{

htdocs/core/modules/expedition/doc/pdf_espadon.modules.php

@@ -1236,7 +1236,7 @@ class pdf_espadon extends ModelePdfExpedition
 	 *      @param	int			   $hidedetails		Do not show line details
 	 *      @param	int			   $hidedesc		Do not show desc
 	 *      @param	int			   $hideref			Do not show ref
-	 *      @return	null
+	 *      @return	void
 	 */
 	public function defineColumnField($object, $outputlangs, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
 	{

htdocs/core/modules/export/export_csviso.modules.php

@@ -78,7 +78,7 @@ class ExportCsvIso extends ExportCsv
 		global $conf;
 		$conf->global->EXPORT_CSV_FORCE_CHARSET = 'ISO-8859-1';
 
-		parent::write_title($array_export_fields_label, $array_selected_sorted, $outputlangs, $array_types);
+		return parent::write_title($array_export_fields_label, $array_selected_sorted, $outputlangs, $array_types);
 	}
 
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
@@ -96,6 +96,6 @@ class ExportCsvIso extends ExportCsv
 		global $conf;
 		$conf->global->EXPORT_CSV_FORCE_CHARSET = 'ISO-8859-1';
 
-		parent::write_record($array_selected_sorted, $objp, $outputlangs, $array_types);
+		return parent::write_record($array_selected_sorted, $objp, $outputlangs, $array_types);
 	}
 }

htdocs/core/modules/export/export_csvutf8.modules.php

@@ -76,7 +76,7 @@ class ExportCsvUtf8 extends ExportCsv
 		global $conf;
 		$conf->global->EXPORT_CSV_FORCE_CHARSET = 'UTF-8';
 
-		parent::write_title($array_export_fields_label, $array_selected_sorted, $outputlangs, $array_types);
+		return parent::write_title($array_export_fields_label, $array_selected_sorted, $outputlangs, $array_types);
 	}
 
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
@@ -94,6 +94,6 @@ class ExportCsvUtf8 extends ExportCsv
 		global $conf;
 
 		$conf->global->EXPORT_CSV_FORCE_CHARSET = 'UTF-8';
-		parent::write_record($array_selected_sorted, $objp, $outputlangs, $array_types);
+		return parent::write_record($array_selected_sorted, $objp, $outputlangs, $array_types);
 	}
 }

htdocs/core/modules/facture/doc/pdf_sponge.modules.php

@@ -2448,7 +2448,7 @@ class pdf_sponge extends ModelePDFFactures
 	 *  @param	int			   $hidedetails		Do not show line details
 	 *  @param	int			   $hidedesc		Do not show desc
 	 *  @param	int			   $hideref			Do not show ref
-	 *  @return	null
+	 *  @return	void
 	 */
 	public function defineColumnField($object, $outputlangs, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
 	{

htdocs/core/modules/import/import_xlsx.modules.php

@@ -341,6 +341,7 @@ class ImportXlsx extends ModeleImports
 		// phpcs:enable
 		$this->workbook->disconnectWorksheets();
 		unset($this->workbook);
+		return 0;
 	}
 
 

htdocs/core/modules/mrp/doc/pdf_vinci.modules.php

@@ -713,6 +713,7 @@ class pdf_vinci extends ModelePDFMo
 	protected function _tableau_versements(&$pdf, $object, $posy, $outputlangs)
 	{
 		// phpcs:enable
+		return 1;
 	}
 
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
@@ -1365,7 +1366,7 @@ class pdf_vinci extends ModelePDFMo
 	 *      @param	int			   $hidedetails		Do not show line details
 	 *      @param	int			   $hidedesc		Do not show desc
 	 *      @param	int			   $hideref			Do not show ref
-	 *      @return	null
+	 *      @return	void
 	 */
 	public function defineColumnField($object, $outputlangs, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
 	{

htdocs/core/modules/propale/doc/pdf_azur.modules.php

@@ -903,6 +903,7 @@ class pdf_azur extends ModelePDFPropales
 	protected function _tableau_versements(&$pdf, $object, $posy, $outputlangs)
 	{
 		// phpcs:enable
+		return 1;
 	}
 
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore

htdocs/core/modules/propale/doc/pdf_cyan.modules.php

@@ -1875,7 +1875,7 @@ class pdf_cyan extends ModelePDFPropales
 	 *      @param	int				$hidedetails	Do not show line details
 	 *      @param	int				$hidedesc		Do not show desc
 	 *      @param	int				$hideref		Do not show ref
-	 *      @return	null
+	 *      @return	void
 	 */
 	public function defineColumnField($object, $outputlangs, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
 	{

htdocs/core/modules/stocktransfer/doc/pdf_eagle_proforma.modules.php

@@ -1448,7 +1448,7 @@ class pdf_eagle_proforma extends ModelePDFCommandes
 	 *      @param	int				$hidedetails	Do not show line details
 	 *      @param	int				$hidedesc		Do not show desc
 	 *      @param	int				$hideref		Do not show ref
-	 *      @return	null
+	 *      @return	void
 	 */
 	public function defineColumnField($object, $outputlangs, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
 	{

htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php

@@ -870,6 +870,7 @@ class pdf_cornas extends ModelePDFSuppliersOrders
 	protected function _tableau_versements(&$pdf, $object, $posy, $outputlangs)
 	{
 		// phpcs:enable
+		return 1;
 	}
 
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
@@ -1497,7 +1498,7 @@ class pdf_cornas extends ModelePDFSuppliersOrders
 	 *      @param	int			   $hidedetails		Do not show line details
 	 *      @param	int			   $hidedesc		Do not show desc
 	 *      @param	int			   $hideref			Do not show ref
-	 *      @return	null
+	 *      @return	void
 	 */
 	public function defineColumnField($object, $outputlangs, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
 	{

htdocs/core/modules/supplier_order/doc/pdf_muscadet.modules.php

@@ -752,6 +752,7 @@ class pdf_muscadet extends ModelePDFSuppliersOrders
 	protected function _tableau_versements(&$pdf, $object, $posy, $outputlangs)
 	{
 		// phpcs:enable
+		return 1;
 	}
 
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore

htdocs/core/modules/supplier_proposal/doc/pdf_aurore.modules.php

@@ -739,6 +739,7 @@ class pdf_aurore extends ModelePDFSupplierProposal
 	protected function _tableau_versements(&$pdf, $object, $posy, $outputlangs)
 	{
 		// phpcs:enable
+		return 1;
 	}
 
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore

htdocs/fourn/class/fournisseur.commande.class.php

@@ -1591,6 +1591,7 @@ class CommandeFournisseur extends CommonOrder
 						$result = $this->call_trigger('ORDER_SUPPLIER_CREATE', $user);
 						if ($result < 0) {
 							$this->db->rollback();
+
 							return -1;
 						}
 						// End call triggers
@@ -1601,12 +1602,18 @@ class CommandeFournisseur extends CommonOrder
 				} else {
 					$this->error = $this->db->lasterror();
 					$this->db->rollback();
+
 					return -2;
 				}
+			} else {
+				$this->error = 'Failed to get ID of inserted line';
+
+				return -1;
 			}
 		} else {
 			$this->error = $this->db->lasterror();
 			$this->db->rollback();
+
 			return -1;
 		}
 	}

htdocs/fourn/class/fournisseur.facture-rec.class.php

@@ -1031,6 +1031,10 @@ class FactureFournisseurRec extends CommonInvoice
 
 				return -1;
 			}
+		} else {
+			$this->error = 'Recurring Invoice is suspended. adding lines not allowed.';
+
+			return -1;
 		}
 	}
 

htdocs/user/class/user.class.php

@@ -3881,6 +3881,8 @@ class User extends CommonObject
 		} else {
 			dol_print_error($this->db);
 		}
+
+		return '';
 	}
 
 	/**