From 490d1f8cfad0921fd6ba839dc7c27d3ebb497e43 Mon Sep 17 00:00:00 2001 From: thibdrev Date: Sat, 20 Jan 2024 21:18:52 +0100 Subject: [PATCH 1/2] qual: phsptan htdocs/core/login/functions_openid.php 62 Function check_user_password_openid() should return string but returns false. htdocs/core/login/functions_openid.php 64 Function check_user_password_openid() should return string but returns false. htdocs/core/login/functions_openid.php 103 Function check_user_password_openid() should return string but returns false. htdocs/core/login/functions_openid.php 107 Function check_user_password_openid() should return string but returns false. htdocs/core/login/functions_openid.php 112 Function check_user_password_openid() should return string but returns false. --- htdocs/core/login/functions_openid.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/core/login/functions_openid.php b/htdocs/core/login/functions_openid.php index f9172f21c87..655c599f734 100644 --- a/htdocs/core/login/functions_openid.php +++ b/htdocs/core/login/functions_openid.php @@ -35,7 +35,7 @@ include_once DOL_DOCUMENT_ROOT.'/core/class/openid.class.php'; * @param string $usertotest Login * @param string $passwordtotest Password * @param int $entitytotest Number of instance (always 1 if module multicompany not enabled) - * @return string Login if OK, '' if KO + * @return string|bool Login if OK, false otherwise */ function check_user_password_openid($usertotest, $passwordtotest, $entitytotest) { From e779bf0f6c08daf1e4b4e735b75e7c85d57f399e Mon Sep 17 00:00:00 2001 From: Laurent Destailleur Date: Sun, 21 Jan 2024 17:39:43 +0100 Subject: [PATCH 2/2] Update functions_openid.php Test use of "false" type --- htdocs/core/login/functions_openid.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/core/login/functions_openid.php b/htdocs/core/login/functions_openid.php index 655c599f734..891fb386774 100644 --- a/htdocs/core/login/functions_openid.php +++ b/htdocs/core/login/functions_openid.php @@ -35,7 +35,7 @@ include_once DOL_DOCUMENT_ROOT.'/core/class/openid.class.php'; * @param string $usertotest Login * @param string $passwordtotest Password * @param int $entitytotest Number of instance (always 1 if module multicompany not enabled) - * @return string|bool Login if OK, false otherwise + * @return string|false Login if OK, false otherwise */ function check_user_password_openid($usertotest, $passwordtotest, $entitytotest) {