* @throws RestException
*/
private function _validate($data)
diff --git a/htdocs/projet/class/project.class.php b/htdocs/projet/class/project.class.php
index 4e76f06bc26..99e27f816ce 100644
--- a/htdocs/projet/class/project.class.php
+++ b/htdocs/projet/class/project.class.php
@@ -1930,7 +1930,7 @@ class Project extends CommonObject
$tasksarray = $taskstatic->getTasksArray(null, null, $fromid, $socid, 0);
$tab_conv_child_parent = array();
- $result_clonse = 0;
+ $result_clone = 0;
// Loop on each task, to clone it
foreach ($tasksarray as $tasktoclone) {
diff --git a/htdocs/projet/element.php b/htdocs/projet/element.php
index 5a25eee1a7f..738ce921f7e 100644
--- a/htdocs/projet/element.php
+++ b/htdocs/projet/element.php
@@ -190,6 +190,13 @@ $hookmanager->initHooks(array('projectOverview'));
//if ($user->socid > 0) $socid = $user->socid; // For external user, no check is done on company because readability is managed by public status of project and assignment.
$result = restrictedArea($user, 'projet', $object->id, 'projet&project');
+$total_duration = 0;
+$total_ttc_by_line = 0;
+$total_ht_by_line = 0;
+$expensereport = null;
+$othermessage = '';
+$tmpprojtime = array();
+$nbAttendees = 0;
/*
* Actions
@@ -1707,14 +1714,16 @@ function canApplySubtotalOn($tablename)
/**
* sortElementsByClientName
*
- * @param array $elementarray Element array
- * @return array Element array sorted
+ * @param int[] $elementarray Element array
+ * @return int[] Element array sorted
*/
function sortElementsByClientName($elementarray)
{
global $db, $classname;
+ '@phan-var-force string $classname';
$element = new $classname($db);
+ '@phan-var-force CommonObject $element';
$clientname = array();
foreach ($elementarray as $key => $id) { // id = id of object
diff --git a/htdocs/projet/tasks/time.php b/htdocs/projet/tasks/time.php
index a917a292a76..f86e08adf6c 100644
--- a/htdocs/projet/tasks/time.php
+++ b/htdocs/projet/tasks/time.php
@@ -2184,12 +2184,12 @@ if (($id > 0 || !empty($ref)) || $projectidforalltimes > 0 || $allprojectforuser
if (!empty($arrayfields['p.fk_soc']['checked'])) {
print '| ';
if ($task_time->fk_soc > 0) {
- if (empty($conf->cache['thridparty'][$task_time->fk_soc])) {
+ if (empty($conf->cache['thirdparty'][$task_time->fk_soc])) {
$tmpsociete = new Societe($db);
$tmpsociete->fetch($task_time->fk_soc);
- $conf->cache['thridparty'][$task_time->fk_soc] = $tmpsociete;
+ $conf->cache['thirdparty'][$task_time->fk_soc] = $tmpsociete;
} else {
- $tmpsociete = $conf->cache['thridparty'][$task_time->fk_soc];
+ $tmpsociete = $conf->cache['thirdparty'][$task_time->fk_soc];
}
print $tmpsociete->getNomUrl(1, '', 100, 0, 1, empty($arrayfields['s.name_alias']['checked']) ? 0 : 1);
}
@@ -2202,12 +2202,12 @@ if (($id > 0 || !empty($ref)) || $projectidforalltimes > 0 || $allprojectforuser
// Thirdparty alias
if (!empty($arrayfields['s.name_alias']['checked'])) {
if ($task_time->fk_soc > 0) {
- if (empty($conf->cache['thridparty'][$task_time->fk_soc])) {
+ if (empty($conf->cache['thirdparty'][$task_time->fk_soc])) {
$tmpsociete = new Societe($db);
$tmpsociete->fetch($task_time->fk_soc);
- $conf->cache['thridparty'][$task_time->fk_soc] = $tmpsociete;
+ $conf->cache['thirdparty'][$task_time->fk_soc] = $tmpsociete;
} else {
- $tmpsociete = $conf->cache['thridparty'][$task_time->fk_soc];
+ $tmpsociete = $conf->cache['thirdparty'][$task_time->fk_soc];
}
$valtoshow = $tmpsociete->name_alias;
}
diff --git a/htdocs/public/cron/cron_run_jobs_by_url.php b/htdocs/public/cron/cron_run_jobs_by_url.php
index 86c0cc76299..2ded3bfb832 100644
--- a/htdocs/public/cron/cron_run_jobs_by_url.php
+++ b/htdocs/public/cron/cron_run_jobs_by_url.php
@@ -3,6 +3,7 @@
* Copyright (C) 2013 Florian Henry
* Copyright (C) 2013-2015 Laurent Destailleur
* Copyright (C) 2017 Regis Houssin
+ * Copyright (C) 2024 MDW
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -106,7 +107,7 @@ if (empty($userlogin)) {
}
require_once DOL_DOCUMENT_ROOT.'/user/class/user.class.php';
$user = new User($db);
-$result = $user->fetch('', $userlogin);
+$result = $user->fetch(0, $userlogin);
if ($result < 0) {
echo "User Error:".$user->error;
dol_syslog("cron_run_jobs.php:: User Error:".$user->error, LOG_ERR);
@@ -168,7 +169,7 @@ if (is_array($object->lines) && (count($object->lines) > 0)) {
// Force recheck that user is ok for the entity to process and reload permission for entity
if ($conf->entity != $user->entity && $user->entity != 0) {
- $result = $user->fetch('', $userlogin, '', 0, $conf->entity);
+ $result = $user->fetch(0, $userlogin, '', 0, $conf->entity);
if ($result < 0) {
echo "\nUser Error: ".$user->error."\n";
dol_syslog("cron_run_jobs.php:: User Error:".$user->error, LOG_ERR);
diff --git a/htdocs/public/project/new.php b/htdocs/public/project/new.php
index 4d1c514d3c7..70344778e43 100644
--- a/htdocs/public/project/new.php
+++ b/htdocs/public/project/new.php
@@ -263,6 +263,7 @@ if (empty($reshook) && $action == 'add') { // Test on permission not required he
// Search template files
$file = '';
$classname = '';
+ $reldir = '';
$filefound = 0;
$dirmodels = array_merge(array('/'), (array) $conf->modules_parts['models']);
foreach ($dirmodels as $reldir) {
@@ -278,6 +279,7 @@ if (empty($reshook) && $action == 'add') { // Test on permission not required he
$result = dol_include_once($reldir."core/modules/project/".$modele.'.php');
if (class_exists($classname)) {
$modProject = new $classname();
+ '@phan-var-force ModeleNumRefProjects $modProject';
$defaultref = $modProject->getNextValue($thirdparty, $object);
}
diff --git a/htdocs/societe/class/societe.class.php b/htdocs/societe/class/societe.class.php
index 7d7b9f47dd7..5ef48d7d397 100644
--- a/htdocs/societe/class/societe.class.php
+++ b/htdocs/societe/class/societe.class.php
@@ -5563,7 +5563,7 @@ class Societe extends CommonObject
'Account' => '/compta/bank/class/account.class.php',
'ConferenceOrBoothAttendee' => '/eventorganization/class/conferenceorboothattendee.class.php',
'Societe' => '/societe/class/societe.class.php',
- //'SocieteAccount', 'SocietePrice', 'SocieteRib',... are processed into the replaceThirparty of Societe.
+ //'SocieteAccount', 'SocietePrice', 'SocieteRib',... are processed into the replaceThirdparty of Societe.
);
if ($this->db->DDLListTables($conf->db->name, $this->db->prefix().'delivery')) {
$objects['Delivery'] = '/delivery/class/delivery.class.php';
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
index 4dbc3a640b4..c31b481b3c8 100644
--- a/phpstan.neon.dist
+++ b/phpstan.neon.dist
@@ -65,7 +65,10 @@ parameters:
- '#(?:empty\(\) is always) fals#'
- '#(\$force_dolibarr_lib|\$dolibarr_main_db).*in empty\(\) is never defined.#'
- '#Sprain\\SwissQrBill\\#'
- - '#Constructor of class (?:Dol(?:Editor|iDB(?:Mysqli|Pgsql|Sqlite3))|(?:ModeleBox|box_accountancy_last_manual_entri)es|box_(?:ac(?:countancy_suspense_account|ti(?:ons(?:_future)?|vity))|b(?:irthdays(?:_members)?|o(?:(?:okmark|m)s))|c(?:(?:lient|o(?:m(?:(?:mand|pt)e)|nt(?:r?act)))s|ustomers_outstanding_bill_reached)|dolibarr_state_board|f(?:actures(?:_(?:fourn(?:_imp)?|imp))?|icheinter|ournisseurs|unnel_of_prospection)|g(?:oodcustomers|raph_(?:invoices_(?:per(?:month|year)|supplier_permonth)|n(?:b_ticket(?:_last_x_days|s_type)|ew_vs_close_ticket)|orders_(?:(?:supplier_)?permonth)|pro(?:duct_distribution|pales_permonth)|ticket_by_severity))|last(?:_(?:(?:modified_)?knowledgerecord|(?:modified_)?ticket)|login)|m(?:embers_(?:by_t(?:ags|ype)|last_(?:modified|subscriptions)|subscriptions_by_year)|os)|pro(?:duits(?:_alerte_stock)?|ject(?:_opportunities)?|pales|spect)|s(?:(?:cheduled_job|ervices_contract)s|ervices_expired|(?:hipment|upplier_order)s|upplier_orders_awaiting_reception)|task|validated_projects)).* has an unused parameter #'
+ - '#(?:Constructor of class (?:(?:ModeleBox|box_accountancy_last_manual_entri)es|box_(?:ac(?:countancy_suspense_account|ti(?:ons(?:_future)?|vity))|b(?:irthdays(?:_members)?|o(?:(?:okmark|m)s))|c(?:(?:lient|o(?:m(?:(?:mand|pt)e)|nt(?:r?act)))s|ustomers_outstanding_bill_reached)|dolibarr_state_board|f(?:actures(?:_(?:fourn(?:_imp)?|imp))?|icheinter|ournisseurs|unnel_of_prospection)|g(?:oodcustomers|raph_(?:invoices_(?:per(?:month|year)|supplier_permonth)|n(?:b_ticket(?:_last_x_days|s_type)|ew_vs_close_ticket)|orders_(?:(?:supplier_)?permonth)|pro(?:duct_distribution|pales_permonth)|ticket_by_severity))|last(?:_(?:(?:modified_)?knowledgerecord|(?:modified_)?ticket)|login)|m(?:embers_(?:by_t(?:ags|ype)|last_(?:modified|subscriptions)|subscriptions_by_year)|os)|pro(?:duits(?:_alerte_stock)?|ject(?:_opportunities)?|pales|spect)|s(?:(?:cheduled_job|ervices_contract)s|ervices_expired|(?:hipment|upplier_order)s|upplier_orders_awaiting_reception)|task|validated_projects))) has an unused parameter \$param\.#'
+ - '#(?:Constructor of class DoliDB(?:Mysqli|Pgsql|Sqlite3)) has an unused parameter \$type\.#'
+ - '#(?:Constructor of class DolEditor) has an unused parameter \$toolbarlocation\.#'
+
- '#Dead catch - Exception is never thrown in the try block#'
- '#.*phan-var#'
- '#(?:(?:s(?:(?:et_error_handl|pl_autoload_regist)er)|array_filter)) expects \(callable#'
|