Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2026-02-11 18:32:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix regression. Add unit test to detect it.

Browse Source
This commit is contained in:
Laurent Destailleur
2022-03-03 01:17:44 +01:00
parent a9a2928e63
commit 3c3d6ab0da
3 changed files with 35 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/phpunit/SecurityTest.php
View File

@@ -914,7 +914,16 @@ class SecurityTest extends PHPUnit\Framework\TestCase
print "result = ".$result."\n";
$this->assertContains('Bad string syntax to evaluate', $result);
global $leftmenu;
$leftmenu = 'admintools';
$conf->barcode->enabled = 1;
$result=dol_eval('$conf->barcode->enabled && preg_match(\'/^(admintools|all)/\',$leftmenu)', 1, 0, '2');
print "result = ".$result."\n";
$this->assertTrue($result);
// Case with param onlysimplestring = 1
$result=dol_eval('1 && getDolGlobalInt("doesnotexist1") && $conf->global->MAIN_FEATURES_LEVEL', 1, 0); // Should return false and not a 'Bad string syntax to evaluate ...'
print "result = ".$result."\n";
$this->assertFalse($result);