Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2026-02-07 16:41:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix some code smell (#26277)

Browse Source 
* Fix some code smell

* Update commande.class.php

---------

Co-authored-by: Hystepik <lucas.marcouiller@gmail.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
This commit is contained in:
Lucas Marcouiller
2023-10-20 02:20:26 +02:00
committed by GitHub
parent 76d7acb676
commit 42865a975a
6 changed files with 50 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
htdocs/api/class/api_documents.class.php
View File

@@ -255,15 +255,15 @@ class Documents extends DolibarrApi
} elseif ($modulepart == 'expedition' || $modulepart == 'shipment') {
require_once DOL_DOCUMENT_ROOT . '/expedition/class/expedition.class.php';
$this->shipment = new Expedition($this->db);
$result = $this->shipment->fetch(0, preg_replace('/\.[^\.]+$/', '', basename($original_file)));
$tmpobject = new Expedition($this->db);
$result = $tmpobject->fetch(0, preg_replace('/\.[^\.]+$/', '', basename($original_file)));
if (!$result) {
throw new RestException(404, 'Shipment not found');
}
$templateused = $doctemplate ? $doctemplate : $this->shipment->model_pdf;
$result = $this->shipment->generateDocument($templateused, $outputlangs, $hidedetails, $hidedesc, $hideref);
$templateused = $doctemplate ? $doctemplate : $tmpobject->model_pdf;
$result = $tmpobject->generateDocument($templateused, $outputlangs, $hidedetails, $hidedesc, $hideref);
if ($result <= 0) {
throw new RestException(500, 'Error generating document missing doctemplate parameter');