Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2025-12-18 23:41:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

QUAL Add phpunit test to avoid a bad code sequence

Browse Source
This commit is contained in:
Laurent Destailleur
2025-11-03 02:00:01 +01:00
parent e4e2e06306
commit 70d4461c1d
5 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/phpunit/CodingPhpTest.php
View File

@@ -260,7 +260,7 @@ class CodingPhpTest extends CommonClassTest
//exit;
}
// Check for unauthorised vardumps
// Check for unauthorised var_dumps
if (!preg_match('/test\/phpunit/', $file['fullname'])) {
$this->verifyNoActiveVardump($filecontent, $report_filepath);
}
@@ -632,6 +632,15 @@ class CodingPhpTest extends CommonClassTest
}
$this->assertTrue($ok, 'Found a preg_grep with a param that is a $var but without preg_quote in file '.$file['relativename'].'.');
// Test we don't have preg_grep with a param without preg_quote
$ok = true;
$matches = array();
preg_match_all('/= getEntity\(["\'a-z]*\)/', $filecontent, $matches, PREG_SET_ORDER);
foreach ($matches as $key => $val) {
$ok = false;
break;
}
$this->assertTrue($ok, 'Found a sequence "= getEntity(\'...\')" that is not allowed. We should have IN getEntity or = conf->entity in file '.$file['relativename'].'.');
// Test we don't have "if ($resql >"
$ok = true;