From 7fb7d38ffcb5114c9084f64b9e22a3ea558e0ac8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?=
 <frederic34@users.noreply.github.com>
Date: Sun, 28 Sep 2025 20:56:54 +0200
Subject: [PATCH] clean code (#35533)

---
 .../class/api_interventions.class.php          | 13 +++++++------
 .../template/class/api_mymodule.class.php      | 18 +++++++++---------
 2 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/htdocs/fichinter/class/api_interventions.class.php b/htdocs/fichinter/class/api_interventions.class.php
index f47e7bad5a0..7a11089c887 100644
--- a/htdocs/fichinter/class/api_interventions.class.php
+++ b/htdocs/fichinter/class/api_interventions.class.php
@@ -3,6 +3,7 @@
  * Copyright (C) 2016	Laurent Destailleur		<eldy@users.sourceforge.net>
  * Copyright (C) 2025	William Mead			<william@m34d.com>
  * Copyright (C) 2025	Charlene Benke			<charlene@patas-monkey.com>
+ * Copyright (C) 2025       Frédéric France         <frederic.france@free.fr>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -181,15 +182,15 @@ class Interventions extends DolibarrApi
 			$action = 'list';
 			$reshook = $hookmanager->executeHooks('printFieldListWhere', $parameters, $this->fichinter, $action); // Note that $action and $object may have been modified by hook
 			if ($reshook > 0) {
-				$sql .= $hookmanager->resPrint;
+				$sql = $hookmanager->resPrint;
 			} elseif ($reshook == 0) {
 				$sql .= $hookmanager->resPrint;
+			}
 
-				$errormessage = '';
-				$sql .= forgeSQLFromUniversalSearchCriteria($sqlfilters, $errormessage);
-				if ($errormessage) {
-					throw new RestException(400, 'Error when validating parameter sqlfilters -> '.$errormessage);
-				}
+			$errormessage = '';
+			$sql .= forgeSQLFromUniversalSearchCriteria($sqlfilters, $errormessage);
+			if ($errormessage) {
+				throw new RestException(400, 'Error when validating parameter sqlfilters -> '.$errormessage);
 			}
 		}
 
diff --git a/htdocs/modulebuilder/template/class/api_mymodule.class.php b/htdocs/modulebuilder/template/class/api_mymodule.class.php
index 68468baf460..93c9dd26499 100644
--- a/htdocs/modulebuilder/template/class/api_mymodule.class.php
+++ b/htdocs/modulebuilder/template/class/api_mymodule.class.php
@@ -1,6 +1,6 @@
 <?php
 /* Copyright (C) 2015		Jean-François Ferry		<jfefe@aternatik.fr>
- * Copyright (C) 2024		Frédéric France			<frederic.france@free.fr>
+ * Copyright (C) 2024-2025  Frédéric France			<frederic.france@free.fr>
  * Copyright (C) ---Replace with your own copyright and developer email---
  *
  * This program is free software; you can redistribute it and/or modify
@@ -160,20 +160,20 @@ class MyModuleApi extends DolibarrApi
 			}
 		}
 		// Add where from hooks and sqlfilters
-		$parameters = array('sqlfilters' => $sqlfilters, 'apiroute' => 'myobject', 'apimethod' => 'index');
+		$parameters = array('sqlfilters' => $sqlfilters, 'apiroute' => 'myobject', 'apimethod' => __METHOD__);
 		$action = 'list';
 		$reshook = $hookmanager->executeHooks('printFieldListWhere', $parameters, $tmpobject, $action); // Note that $action and $object may have been modified by hook
 		if ($reshook > 0) {
-			$sql .= $hookmanager->resPrint;
+			$sql = $hookmanager->resPrint;
 		} elseif ($reshook == 0) {
 			$sql .= $hookmanager->resPrint;
+		}
 
-			if ($sqlfilters) {
-				$errormessage = '';
-				$sql .= forgeSQLFromUniversalSearchCriteria($sqlfilters, $errormessage);
-				if ($errormessage) {
-					throw new RestException(400, 'Error when validating parameter sqlfilters -> '.$errormessage);
-				}
+		if ($sqlfilters) {
+			$errormessage = '';
+			$sql .= forgeSQLFromUniversalSearchCriteria($sqlfilters, $errormessage);
+			if ($errormessage) {
+				throw new RestException(400, 'Error when validating parameter sqlfilters -> '.$errormessage);
 			}
 		}