Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2025-12-05 17:18:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

FIX #4182 SQL error when deleting an unexisting bank entry

Browse Source
This commit is contained in:
Marcos García de La Fuente
2015-12-24 14:39:28 +01:00
parent 2d3915b88c
commit 8b633aee66
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
htdocs/compta/bank/class/account.class.php
View File

@@ -1277,12 +1277,12 @@ class AccountLine extends CommonObject
$nbko++; $nbko++;
} }
$sql = "DELETE FROM ".MAIN_DB_PREFIX."bank_class WHERE lineid=".$this->rowid; $sql = "DELETE FROM ".MAIN_DB_PREFIX."bank_class WHERE lineid=".(int) $this->rowid;
dol_syslog(get_class($this)."::delete", LOG_DEBUG); dol_syslog(get_class($this)."::delete", LOG_DEBUG);
$result = $this->db->query($sql); $result = $this->db->query($sql);
if (! $result) $nbko++; if (! $result) $nbko++;
$sql = "DELETE FROM ".MAIN_DB_PREFIX."bank WHERE rowid=".$this->rowid; $sql = "DELETE FROM ".MAIN_DB_PREFIX."bank WHERE rowid=".(int) $this->rowid;
dol_syslog(get_class($this)."::delete", LOG_DEBUG); dol_syslog(get_class($this)."::delete", LOG_DEBUG);
$result = $this->db->query($sql); $result = $this->db->query($sql);
if (! $result) $nbko++; if (! $result) $nbko++;
@@ -1319,7 +1319,7 @@ class AccountLine extends CommonObject
$this->db->begin(); $this->db->begin();
$sql = "DELETE FROM ".MAIN_DB_PREFIX."bank_url WHERE fk_bank=".$this->rowid; $sql = "DELETE FROM ".MAIN_DB_PREFIX."bank_url WHERE fk_bank=".(int) $this->rowid;
dol_syslog(get_class($this)."::delete_urls", LOG_DEBUG); dol_syslog(get_class($this)."::delete_urls", LOG_DEBUG);
$result = $this->db->query($sql); $result = $this->db->query($sql);
if (! $result) $nbko++; if (! $result) $nbko++;

9
htdocs/compta/bank/rappro.php
View File

@@ -99,12 +99,15 @@ if ($action == 'rappro' && $user->rights->banque->consolidate)
if ($action == 'del') if ($action == 'del')
{ {
$bankline=new AccountLine($db); $bankline=new AccountLine($db);
$bankline->fetch($_GET["rowid"]);
if ($bankline->fetch($_GET["rowid"]) > 1) {
$result = $bankline->delete($user); $result = $bankline->delete($user);
if ($result < 0) if ($result < 0) {
{
dol_print_error($db, $bankline->error); dol_print_error($db, $bankline->error);
} }
} else {
setEventMessage($langs->trans('ErrorRecordNotFound'), 'errors');
}
} }