From a55f70e561cca1b51b0dfb57b81854632df9db79 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@users.sourceforge.net>
Date: Thu, 2 Aug 2007 22:12:41 +0000
Subject: [PATCH] Perf: Optimisation de la box des comptes: Nbre de requetes
 sql divise par 3.

---
 htdocs/compta/bank/account.class.php  |  2 +-
 htdocs/includes/boxes/box_comptes.php | 31 ++++++++++++++++-----------
 2 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/htdocs/compta/bank/account.class.php b/htdocs/compta/bank/account.class.php
index 7c7f58b198c..0a0b270544f 100644
--- a/htdocs/compta/bank/account.class.php
+++ b/htdocs/compta/bank/account.class.php
@@ -424,7 +424,7 @@ class Account
     
     
     /*
-     *      \brief      Charge en memoire depuis la base le compte
+     *      \brief      Charge un compte en memoire depuis la base
      *      \param      id      Id du compte à récupérer
      */
     function fetch($id)
diff --git a/htdocs/includes/boxes/box_comptes.php b/htdocs/includes/boxes/box_comptes.php
index 38559091286..8a00abb4960 100644
--- a/htdocs/includes/boxes/box_comptes.php
+++ b/htdocs/includes/boxes/box_comptes.php
@@ -1,6 +1,6 @@
 <?php
-/* Copyright (C) 2005 Christophe
- * Copyright (C) 2005 Laurent Destailleur  <eldy@users.sourceforge.net>
+/* Copyright (C) 2005      Christophe
+ * Copyright (C) 2005-2007 Laurent Destailleur  <eldy@users.sourceforge.net>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -67,14 +67,18 @@ class box_comptes extends ModeleBoxes {
 
 		if ($user->rights->banque->lire)
 		{
-			$sql  = "SELECT rowid, label, bank, number, currency_code";
-			$sql .= " FROM ".MAIN_DB_PREFIX."bank_account";
-			$sql .= " WHERE clos = 0 AND courant = 1";
-			$sql .= " ORDER BY label";
-			$sql .= $db->plimit($max, 0);
+	        $sql = "SELECT rowid, ref, label, bank, number, courant, clos, rappro, url,";
+	        $sql.= " code_banque, code_guichet, cle_rib, bic, iban_prefix,";
+	        $sql.= " domiciliation, proprio, adresse_proprio,";
+	        $sql.= " account_number, currency_code,";
+	        $sql.= " min_allowed, min_desired, comment";
+			$sql.= " FROM ".MAIN_DB_PREFIX."bank_account";
+			$sql.= " WHERE clos = 0 AND courant = 1";
+			$sql.= " ORDER BY label";
+			$sql.= $db->plimit($max, 0);
 
+			dolibarr_syslog("box_comptes::loadBox sql=".$sql);
 			$result = $db->query($sql);
-
 			if ($result)
 			{
 				$num = $db->num_rows($result);
@@ -82,12 +86,15 @@ class box_comptes extends ModeleBoxes {
 				$i = 0;
 				$solde_total = 0;
 
+				$account_static = new Account($db);
 				while ($i < $num)
 				{
 					$objp = $db->fetch_object($result);
-					$acc = new Account($db);
-					$acc->fetch($objp->rowid);
-					$solde_total += $acc->solde();
+					
+					$account_static->id = $objp->rowid;
+					$solde=$account_static->solde();
+					
+					$solde_total += $solde;
 
 					$this->info_box_contents[$i][0] = array('align' => 'left',
 					'logo' => $this->boximg,
@@ -105,7 +112,7 @@ class box_comptes extends ModeleBoxes {
 					);
 
 					$this->info_box_contents[$i][2] = array('align' => 'right',
-					'text' => price($acc->solde()).' '.$langs->trans("Currency".$objp->currency_code)
+					'text' => price($solde).' '.$langs->trans("Currency".$objp->currency_code)
 					);
 
 					$i++;