Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2026-01-02 23:22:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean code

Browse Source
This commit is contained in:
ldestailleur
2025-09-18 15:00:47 +02:00
parent f665a0301e
commit b30aa97ba9
4 changed files with 37 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
dev/tools/rector/src/Renaming/GlobalToFunction.php
View File

@@ -307,8 +307,23 @@ class GlobalToFunction extends AbstractRector
if (empty($constName)) {
return;
}
// Test the type after the comparison conf->global->xxx to know the name of function
$typeleft = $node->left->getType();
switch ($typeleft) {
case 'Scalar_LNumber':
$funcName = 'getDolGlobalInt';
break;
case 'Scalar_String':
$funcName = 'getDolGlobalString';
break;
default: // Can be Expr_FuncCall
$funcName = 'getDolGlobalString';
break;
}
$node->right = new FuncCall(
new Name('getDolGlobalString'),
new Name($funcName),
[new Arg($constName)]
);
return $node;