From b5c6ead33bb19bb7c62f9c66674aa4b87ba899cc Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Mon, 30 Sep 2024 20:23:27 +0200
Subject: [PATCH] FIX Tool to convert into utf8

---
 htdocs/admin/system/database-tables.php | 26 +++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/htdocs/admin/system/database-tables.php b/htdocs/admin/system/database-tables.php
index cf8f5771b32..fa7a86480ba 100644
--- a/htdocs/admin/system/database-tables.php
+++ b/htdocs/admin/system/database-tables.php
@@ -52,12 +52,30 @@ if ($action == 'convert') {	// Convert engine into innodb
 	$db->query($sql);
 }
 if ($action == 'convertutf8') {
-	$sql = "ALTER TABLE ".$db->sanitize($table)." CONVERT TO CHARACTER SET utf8 COLLATE utf8_unicode_ci";
-	$db->query($sql);
+	$sql = "ALTER TABLE ".$db->sanitize($table)." CHARACTER SET utf8 COLLATE utf8_unicode_ci";	// Set the default value on table
+	$resql1 = $db->query($sql);
+	if (!$resql1) {
+		setEventMessages($db->lasterror(), null, 'warnings');
+	} else {
+		$sql = "ALTER TABLE ".$db->sanitize($table)." CONVERT TO CHARACTER SET utf8 COLLATE utf8_unicode_ci";	// Switch fields (may fails due to foreign key)
+		$resql2 = $db->query($sql);
+		if (!$resql2) {
+			setEventMessages($db->lasterror(), null, 'warnings');
+		}
+	}
 }
 if ($action == 'convertutf8mb4') {
-	$sql = "ALTER TABLE ".$db->sanitize($table)." CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci";
-	$db->query($sql);
+	$sql = "ALTER TABLE ".$db->sanitize($table)." CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci";	// Set the default value on table
+	$resql1 = $db->query($sql);
+	if (!$resql1) {
+		setEventMessages($db->lasterror(), null, 'warnings');
+	} else {
+		$sql = "ALTER TABLE ".$db->sanitize($table)." CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci";	// Switch fields (may fails due to foreign key)
+		$resql2 = $db->query($sql);
+		if (!$resql2) {
+			setEventMessages($db->lasterror(), null, 'warnings');
+		}
+	}
 }
 if ($action == 'convertdynamic') {
 	$sql = "ALTER TABLE ".$db->sanitize($table)." ROW_FORMAT=DYNAMIC;";