Merge pull request #5859 from GPCsolutions/5858

Fix module activation errors
This commit is contained in:
Laurent Destailleur
2016-10-15 02:20:49 +02:00
committed by GitHub

View File

@@ -714,8 +714,11 @@ function activateModule($value,$withdeps=1)
{ {
global $db, $modules, $langs, $conf; global $db, $modules, $langs, $conf;
// Check parameters // Check parameters
if (empty($value)) return 'ErrorBadParameter'; if (empty($value)) {
$ret['errors'][] = 'ErrorBadParameter';
return $ret;
}
$ret=array('nbmodules'=>0, 'errors'=>array(), 'nbperms'=>0); $ret=array('nbmodules'=>0, 'errors'=>array(), 'nbperms'=>0);
$modName = $value; $modName = $value;
@@ -740,25 +743,25 @@ function activateModule($value,$withdeps=1)
// Test if PHP version ok // Test if PHP version ok
$verphp=versionphparray(); $verphp=versionphparray();
$vermin=isset($objMod->phpmin)?$objMod->phpmin:0; $vermin=isset($objMod->phpmin)?$objMod->phpmin:0;
if (is_array($vermin) && versioncompare($verphp,$vermin) < 0) if (is_array($vermin) && versioncompare($verphp, $vermin) < 0) {
{ $ret['errors'][] = $langs->trans("ErrorModuleRequirePHPVersion", versiontostring($vermin));
return $langs->trans("ErrorModuleRequirePHPVersion",versiontostring($vermin)); return $ret;
} }
// Test if Dolibarr version ok // Test if Dolibarr version ok
$verdol=versiondolibarrarray(); $verdol=versiondolibarrarray();
$vermin=isset($objMod->need_dolibarr_version)?$objMod->need_dolibarr_version:0; $vermin=isset($objMod->need_dolibarr_version)?$objMod->need_dolibarr_version:0;
//print 'eee '.versioncompare($verdol,$vermin).' - '.join(',',$verdol).' - '.join(',',$vermin);exit; //print 'eee '.versioncompare($verdol,$vermin).' - '.join(',',$verdol).' - '.join(',',$vermin);exit;
if (is_array($vermin) && versioncompare($verdol,$vermin) < 0) if (is_array($vermin) && versioncompare($verdol, $vermin) < 0) {
{ $ret['errors'][] = $langs->trans("ErrorModuleRequireDolibarrVersion", versiontostring($vermin));
return $langs->trans("ErrorModuleRequireDolibarrVersion",versiontostring($vermin)); return $ret;
} }
// Test if javascript requirement ok // Test if javascript requirement ok
if (! empty($objMod->need_javascript_ajax) && empty($conf->use_javascript_ajax)) if (!empty($objMod->need_javascript_ajax) && empty($conf->use_javascript_ajax)) {
{ $ret['errors'][] = $langs->trans("ErrorModuleRequireJavascript");
return $langs->trans("ErrorModuleRequireJavascript"); return $ret;
} }
$result=$objMod->init(); $result=$objMod->init();
if ($result <= 0) if ($result <= 0)