Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2026-01-06 09:02:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #28799 from mdeweerd/fix/PhanPluginDuplicateExpressionAssignmentOperation

Browse Source 
Fix & enable PhanPluginDuplicateExpressionAssignment
This commit is contained in:
Laurent Destailleur
2024-03-13 14:49:21 +01:00
committed by GitHub
parent 231072335d 6170ebe82e
commit cad8f24322
15 changed files with 42 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
dev/tools/phan/config.php
View File

@@ -410,8 +410,7 @@ return [
'PhanDeprecatedProperty',
'PhanDeprecatedFunction',
//'PhanCompatibleNegativeStringOffset',
// Dolibarr has quite a few strange noop assignments like $abc=$abc;
'PhanPluginDuplicateExpressionAssignment',
// 'PhanPluginDuplicateExpressionAssignment',
// Nulls are likely mostly false positives
'PhanPluginConstantVariableNull',
'PhanTypeObjectUnsetDeclaredProperty',
@@ -601,7 +600,7 @@ return [
'PhanUndeclaredClassMethod',
'PhanUndeclaredMethod',
'PhanTypeMismatchArgumentProbablyReal',
'PhanPluginDuplicateExpressionAssignmentOperation',
'PhanPluginDuplicateExpressionAssignmentOperation', // Suggestions for optimisation
'PhanTypeMismatchPropertyDefault',
// 'PhanPluginAlwaysReturnMethod',
// 'PhanPluginMissingReturnMethod',