From d3c65e390bd46cf5002429bc24e6ec9f6d218812 Mon Sep 17 00:00:00 2001 From: Regis Houssin Date: Tue, 28 Feb 2023 15:47:33 +0100 Subject: [PATCH] TODO remise_percent is a deprecated field for object parent --- htdocs/comm/propal/class/propal.class.php | 23 ++++++----- htdocs/commande/class/commande.class.php | 21 +++++++--- htdocs/compta/facture/class/facture.class.php | 38 ++++++++++++------- .../asset/doc/pdf_standard_asset.modules.php | 5 ++- .../commande/doc/pdf_einstein.modules.php | 5 ++- .../commande/doc/pdf_eratosthene.modules.php | 5 ++- .../modules/facture/doc/pdf_crabe.modules.php | 5 ++- .../facture/doc/pdf_sponge.modules.php | 5 ++- .../modules/propale/doc/pdf_azur.modules.php | 5 ++- .../modules/propale/doc/pdf_cyan.modules.php | 5 ++- .../doc/pdf_eagle_proforma.modules.php | 5 ++- .../doc/pdf_canelle.modules.php | 5 ++- .../supplier_order/doc/pdf_cornas.modules.php | 5 ++- .../doc/pdf_muscadet.modules.php | 5 ++- .../doc/pdf_aurore.modules.php | 5 ++- 15 files changed, 89 insertions(+), 53 deletions(-) diff --git a/htdocs/comm/propal/class/propal.class.php b/htdocs/comm/propal/class/propal.class.php index d71e4a93c2f..05e8bd916fe 100644 --- a/htdocs/comm/propal/class/propal.class.php +++ b/htdocs/comm/propal/class/propal.class.php @@ -208,6 +208,10 @@ class Propal extends CommonObject public $cond_reglement_code; public $deposit_percent; public $mode_reglement_code; + + /** + * @deprecated + */ public $remise_percent; /** @@ -309,7 +313,7 @@ class Propal extends CommonObject 'fk_user_valid' =>array('type'=>'integer:User:user/class/user.class.php', 'label'=>'UserValidation', 'enabled'=>1, 'visible'=>-1, 'position'=>90), 'fk_user_cloture' =>array('type'=>'integer:User:user/class/user.class.php', 'label'=>'Fk user cloture', 'enabled'=>1, 'visible'=>-1, 'position'=>95), 'price' =>array('type'=>'double', 'label'=>'Price', 'enabled'=>1, 'visible'=>-1, 'position'=>105), - 'remise_percent' =>array('type'=>'double', 'label'=>'RelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>110), + //'remise_percent' =>array('type'=>'double', 'label'=>'RelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>110), //'remise_absolue' =>array('type'=>'double', 'label'=>'CustomerRelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>115), //'remise' =>array('type'=>'double', 'label'=>'Remise', 'enabled'=>1, 'visible'=>-1, 'position'=>120), 'total_ht' =>array('type'=>'double(24,8)', 'label'=>'TotalHT', 'enabled'=>1, 'visible'=>-1, 'position'=>125, 'isameasure'=>1), @@ -1087,9 +1091,9 @@ class Propal extends CommonObject $sql = "INSERT INTO ".MAIN_DB_PREFIX."propal ("; $sql .= "fk_soc"; $sql .= ", price"; - $sql .= ", remise"; - $sql .= ", remise_percent"; - $sql .= ", remise_absolue"; + $sql .= ", remise"; // deprecated + $sql .= ", remise_percent"; // deprecated + $sql .= ", remise_absolue"; // deprecated $sql .= ", total_tva"; $sql .= ", total_ttc"; $sql .= ", datep"; @@ -1122,7 +1126,7 @@ class Propal extends CommonObject $sql .= $this->socid; $sql .= ", 0"; $sql .= ", ".((float) $this->remise); // deprecated - $sql .= ", ".($this->remise_percent ? ((float) $this->remise_percent) : 'NULL'); + $sql .= ", ".($this->remise_percent ? ((float) $this->remise_percent) : 'NULL'); // deprecated $sql .= ", ".($this->remise_absolue ? ((float) $this->remise_absolue) : 'NULL'); // deprecated $sql .= ", 0"; $sql .= ", 0"; @@ -1577,10 +1581,10 @@ class Propal extends CommonObject $this->ref = $obj->ref; $this->ref_client = $obj->ref_client; - $this->remise = $obj->remise; - $this->remise_percent = $obj->remise_percent; - $this->remise_absolue = $obj->remise_absolue; - $this->total = $obj->total_ttc; // TODO deprecated + $this->remise = $obj->remise; // TODO deprecated + $this->remise_percent = $obj->remise_percent; // TODO deprecated + $this->remise_absolue = $obj->remise_absolue; // TODO deprecated + $this->total = $obj->total_ttc; // TODO deprecated $this->total_ttc = $obj->total_ttc; $this->total_ht = $obj->total_ht; $this->total_tva = $obj->total_tva; @@ -2427,6 +2431,7 @@ class Propal extends CommonObject * @param double $remise Amount discount * @param int $notrigger 1=Does not execute triggers, 0= execute triggers * @return int <0 if ko, >0 if ok + * @deprecated remise_percent is a deprecated field for object parent */ public function set_remise_percent($user, $remise, $notrigger = 0) { diff --git a/htdocs/commande/class/commande.class.php b/htdocs/commande/class/commande.class.php index 2cca732e374..f260a54fac6 100644 --- a/htdocs/commande/class/commande.class.php +++ b/htdocs/commande/class/commande.class.php @@ -216,8 +216,16 @@ class Commande extends CommonOrder */ public $fk_remise_except; + /** + * @deprecated + */ public $remise_percent; + + /** + * @deprecated + */ public $remise_absolue; + public $info_bits; public $rang; public $special_code; @@ -322,8 +330,8 @@ class Commande extends CommonOrder 'fk_user_cloture' =>array('type'=>'integer:User:user/class/user.class.php', 'label'=>'UserClosing', 'enabled'=>1, 'visible'=>-1, 'position'=>90), 'source' =>array('type'=>'smallint(6)', 'label'=>'Source', 'enabled'=>1, 'visible'=>-1, 'position'=>95), //'amount_ht' =>array('type'=>'double(24,8)', 'label'=>'AmountHT', 'enabled'=>1, 'visible'=>-1, 'position'=>105), - 'remise_percent' =>array('type'=>'double', 'label'=>'RelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>110), - 'remise_absolue' =>array('type'=>'double', 'label'=>'CustomerRelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>115), + //'remise_percent' =>array('type'=>'double', 'label'=>'RelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>110), + //'remise_absolue' =>array('type'=>'double', 'label'=>'CustomerRelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>115), //'remise' =>array('type'=>'double', 'label'=>'Remise', 'enabled'=>1, 'visible'=>-1, 'position'=>120), 'total_tva' =>array('type'=>'double(24,8)', 'label'=>'VAT', 'enabled'=>1, 'visible'=>-1, 'position'=>125, 'isameasure'=>1), 'localtax1' =>array('type'=>'double(24,8)', 'label'=>'LocalTax1', 'enabled'=>1, 'visible'=>-1, 'position'=>130, 'isameasure'=>1), @@ -976,8 +984,8 @@ class Commande extends CommonOrder $sql .= ", ".($this->fk_delivery_address > 0 ? ((int) $this->fk_delivery_address) : 'NULL'); $sql .= ", ".(!empty($this->shipping_method_id) && $this->shipping_method_id > 0 ? ((int) $this->shipping_method_id) : 'NULL'); $sql .= ", ".(!empty($this->warehouse_id) && $this->warehouse_id > 0 ? ((int) $this->warehouse_id) : 'NULL'); - $sql .= ", ".($this->remise_absolue > 0 ? $this->db->escape($this->remise_absolue) : 'NULL'); - $sql .= ", ".($this->remise_percent > 0 ? $this->db->escape($this->remise_percent) : 0); + $sql .= ", ".($this->remise_absolue > 0 ? $this->db->escape($this->remise_absolue) : 'NULL'); // TODO deprecated + $sql .= ", ".($this->remise_percent > 0 ? $this->db->escape($this->remise_percent) : 0); // TODO deprecated $sql .= ", ".(int) $this->fk_incoterms; $sql .= ", '".$this->db->escape($this->location_incoterms)."'"; $sql .= ", ".setEntity($this); @@ -1927,8 +1935,8 @@ class Commande extends CommonOrder $this->date_validation = $this->db->jdate($obj->date_valid); $this->date_modification = $this->db->jdate($obj->tms); $this->remise = $obj->remise; - $this->remise_percent = $obj->remise_percent; - $this->remise_absolue = $obj->remise_absolue; + $this->remise_percent = $obj->remise_percent; // TODO deprecated + $this->remise_absolue = $obj->remise_absolue; // TODO deprecated $this->source = $obj->source; $this->billed = $obj->billed; $this->note = $obj->note_private; // deprecated @@ -2480,6 +2488,7 @@ class Commande extends CommonOrder * @param float $remise Discount (percent) * @param int $notrigger 1=Does not execute triggers, 0= execute triggers * @return int <0 if KO, >0 if OK + * @deprecated remise_percent is a deprecated field for object parent */ public function setDiscount($user, $remise, $notrigger = 0) { diff --git a/htdocs/compta/facture/class/facture.class.php b/htdocs/compta/facture/class/facture.class.php index c1e5856ab87..154480578ba 100644 --- a/htdocs/compta/facture/class/facture.class.php +++ b/htdocs/compta/facture/class/facture.class.php @@ -168,8 +168,17 @@ class Facture extends CommonInvoice // Warning: Do not set default value into property defintion. it must stay null. // For example to avoid to have substition done when object is generic and not yet defined. + + /** + * @deprecated + */ public $remise_absolue; + + /** + * @deprecated + */ public $remise_percent; + public $total_ht; public $total_tva; public $total_localtax1; @@ -325,8 +334,8 @@ class Facture extends CommonInvoice 'date_closing' =>array('type'=>'datetime', 'label'=>'Date closing', 'enabled'=>1, 'visible'=>-1, 'position'=>30), 'paye' =>array('type'=>'smallint(6)', 'label'=>'InvoicePaidCompletely', 'enabled'=>1, 'visible'=>-1, 'notnull'=>1, 'position'=>80), //'amount' =>array('type'=>'double(24,8)', 'label'=>'Amount', 'enabled'=>1, 'visible'=>-1, 'notnull'=>1, 'position'=>85), - 'remise_percent' =>array('type'=>'double', 'label'=>'RelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>90), - 'remise_absolue' =>array('type'=>'double', 'label'=>'CustomerRelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>91), + //'remise_percent' =>array('type'=>'double', 'label'=>'RelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>90), + //'remise_absolue' =>array('type'=>'double', 'label'=>'CustomerRelativeDiscount', 'enabled'=>1, 'visible'=>-1, 'position'=>91), //'remise' =>array('type'=>'double', 'label'=>'Remise', 'enabled'=>1, 'visible'=>-1, 'position'=>100), 'close_code' =>array('type'=>'varchar(16)', 'label'=>'EarlyClosingReason', 'enabled'=>1, 'visible'=>-1, 'position'=>92), 'close_note' =>array('type'=>'varchar(128)', 'label'=>'EarlyClosingComment', 'enabled'=>1, 'visible'=>-1, 'position'=>93), @@ -564,8 +573,8 @@ class Facture extends CommonInvoice $this->total_ttc = $_facrec->total_ttc; // Fields always coming from template - $this->remise_absolue = $_facrec->remise_absolue; - $this->remise_percent = $_facrec->remise_percent; + $this->remise_absolue = $_facrec->remise_absolue; // TODO deprecated + $this->remise_percent = $_facrec->remise_percent; // TODO deprecated $this->fk_incoterms = $_facrec->fk_incoterms; $this->location_incoterms = $_facrec->location_incoterms; @@ -668,8 +677,8 @@ class Facture extends CommonInvoice $sql .= ", type"; $sql .= ", fk_soc"; $sql .= ", datec"; - $sql .= ", remise_absolue"; - $sql .= ", remise_percent"; + $sql .= ", remise_absolue"; // TODO deprecated + $sql .= ", remise_percent"; // TODO deprecated $sql .= ", datef"; $sql .= ", date_pointoftax"; $sql .= ", note_private"; @@ -694,8 +703,8 @@ class Facture extends CommonInvoice $sql .= ", '".$this->db->escape($this->type)."'"; $sql .= ", ".((int) $socid); $sql .= ", '".$this->db->idate($now)."'"; - $sql .= ", ".($this->remise_absolue > 0 ? $this->remise_absolue : 'NULL'); - $sql .= ", ".($this->remise_percent > 0 ? $this->remise_percent : 'NULL'); + $sql .= ", ".($this->remise_absolue > 0 ? $this->remise_absolue : 'NULL'); // TODO deprecated + $sql .= ", ".($this->remise_percent > 0 ? $this->remise_percent : 'NULL'); // TODO deprecated $sql .= ", '".$this->db->idate($this->date)."'"; $sql .= ", ".(empty($this->date_pointoftax) ? "null" : "'".$this->db->idate($this->date_pointoftax)."'"); $sql .= ", ".($this->note_private ? "'".$this->db->escape($this->note_private)."'" : "null"); @@ -1159,8 +1168,8 @@ class Facture extends CommonInvoice $facture->fk_project = $this->fk_project; $facture->cond_reglement_id = $this->cond_reglement_id; $facture->mode_reglement_id = $this->mode_reglement_id; - $facture->remise_absolue = $this->remise_absolue; - $facture->remise_percent = $this->remise_percent; + $facture->remise_absolue = $this->remise_absolue; // TODO deprecated + $facture->remise_percent = $this->remise_percent; // TODO deprecated $facture->origin = $this->origin; $facture->origin_id = $this->origin_id; @@ -2011,8 +2020,8 @@ class Facture extends CommonInvoice $this->date_validation = $this->db->jdate($obj->datev); $this->date_modification = $this->db->jdate($obj->datem); $this->datem = $this->db->jdate($obj->datem); - $this->remise_percent = $obj->remise_percent; - $this->remise_absolue = $obj->remise_absolue; + $this->remise_percent = $obj->remise_percent; // TODO deprecated + $this->remise_absolue = $obj->remise_absolue; // TODO deprecated $this->total_ht = $obj->total_ht; $this->total_tva = $obj->total_tva; $this->total_localtax1 = $obj->localtax1; @@ -2347,8 +2356,8 @@ class Facture extends CommonInvoice $sql .= " date_pointoftax=".(strval($this->date_pointoftax) != '' ? "'".$this->db->idate($this->date_pointoftax)."'" : 'null').","; $sql .= " date_valid=".(strval($this->date_validation) != '' ? "'".$this->db->idate($this->date_validation)."'" : 'null').","; $sql .= " paye=".(isset($this->paye) ? $this->db->escape($this->paye) : 0).","; - $sql .= " remise_percent=".(isset($this->remise_percent) ? $this->db->escape($this->remise_percent) : "null").","; - $sql .= " remise_absolue=".(isset($this->remise_absolue) ? $this->db->escape($this->remise_absolue) : "null").","; + $sql .= " remise_percent=".(isset($this->remise_percent) ? $this->db->escape($this->remise_percent) : "null").","; // TODO deprecated + $sql .= " remise_absolue=".(isset($this->remise_absolue) ? $this->db->escape($this->remise_absolue) : "null").","; // TODO deprecated $sql .= " close_code=".(isset($this->close_code) ? "'".$this->db->escape($this->close_code)."'" : "null").","; $sql .= " close_note=".(isset($this->close_note) ? "'".$this->db->escape($this->close_note)."'" : "null").","; $sql .= " total_tva=".(isset($this->total_tva) ? $this->total_tva : "null").","; @@ -4252,6 +4261,7 @@ class Facture extends CommonInvoice * @param double $remise Discount * @param int $notrigger 1=Does not execute triggers, 0= execute triggers * @return int <0 if ko, >0 if ok + * @deprecated remise_percent is a deprecated field for object parent */ public function setDiscount($user, $remise, $notrigger = 0) { diff --git a/htdocs/core/modules/asset/doc/pdf_standard_asset.modules.php b/htdocs/core/modules/asset/doc/pdf_standard_asset.modules.php index de378ee79a8..9a488112cc5 100644 --- a/htdocs/core/modules/asset/doc/pdf_standard_asset.modules.php +++ b/htdocs/core/modules/asset/doc/pdf_standard_asset.modules.php @@ -689,7 +689,8 @@ class pdf_standard_asset extends ModelePDFAsset $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if ($object->remise_percent) { + // TODO remise_percent is an obsolete field for object parent + /*if ($object->remise_percent) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if ($object->remise_percent) { @@ -697,7 +698,7 @@ class pdf_standard_asset extends ModelePDFAsset } if ($object->remise_percent) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/commande/doc/pdf_einstein.modules.php b/htdocs/core/modules/commande/doc/pdf_einstein.modules.php index cb73b6fc282..c266642e1f7 100644 --- a/htdocs/core/modules/commande/doc/pdf_einstein.modules.php +++ b/htdocs/core/modules/commande/doc/pdf_einstein.modules.php @@ -542,7 +542,8 @@ class pdf_einstein extends ModelePDFCommandes $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if ($object->remise_percent) { + // TODO remise_percent is an obsolete field for object parent + /*if ($object->remise_percent) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if ($object->remise_percent) { @@ -550,7 +551,7 @@ class pdf_einstein extends ModelePDFCommandes } if ($object->remise_percent) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/commande/doc/pdf_eratosthene.modules.php b/htdocs/core/modules/commande/doc/pdf_eratosthene.modules.php index 8930481d219..c29351a7626 100644 --- a/htdocs/core/modules/commande/doc/pdf_eratosthene.modules.php +++ b/htdocs/core/modules/commande/doc/pdf_eratosthene.modules.php @@ -767,7 +767,8 @@ class pdf_eratosthene extends ModelePDFCommandes $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if ($object->remise_percent) { + // TODO remise_percent is an obsolete field for object parent + /*if ($object->remise_percent) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if ($object->remise_percent) { @@ -775,7 +776,7 @@ class pdf_eratosthene extends ModelePDFCommandes } if ($object->remise_percent) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/facture/doc/pdf_crabe.modules.php b/htdocs/core/modules/facture/doc/pdf_crabe.modules.php index af927f6d188..a39f306bc4b 100644 --- a/htdocs/core/modules/facture/doc/pdf_crabe.modules.php +++ b/htdocs/core/modules/facture/doc/pdf_crabe.modules.php @@ -727,7 +727,8 @@ class pdf_crabe extends ModelePDFFactures $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if ($object->remise_percent) { + // TODO remise_percent is an obsolete field for object parent + /*if ($object->remise_percent) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if ($object->remise_percent) { @@ -735,7 +736,7 @@ class pdf_crabe extends ModelePDFFactures } if ($object->remise_percent) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/facture/doc/pdf_sponge.modules.php b/htdocs/core/modules/facture/doc/pdf_sponge.modules.php index 5733122ec13..b40562e3846 100644 --- a/htdocs/core/modules/facture/doc/pdf_sponge.modules.php +++ b/htdocs/core/modules/facture/doc/pdf_sponge.modules.php @@ -865,7 +865,8 @@ class pdf_sponge extends ModelePDFFactures $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if ($object->remise_percent) { + // TODO remise_percent is an obsolete field for object parent + /*if ($object->remise_percent) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if ($object->remise_percent) { @@ -873,7 +874,7 @@ class pdf_sponge extends ModelePDFFactures } if ($object->remise_percent) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/propale/doc/pdf_azur.modules.php b/htdocs/core/modules/propale/doc/pdf_azur.modules.php index 177443153ce..0af08573555 100644 --- a/htdocs/core/modules/propale/doc/pdf_azur.modules.php +++ b/htdocs/core/modules/propale/doc/pdf_azur.modules.php @@ -653,7 +653,8 @@ class pdf_azur extends ModelePDFPropales $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if ($object->remise_percent) { + // TODO remise_percent is an obsolete field for object parent + /*if ($object->remise_percent) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if ($object->remise_percent) { @@ -661,7 +662,7 @@ class pdf_azur extends ModelePDFPropales } if ($object->remise_percent) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/propale/doc/pdf_cyan.modules.php b/htdocs/core/modules/propale/doc/pdf_cyan.modules.php index 65bb0c45f3a..db3bf0a9c22 100644 --- a/htdocs/core/modules/propale/doc/pdf_cyan.modules.php +++ b/htdocs/core/modules/propale/doc/pdf_cyan.modules.php @@ -777,7 +777,8 @@ class pdf_cyan extends ModelePDFPropales $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if ($object->remise_percent) { + // TODO remise_percent is an obsolete field for object parent + /*if ($object->remise_percent) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if ($object->remise_percent) { @@ -785,7 +786,7 @@ class pdf_cyan extends ModelePDFPropales } if ($object->remise_percent) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/stocktransfer/doc/pdf_eagle_proforma.modules.php b/htdocs/core/modules/stocktransfer/doc/pdf_eagle_proforma.modules.php index 5bff26a9d1d..38b00261525 100644 --- a/htdocs/core/modules/stocktransfer/doc/pdf_eagle_proforma.modules.php +++ b/htdocs/core/modules/stocktransfer/doc/pdf_eagle_proforma.modules.php @@ -692,9 +692,10 @@ class pdf_eagle_proforma extends ModelePDFCommandes $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if ($object->remise_percent) $tvaligne -= ($tvaligne * $object->remise_percent) / 100; + // TODO remise_percent is an obsolete field for object parent + /*if ($object->remise_percent) $tvaligne -= ($tvaligne * $object->remise_percent) / 100; if ($object->remise_percent) $localtax1ligne -= ($localtax1ligne * $object->remise_percent) / 100; - if ($object->remise_percent) $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; + if ($object->remise_percent) $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100;*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/supplier_invoice/doc/pdf_canelle.modules.php b/htdocs/core/modules/supplier_invoice/doc/pdf_canelle.modules.php index 76c0ed56851..056f71e5b80 100644 --- a/htdocs/core/modules/supplier_invoice/doc/pdf_canelle.modules.php +++ b/htdocs/core/modules/supplier_invoice/doc/pdf_canelle.modules.php @@ -508,9 +508,10 @@ class pdf_canelle extends ModelePDFSuppliersInvoices $localtax1ligne = $object->lines[$i]->total_localtax1; $localtax2ligne = $object->lines[$i]->total_localtax2; - if (!empty($object->remise_percent)) { + // TODO remise_percent is an obsolete field for object parent + /*if (!empty($object->remise_percent)) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; $localtax1rate = (string) $object->lines[$i]->localtax1_tx; diff --git a/htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php b/htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php index 233d18ce229..a2b08668ee2 100644 --- a/htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php +++ b/htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php @@ -706,7 +706,8 @@ class pdf_cornas extends ModelePDFSuppliersOrders $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if (!empty($object->remise_percent)) { + // TODO remise_percent is an obsolete field for object parent + /*if (!empty($object->remise_percent)) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if (!empty($object->remise_percent)) { @@ -714,7 +715,7 @@ class pdf_cornas extends ModelePDFSuppliersOrders } if (!empty($object->remise_percent)) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/supplier_order/doc/pdf_muscadet.modules.php b/htdocs/core/modules/supplier_order/doc/pdf_muscadet.modules.php index 274c348eeea..1de275141c5 100644 --- a/htdocs/core/modules/supplier_order/doc/pdf_muscadet.modules.php +++ b/htdocs/core/modules/supplier_order/doc/pdf_muscadet.modules.php @@ -586,7 +586,8 @@ class pdf_muscadet extends ModelePDFSuppliersOrders $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if (!empty($object->remise_percent)) { + // TODO remise_percent is an obsolete field for object parent + /*if (!empty($object->remise_percent)) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if (!empty($object->remise_percent)) { @@ -594,7 +595,7 @@ class pdf_muscadet extends ModelePDFSuppliersOrders } if (!empty($object->remise_percent)) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx; diff --git a/htdocs/core/modules/supplier_proposal/doc/pdf_aurore.modules.php b/htdocs/core/modules/supplier_proposal/doc/pdf_aurore.modules.php index 70467c49f58..75999b554dc 100644 --- a/htdocs/core/modules/supplier_proposal/doc/pdf_aurore.modules.php +++ b/htdocs/core/modules/supplier_proposal/doc/pdf_aurore.modules.php @@ -586,7 +586,8 @@ class pdf_aurore extends ModelePDFSupplierProposal $localtax1_type = $object->lines[$i]->localtax1_type; $localtax2_type = $object->lines[$i]->localtax2_type; - if ($object->remise_percent) { + // TODO remise_percent is an obsolete field for object parent + /*if ($object->remise_percent) { $tvaligne -= ($tvaligne * $object->remise_percent) / 100; } if ($object->remise_percent) { @@ -594,7 +595,7 @@ class pdf_aurore extends ModelePDFSupplierProposal } if ($object->remise_percent) { $localtax2ligne -= ($localtax2ligne * $object->remise_percent) / 100; - } + }*/ $vatrate = (string) $object->lines[$i]->tva_tx;