Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2026-01-07 17:42:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Qual: Fix PhanPluginUnknownObjectMethodCall in classes with high occurence (#30754)

Browse Source 
* Qual: Fix PhanPluginUnknownObjectMethodCall in import.php

* Qual: PHPDoc for import/export array types

* Qual: Add PHPDoc types to import.class.php

* Fix PhanPluginUnknownObjectMethodCall in stats.class.php

* Add methods expected on ModeleImport child classes

* Force imapemail type for phan

* Qual: Update phan baseline

* Qual: Fix Undefined/Undeclared phan notices in module_help

* Update baseline
This commit is contained in:
MDW
2024-08-27 04:51:41 +02:00
committed by GitHub
parent 03ffbd3099
commit f5c7ca1769
9 changed files with 355 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
htdocs/admin/modulehelp.php
View File

@@ -85,6 +85,7 @@ $modulesdir = dolGetModulesDirs();
$filename = array();
'@phan-var-force DolibarrModules[] $modules';
$modules = array();
$orders = array();
$categ = array();
@@ -225,10 +226,13 @@ asort($orders);
//var_dump($modules);
unset($objMod);
$objMod = null;
$dirofmodule = null;
$key = -1;
$i = 0;
foreach ($orders as $tmpkey => $tmpvalue) {
$tmpMod = $modules[$tmpkey];
'@phan-var-force DolibarrModules $tmpMod';
if ($tmpMod->numero == $id) {
$key = $i;
$modName = $filename[$tmpkey];
@@ -238,6 +242,12 @@ foreach ($orders as $tmpkey => $tmpvalue) {
}
$i++;
}
if (!is_object($objMod)) {
$msg = __FILE__." Module with no found for id:".$id;
dol_syslog($msg, LOG_ERR);
return;
}
$value = $orders[$key];
$tab = explode('_', $value);
$familyposition = $tab[0];
@@ -346,11 +356,11 @@ if ($mode == 'desc') {
$textexternal = '';
if ($objMod->isCoreOrExternalModule() == 'external') {
$tmpdirofmoduletoshow = preg_replace('/^'.preg_quote(DOL_DOCUMENT_ROOT, '/').'/', '', $dirofmodule);
$tmpdirofmoduletoshow = preg_replace('/^'.preg_quote(DOL_DOCUMENT_ROOT, '/').'/', '', (string) $dirofmodule);
$textexternal .= '<br><span class="opacitymedium">'.$langs->trans("Origin").':</span> '.$langs->trans("ExternalModule").' - '.$langs->trans("InstalledInto", $tmpdirofmoduletoshow);
global $dolibarr_allow_download_external_modules;
if (!empty($dolibarr_allow_download_external_modules) && preg_match('/\/custom\//', $dirofmodule)) {
if (!empty($dolibarr_allow_download_external_modules) && preg_match('/\/custom\//', (string) $dirofmodule)) {
// Add a link to download a zip of the module
$textexternal .= ' <a href="'.DOL_URL_ROOT.'/admin/tools/export_files.php?export_type=externalmodule&what='.urlencode($moduledir).'&compression=zip&zipfilename_template=module_'.$moduledir.'-'.$version.'.notorig" target="_blank" rel="noopener">'.img_picto('', 'download').'</a>';
}