3193 Commits

Author SHA1 Message Date
Laurent Destailleur
c635f5f9c5 Fix detection of security commit 2025-12-04 12:51:49 +01:00
Laurent Destailleur
7847408006 WIP LNE 2025-12-03 15:40:42 +01:00
Laurent Destailleur
b83a13656f Add new phpunit tests 2025-11-30 18:37:58 +01:00
Dolibot
b31f16c18f PHPStan > Update baseline 2025-11-29 12:09:23 +00:00
Laurent Destailleur
c62ba31c50 Merge pull request #36433 from mdeweerd/fix/public_const
Qual: Update PHP-CS-Fixer configuration and DolibarrModules class
2025-11-28 23:34:42 +01:00
MDW
b33386ba0d qual: Update phpstan-baseline.neon to remove unresolvable type issues
Removed multiple entries related to unresolvable types in dol_sort_array function calls and property assignments.
2025-11-27 22:38:56 +01:00
MDW
0333daa8a8 Qual: Update PHP-CS-Fixer configuration and DolibarrModules class
- Update PHP-CS-Fixer configuration to replace deprecated 'visibility_required' rule with 'modifier_keywords'
- Update DolibarrModules class to use const instead of public const for PHP 7.0 compatibility (revert recent change)
2025-11-27 01:08:46 +01:00
Laurent Destailleur
c295be762e Fix CI 2025-11-26 21:49:07 +01:00
Laurent Destailleur
5f437d983a Debug v23 2025-11-26 19:24:25 +01:00
Laurent Destailleur
6894ba851b Removed deprecated comment 2025-11-24 15:52:02 +01:00
MDW
63a78d8c00 Qual: Add perltidy & perlcritic + updates to fix notices. (#36370)
* Qual: Add pre-commit hooks for Perl code formatting and linting

- Added perltidy hook to format Perl code
- Added perlcritic hook to lint Perl code

* Qual: Update file opening syntax in build scripts (perltidy)

The changes update the syntax for opening files in several build scripts to use the three-argument form of the `open` function, which is more secure and recommended in modern Perl practices.

* Qual: Improve file handling and add strict/warnings pragmas (perlcritic)

The changes include:
- Adding 'use strict' and 'use warnings' pragmas to enforce better coding practices
- Improving file handling by using lexical filehandles (my $IN, my $SPECFROM, etc.)
- Fixing file opening and closing operations to use proper error handling
- Updating various file operations to use the new lexical filehandles
- Fixing indentation and formatting issues in the code

* Qual: Add strict and warnings pragmas to Perl scripts (perlcritic)

The changes add 'use strict;' and 'use warnings;' pragmas
- dev/build/doxygen/dolibarr-doxygen-build.pl
- dev/build/doxygen/dolibarr-doxygen-filter.pl
- dev/build/doxygen/dolibarr-doxygen-getversion.pl
- dev/build/gource/getavatars.pl
- dev/tools/dolibarr-mysql2pgsql.pl

* Qual: Add Perl no critic pragmas (perlcritic)

- Ignore some perlcritic notices

* Qual: Improve code formatting and readability

Perltidy:

- Indentation and spacing
- Improved variable naming and alignment
- Better code organization and structure
- Enhanced readability of conditional statements and loops

These changes do not alter the functionality of the script but make it more maintainable and easier to understand.

* qual: Exclude virtualmin from perltidy and perlcritic hooks

Exclude the virtualmin directory from both perltidy and perlcritic hooks due to specific reasons mentioned in the comment. This change ensures that these hooks do not process files in the virtualmin directory.

* Qual: Add installation of perltidy and perlcritic for pre-commit workflow

This commit adds the installation of perltidy and perlcritic as part of the pre-commit hooks workflow.

* Fix: Update version detection in dolibarr-doxygen-build.pl

- Add support for detecting version from DOL_MAJOR_VERSION and DOL_MINOR_VERSION constants
- Fix undefined variable issue in version detection

* Fix: Update getavatars.pl to use HTTPS and reverse git log

- Changed the URL from HTTP to HTTPS for Gravatar
- Added `--reverse` flag to git log command to process commits in chronological order (faster)
- Updated error message to indicate .git repository instead of .git directory (+ correct test)

* fix: Correct spelling in error messages and prompts

- Fixed typo in error message for missing environment variables
- Corrected spelling in prompt for module name input
- Improved clarity in comment for target checking
2025-11-23 01:52:07 +01:00
MDW
b57495f745 Qual: Update phan baseline (#36362)
* Qual: Update Phan baseline

# Qual: Update Phan baseline

- Updated Phan baseline to reflect reduced occurrences of PhanTypeMismatchProperty and PhanUndeclaredMethod
- Fixed syntax error in card.php by adding missing closing parenthesis

* Qual: Fix PhanPluginRedundantReturnComment

# Qual: Fix PhanPluginRedundantReturnComment

- Add return type description for the getmsg method.
2025-11-22 19:49:22 +01:00
Regis Houssin
9ac7851073 QUAL update dolibarr script for Virtualmin (#36371) 2025-11-22 19:48:37 +01:00
github-actions[bot]
853c7a2c8d PHPStan > Update baseline (#36374)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-11-22 19:47:22 +01:00
Laurent Destailleur
bb26ca6ee7 Fix makepack 2025-11-21 15:19:49 +01:00
Laurent Destailleur
2e52ef2552 Doc 2025-11-20 14:00:18 +01:00
Laurent Destailleur
ce6dc7edce Doc 2025-11-20 13:59:36 +01:00
Laurent Destailleur
288283bf36 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2025-11-20 13:59:03 +01:00
Laurent Destailleur
d9e1973edb Update blockedlog 2025-11-20 13:55:48 +01:00
Regis Houssin
f1bad6fa69 QUAL update mysql workbench (#35955)
* QUAL update mysql workbench

* NEW add link to mac api rest client for test

* FIX add apple

* FIX Mister D

* FIX Brian is in the kitchen

* FIX modeste

* Revert "FIX modeste"

This reverts commit a268f6265f.

* FIX youhou
2025-11-20 12:01:41 +01:00
Frédéric FRANCE
46d6714fe0 clean code (#36317)
* clean code

* clean code

* clean doc

* clean doc

* clean doc

* clean doc

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-20 01:47:46 +01:00
Frédéric FRANCE
d5e641e248 fix doc subtotal tpl (#36326)
* fix subtotal create tpl

* fix subtotal create tpl

* property errors is always set

* clean baseline
2025-11-19 19:21:19 +01:00
Laurent Destailleur
918443562e Fix warning 2025-11-19 16:25:16 +01:00
Laurent Destailleur
c1699eed56 Debug v23 2025-11-19 16:18:09 +01:00
Laurent Destailleur
7645a6dc87 Debug v23 2025-11-19 16:16:53 +01:00
github-actions[bot]
3cd79f4497 PHPStan > Update baseline (#36305)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-11-19 14:16:21 +01:00
MDW
96e35c7a33 Fix: PhanTypeMismatchProperty error in invoice creation (#36323)
* 🐛 Fix PhanTypeMismatchProperty error in invoice creation

The error occurred due to incorrect type handling in the invoice creation process. The changes fix this by properly handling the subtype field as an integer. This ensures type consistency and prevents potential runtime errors.

* FIX: Correct assignment to linkedObjectsIds  in card.php

# FIX: Correct assignment to linkedObjectsIds  in card.php

Modified the structure of linkedObjectsIds to include the rowid as a key to match the property type.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-19 14:16:00 +01:00
MDW
45184e9741 Qual: Update phan baseline (#36318)
# Qual: Update phan baseline

Remove fixed notices from exceptions.
2025-11-19 10:58:00 +01:00
Frédéric FRANCE
8d459e469d clean code (#36260)
* clean code

* clean code

* clean code

* clean code

* fix $val might not be defined

* fix phpstan errors reported

* fix phpstan errors reported

* fix phpstan errors reported

* fix phpstan errors reported

* fix phpstan errors reported

* fix phpstan errors reported

* ignore phpstan reported for later

* clean code

* clean code

* clean code

* clean

* test
2025-11-18 11:41:28 +01:00
MDW
991706e731 FIX: Fix version extraction in setup_conf.sh (#36281)
# FIX: Fix version extraction in setup_conf.sh

The version extraction regex was updated to handle both DOL_VERSION and DOL_MAJOR_VERSION constants in version.inc.php.
The version is now available as DOL_MAJOR_VERSION since 29b1e75

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-17 22:05:33 +01:00
MDW
1072419141 Qual: Update pre-commit hooks (#36262)
* Qual: Update pre-commit hooks

# Qual: Update pre-commit hook

Updated several pre-commit hooks as long as the new ones are not alpha or beta versions

* Qual: Fix/ignore some shellcheck issues
2025-11-17 21:50:29 +01:00
github-actions[bot]
f799113fac PHPStan > Update baseline (#36264)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-17 21:47:22 +01:00
Laurent Destailleur
4703344acc Debug 2025-11-17 16:50:53 +01:00
Laurent Destailleur
7b6186c137 Doc 2025-11-17 16:45:04 +01:00
Laurent Destailleur
e8e61605da Doc 2025-11-17 16:41:58 +01:00
Laurent Destailleur
68e6bedd27 The script generate_filelist_xml.php can check integrity from command
line.
2025-11-17 16:39:27 +01:00
Laurent Destailleur
72afda872d WIP LNE 2025-11-17 13:53:53 +01:00
github-actions[bot]
1578715f54 PHPStan > Update baseline (#36242)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-11-13 16:57:26 +01:00
Laurent Destailleur
65024ebf63 Fix bad translation string 2025-11-12 17:34:53 +01:00
Frédéric FRANCE
d07e8c03a0 avoid changing object after call (#36159)
* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* clean code

* clean code

* clean code

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* clean code

* clean

* clean

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-12 09:44:39 +01:00
PierrickV
6e3fabeeab Fix typo in DLLMissing message for MyGerman.isl (#36223)
* Fix typo in DLLMissing message for MyGerman.isl

Typos:
- s/Mcrsoft/Microsoft/g
- s/credist_x86.exe/vc_redist.x86.exe/g
- dl link

* Fix DLLMissing message link for Visual C++ Redistributable

Updated the link for the Microsoft Visual C++ Redistributable installation instructions.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-12 09:38:55 +01:00
github-actions[bot]
1ee0c4f4ba PHPStan > Update baseline (#36208)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-11-11 08:52:46 +01:00
Frédéric FRANCE
4334797588 clean code (#36179)
* clean code

* clean code

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-09 17:59:36 +01:00
MDW
0831c65913 Qual: Update Phan baseline.txt (#36190)
#Qual: Update Phan baseline.txt

Update the Phan baseline.txt file to reflect changes in the number of occurrences of specific issues.
2025-11-09 17:58:08 +01:00
Frédéric FRANCE
114131d59d clean code (#36180)
* clean code

* clean code

* clean code
2025-11-09 01:34:33 +01:00
Frédéric FRANCE
eaf2b694c0 ticket progress nullable (#36178)
* ticket progress nullable

* ticket progress nullable
2025-11-09 01:32:47 +01:00
Frédéric FRANCE
ca0052e82d clean code (#36176)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
2025-11-08 19:29:54 +01:00
Frédéric FRANCE
e343b4ab1f clean code (#36166)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
2025-11-08 14:01:19 +01:00
Frédéric FRANCE
223ce3fb84 clean code (#36157)
* clean code

* clean code
2025-11-08 11:31:09 +01:00
Frédéric FRANCE
cad3574179 common delete also files (#36146)
* common delete also files

* common delete also files

* common delete also files

* common delete also files

* common delete also files

* common delete also files
2025-11-07 18:44:14 +01:00