R0ck3n
6334fa5bea
NEW: Add prepare() method to DoliDB class (rebuild) ( #35249 )
...
* feat:prepared sql for mysqli and postgres
* refactor:remove whitespace
* Update DoliDB.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-09-08 02:37:42 +02:00
ldestailleur
4e89f046d1
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into 22.0
2025-09-01 16:47:39 +02:00
ldestailleur
bb0974add9
FIX Security when using feature Advanced Target of emailing (hidden in
...
v21, default in v22+). Possible SQL injection by users with permissions
to make mass emailing. Reported by Simon Perdrisat.
2025-09-01 16:38:01 +02:00
Marc de Lima Lucio
d5250eadeb
FIX: pgsql: cast string_agg arguments ( #34210 )
...
* FIX local taxes text in object line view mode (#34103 )
* FIX: product suplier tab: last modif date column was wrongly dependant of module barcode (#34170 )
* FIX: product suplier tab: last modif date column was wrongly dependant of module barcode
* FIX: product suplier tab: last modif date column was wrongly dependant of module barcode, part 2
* FIX: pgsql: cast string_agg arguments
* FIX: pgsql group concat conversion: modify tests as a consequence
---------
Co-authored-by: lvessiller-opendsi <lvessiller@open-dsi.fr >
2025-06-04 18:24:19 +02:00
ldestailleur
7b9b32cb9e
Debug pgsql DDLInfoTable
2025-03-25 21:32:28 +01:00
Faisal Azhar
b500efd6ff
Update pgsql.class.php - function num_rows ( #33358 )
...
to avoid error when $resultset = null or false
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-03-06 18:14:50 +01:00
MDW
32bf8c5cd5
Qual: Fix phan notices (website)
2025-02-27 11:40:42 +01:00
MDW
97099b854f
Qual: Fix phan notices (install)
2025-02-05 01:43:41 +01:00
MDW
f750f2c40c
Qual: Fix phan notices not seen locally
2025-02-03 16:06:01 +01:00
Laurent Destailleur (aka Eldy)
f0ae6b999f
Debug v21
2025-01-03 15:55:05 +01:00
MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
...
# Qual: Update fields phpdoc to include fields that are defined/used in some cases
comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
MDW
b91c99b18a
Qual: Fix phan/phpstan notices in class files (part 3) ( #31578 )
...
* fix phpstan in conf class (#31630 )
* fix phpstan
* fix phan
* Fix merge
* Qual: Avoid notification with typing hint
* Qual: Fix notices link.class
* Qual: Fix notices link..socialneetworkmanager.class and DoliDb->DoliDB
* Qual: Fix notices for link..utils.class
* Qual: Fix notices for db classes
* Update translate.class.php
* Update translate.class.php
---------
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com >
Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-10-29 22:44:47 +01:00
Laurent Destailleur
e6f1d4835f
Clean sql code
2024-10-29 02:58:20 +01:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-29 21:52:31 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-15 17:05:00 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Laurent Destailleur
629ccf9681
Merge branch 'FIX_Entity_on_workstation' of
...
github.com:ATM-Consulting/dolibarr into
ATM-Consulting-FIX_Entity_on_workstation
2024-05-23 13:02:07 +02:00
Laurent Destailleur
271624de1b
Debug v20
2024-05-15 18:04:52 +02:00
Laurent Destailleur
6358f89c0d
Fix phan warnings
2024-04-28 17:10:51 +02:00
Laurent Destailleur
55c8048639
Try to fix phan warnings
2024-04-28 13:02:49 +02:00
Frédéric FRANCE
82d63247d7
fix phpstan pgsql.class.php ( #29511 )
...
* fix phpstan pgsql.class.php
* Update Database.interface.php
* fix phan
fix phan
fix phan
* fix phan
* fix phan
* fix phan
* fix phan
fix phan
fix phan
fix phan
fix phan
* fix phan
* fix phan
* fix phan
* fix phan
2024-04-27 22:01:34 +02:00
Laurent Destailleur
2691603345
Doxygen
2024-04-27 18:04:27 +02:00
Laurent Destailleur
51322707e9
Try to fix phpunit with pgsql
2024-03-22 02:44:55 +01:00
Laurent Destailleur
7290ffd1ab
Better support for postgesql
2024-03-21 15:57:45 +01:00
Laurent Destailleur
a6d5b32c2e
Merge branch 'develop' into qual/db/typing
2024-03-21 14:13:58 +01:00
Laurent Destailleur
2d0e57ce7c
Fix test for pgsql
2024-03-21 14:13:17 +01:00
Laurent Destailleur
0d6675114e
Merge branch 'develop' into qual/db/typing
2024-03-21 13:19:51 +01:00
Laurent Destailleur
380c1092eb
Fix warnings
2024-03-21 13:19:31 +01:00
Laurent Destailleur
e97f0a7668
Merge branch 'develop' into qual/db/typing
2024-03-21 13:06:35 +01:00
Laurent Destailleur
aee4ccc32c
Fix warnings
2024-03-21 13:06:20 +01:00
Laurent Destailleur
9d5aa4a448
Fix sanitization
2024-03-21 13:02:41 +01:00
Laurent Destailleur
04d8a20b63
Merge branch 'develop' into qual/db/typing
2024-03-21 12:46:25 +01:00
Laurent Destailleur
aa77573cd9
Sanitize DDL instructions
2024-03-21 12:45:58 +01:00
Laurent Destailleur
ce2959b022
Clean method DDLCreateTable (used by modulebuilder only) #28996
2024-03-21 12:10:09 +01:00
Laurent Destailleur
ae10eedf2a
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-03-21 11:29:16 +01:00
Laurent Destailleur
57eb393dad
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-03-21 11:22:28 +01:00
Laurent Destailleur
01a058b208
Fix regression
2024-03-21 11:22:12 +01:00
Andrés Maldonado
976686262d
FIX: SQL syntax error in DDLUpdateField
2024-03-21 02:36:40 +01:00
MDW
fc6af20479
Update typing for database functions
2024-03-21 00:00:00 +01:00
MDW
23516ed5fa
Fix arg type for str_replace() with cast
2024-03-19 20:38:54 +01:00
Frédéric FRANCE
1783d68fd4
Update pgsql.class.php
2024-03-18 14:10:55 +01:00
MDW
0b19aa415c
Fix: Initialise array before assigning values ( #28728 )
...
* Qual: Enable PhanUndeclaredVariableDim
# Qual: Enable PhanUndeclaredVariableDim
The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Qual: Add type hint to array to avoid phan notification
* Qual: Add type hint to array to avoid phan notification
* Qual: Enable PhanParamSpecial1 (all resolved)
* Qual: Ignore false PhanTypeArraySuspiciousNullable
* Qual: Improve typing to fix PhanTypeArraySuspicious
* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array
* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Enable phan messages that no longer appear
* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
lamrani abdelwadoud
b41020a801
Fix method by changing return type ( #28507 )
...
* FIX return method getListOfCharacterSet by adding null type
* Fix return method getListOfCollation by adding return null
2024-02-28 20:05:33 +01:00
Frédéric FRANCE
3a1e6d2a58
fix phpstan pgsql.class.php ( #28152 )
2024-02-13 09:03:30 +01:00
MDW
89004f7e03
Qual: Spelling htdocs/core ( #27491 )
...
Highlights:
- initialY in pdf_standard.modules.php was unused
- remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
Laurent Destailleur
aba9afe9f1
NEW Add method getPublicImageOfObject() for website module
2024-01-12 13:05:28 +01:00
Laurent Destailleur
8874ef8454
Debug v19
2023-12-23 18:47:38 +01:00
Laurent Destailleur
44f24746ed
Fix warnings
2023-12-15 13:49:09 +01:00