Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2026-02-07 16:41:48 +01:00
Code Issues Packages Projects Releases Wiki Activity
151,687 Commits 39 Branches 191 Tags
develop
Commit Graph

183 Commits

Author SHA1 Message Date
Anthony Berton
7b33e1c752 UIUX - Look and feel for knowledge (#37096) 
* FIX

* FIX

* NEW - Look and feel for knowledge

---------

Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
 2026-02-05 01:08:00 +01:00
Frédéric FRANCE
46d6714fe0 clean code (#36317) 
* clean code

* clean code

* clean doc

* clean doc

* clean doc

* clean doc

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2025-11-20 01:47:46 +01:00
MDW
c39e87d703 Qual: Make $fields covariant, define type for $FIELDS in BankAccounts api (#36188) 
* Qual: Make $fields covariant

* Qual: Update BankAccounts class phpDoc ($FIELDS)

# Qual: Update BankAccounts class phpDoc ($FIELDS)

Updated the documentation for the $FIELDS property.
 2025-11-09 18:06:58 +01:00
MDW
b925dd6c37 Qual: Make $fields type covariant (phpstan) (#36084) 
# Qual: Make $fields type covariant (phpstan)

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2025-11-04 14:16:17 +01:00
Laurent Destailleur
131d1390bc Debug v23 2025-09-28 22:20:44 +02:00
ldestailleur
702d91c65d Clean code 2025-09-11 12:25:22 +02:00
Frédéric FRANCE
e81d5378cd clean code contract class (#35245) 
* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code contract class

* clean code

* clean code

* clean code

* clean code

* clean code

* fix typo

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
 2025-09-10 11:13:18 +02:00
Frédéric FRANCE
0e1478206a clean code (#35229) 
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2025-09-08 01:48:52 +02:00
Frédéric FRANCE
73073a5bf0 Knowledge tms (#35243) 
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
 2025-09-08 01:00:43 +02:00
Frédéric FRANCE
a1d7b11324 fix doc (#35196) 2025-09-03 12:54:17 +02:00
Jyhere
787bd1d278 CHANGE: ternary simplification (#34675) 2025-07-01 20:34:09 +02:00
Charlène Benke
87eeaa5dcb Add validate and cancel api_knowledgemanagement (#33962) 
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2025-04-24 15:46:01 +02:00
Charlène Benke
6cbab9f12b NEW Add knowledgebase info on box_dolibarr_state_board.php (#33960) 
* Add knowledgebase on box_dolibarr_state_board.php

* Update knowledgerecord.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2025-04-24 02:32:28 +02:00
ldestailleur
8a89cc3f04 FIX phpunit 2025-03-24 20:52:13 +01:00
MDW
f625f8de60 Qual: Fix api phan notices 2025-03-05 13:22:08 +01:00
MDW
eac44b164a Qual: Fix phpdoc index(), FIELDS 2025-03-05 13:21:05 +01:00
MDW
035ede5874 Qual: Fix phan notices in API classes 2025-03-02 20:49:46 +01:00
MDW
c02293a880 Qual: Add phpdoc for request_data param 2025-03-02 20:49:45 +01:00
MDW
941fa4964b Qual: Fix phan notices (knowledgemanagement) 2025-02-05 01:43:44 +01:00
MDW
24fa28dfe2 Qual: Fix getKanban phpdoc 
# Qual: Fix getKanban phpdoc

Array phpdoc for getKanban corrections.
 2025-02-05 01:43:37 +01:00
Laurent Destailleur (aka Eldy)
732f97d73c Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into 
develop
 2025-02-05 00:40:06 +01:00
Laurent Destailleur (aka Eldy)
fa9fe2efa7 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0 2025-01-20 15:02:37 +01:00
Laurent Destailleur (aka Eldy)
c9ab22782e Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2025-01-20 14:57:45 +01:00
Laurent Destailleur (aka Eldy)
1f360ca498 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2025-01-20 12:28:49 +01:00
Laurent Destailleur (aka Eldy)
1b42078d1e Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2025-01-20 10:24:30 +01:00
atm-florian
ba4e97f07b FIX 17.0 API endpoints "PUT": prevent overwriting all extrafields if only some are supplied in the request cf. PR #29237 
+ security for Tickets API: disable updating rowid
 2025-01-16 10:37:29 +01:00
Laurent Destailleur (aka Eldy)
b024b95948 Fix typo 2025-01-09 19:35:01 +01:00
Laurent Destailleur (aka Eldy)
56710ce9b7 FIX CVE-2024-55227 and CVE-2024-55228 CSRF when 
MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is
on (hidden option not on by default)
 2025-01-09 19:35:01 +01:00
MDW
ec2a1928ba Qual: Update fields phpdoc to include fields that are defined/used in some cases 
# Qual: Update fields phpdoc to include fields that are defined/used in some cases

comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
 2024-12-05 02:36:50 +01:00
MDW
d7b2f95baf Qual: Fix phan notices (#31372) 
* fix llx_webhook_target-webhook.sql

* Fix commande/list & facture-rec.class

* Fix bonprelevement

* Qual: Fix prelevement/create notices

* Qual: fix quadridetail notices & update baseline

* Qual: Fix CommonDocGenerator notices

* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
 2024-10-13 16:45:42 +02:00
MDW
1834c37c16 Qual: Fix phan notices (#31212) 
* Qual: Fix phan notices

# Qual: Fix phan notices

Fix several phan notices related to classes with UnknownObject
classes.

* Qual: Fix phan notices

* Qual: Fix phan notices

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-10-03 19:40:34 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176) 
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-09-29 21:52:31 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081) 
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
 2024-09-23 03:24:19 +02:00
thibdrev
3dbd79dad8 qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. (#30712) 
* Update adherent.class.php

* Update adherent_type.class.php

* Update availabilities.class.php

* Update propal.class.php

* Update account.class.php

* Update paymentvarious.class.php

* Update cashcontrol.class.php

* Update localtax.class.php

* Update remisecheque.class.php

* Update bonprelevement.class.php

* Update chargesociales.class.php

* Update contact.class.php

* Update contrat.class.php

* Update commonorder.class.php

* Update timespent.class.php

* Update don.class.php

* Update conferenceorbooth.class.php

* Update expedition.class.php

* Update expensereport.class.php

* Update paymentexpensereport.class.php

* Update fichinter.class.php

* Update fournisseur.commande.class.php

* Update holiday.class.php

* Update evaluation.class.php

* Update job.class.php

* Update position.class.php

* Update skill.class.php

* Update intracommreport.class.php

* Update knowledgerecord.class.php

* Update loan.class.php

* Update mo.class.php

* Update partnership.class.php

* Update inventory.class.php

* Update entrepot.class.php

* Update project.class.php

* Update holiday.class.php - fix phan error

* Update task.class.php

* Update reception.class.php

* Update recruitmentcandidature.class.php

* Update recruitmentjobposition.class.php

* Update paymentsalary.class.php

* Update salary.class.php

* Update supplier_proposal.class.php

* Update ticket.class.php

* Update user.class.php

* Update usergroup.class.php

* Update webportalinvoice.class.php

* Update webportalorder.class.php

* Update webportalpropal.class.php

* Update workstation.class.php

* Update facture.class.php
 2024-08-22 03:31:04 +02:00
MDW
ca414de526 Qual: Fix $fields related notices with Phan (#30704) 
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
 2024-08-21 13:23:35 +02:00
ptibogxiv
4e2842ca27 Update api_knowledgemanagement.class.php with pagination (#30664) 2024-08-18 16:20:45 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542) 
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-15 17:05:00 +02:00
MDW
45ed4caeb2 Qual: Enable Phan Simplify rule and fix notices (#30537) 
* Qual: Phan - Enable Simplyfy expression

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Update functions2.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-07 03:05:02 +02:00
MDW
d6948077b2 Qual: Fix spelling/update .pre-commit configuration (versions) (#30546) 
* Qual: Update pre-commit configuration

* Qual: Update spelling

* Ignore use of deprecated constant
 2024-08-07 01:20:43 +02:00
Frédéric FRANCE
4b275dc148 add phpdoc (#30208) 
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* clean phpdoc
 2024-06-30 19:39:01 +02:00
Laurent Destailleur
611be57fce Debug v20 2024-05-09 19:07:46 +02:00
Laurent Destailleur
458ffdb23e css 2024-05-09 18:15:57 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602) 
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-05-05 00:34:19 +02:00
Laurent Destailleur
b5de782c6b Fix use the good HTTP code 2024-04-07 14:59:25 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
990216b13f NEW Api parameters are sanitized by the WAF, same code than GET/POST 2024-04-02 13:07:13 +02:00
Laurent Destailleur
7b0177a84d Move to getDolGlobalString 2024-03-22 00:37:56 +01:00
MDW
fe5e5b4bc4 Fix $mybool |=... which is binary op, not boolean op 
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
 2024-03-21 13:45:36 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00