* Issue 36923 Fix session title handling in survey creation
* Change input field to use id attribute for title
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
The session variable initialization logic was inverted: it set variables
to null only when they already existed, instead of initializing them
when they were missing. This caused 'undefined array key' warnings on
PHP 8.1+ when accessing the poll creation form for the first time.
Changes:
- Inverted isset() condition to !isset() to properly initialize missing
session variables
- Initialize to empty string instead of null
- Added missing session variables (allow_comments, allow_spy, champdatefin)
to the initialization array
- Added dol_escape_htmltag() for title output (XSS hardening)
Co-authored-by: f-hoedl <hoefla14@htl-kaindorf.ac.at>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
# Qual: fix phpstan by removing useless test
!$error && $champdatefin && ($champdatefin > 0) has useless tests.
- $error is still 0.
- $champdatefin is also not 0 when it is >0
- By casting $champdatefin to int, we ensure that '' (error) is
converted to 0.
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)
* New: Fixer for selectDate '' arguments h, m and empty
* Qual: Update codespell exceptions
* Qual: Spelling fixes that newly appeared.
# Qual: Fix spelling erros that appeared since the bulk updates.
These issues mostly appeared since the bulk updates (a few ones were postponed
to make sure no real spelling errors were missed.)
* Update modulebuilder.lib.php
* Update pdf_standard.modules.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
