# Qual: Update Phan baseline and fix type mismatch in conferenceorbooth_list.php
- Updated the Phan baseline to reflect the reduced number of PhanUndeclaredMethod occurrences
- Fixed a type mismatch in conferenceorbooth_list.php by changing the values from integers to strings in the editfieldkey and editfieldval functions
- Update PHP-CS-Fixer configuration to replace deprecated 'visibility_required' rule with 'modifier_keywords'
- Update DolibarrModules class to use const instead of public const for PHP 7.0 compatibility (revert recent change)
* Qual: Add pre-commit hooks for Perl code formatting and linting
- Added perltidy hook to format Perl code
- Added perlcritic hook to lint Perl code
* Qual: Update file opening syntax in build scripts (perltidy)
The changes update the syntax for opening files in several build scripts to use the three-argument form of the `open` function, which is more secure and recommended in modern Perl practices.
* Qual: Improve file handling and add strict/warnings pragmas (perlcritic)
The changes include:
- Adding 'use strict' and 'use warnings' pragmas to enforce better coding practices
- Improving file handling by using lexical filehandles (my $IN, my $SPECFROM, etc.)
- Fixing file opening and closing operations to use proper error handling
- Updating various file operations to use the new lexical filehandles
- Fixing indentation and formatting issues in the code
* Qual: Add strict and warnings pragmas to Perl scripts (perlcritic)
The changes add 'use strict;' and 'use warnings;' pragmas
- dev/build/doxygen/dolibarr-doxygen-build.pl
- dev/build/doxygen/dolibarr-doxygen-filter.pl
- dev/build/doxygen/dolibarr-doxygen-getversion.pl
- dev/build/gource/getavatars.pl
- dev/tools/dolibarr-mysql2pgsql.pl
* Qual: Add Perl no critic pragmas (perlcritic)
- Ignore some perlcritic notices
* Qual: Improve code formatting and readability
Perltidy:
- Indentation and spacing
- Improved variable naming and alignment
- Better code organization and structure
- Enhanced readability of conditional statements and loops
These changes do not alter the functionality of the script but make it more maintainable and easier to understand.
* qual: Exclude virtualmin from perltidy and perlcritic hooks
Exclude the virtualmin directory from both perltidy and perlcritic hooks due to specific reasons mentioned in the comment. This change ensures that these hooks do not process files in the virtualmin directory.
* Qual: Add installation of perltidy and perlcritic for pre-commit workflow
This commit adds the installation of perltidy and perlcritic as part of the pre-commit hooks workflow.
* Fix: Update version detection in dolibarr-doxygen-build.pl
- Add support for detecting version from DOL_MAJOR_VERSION and DOL_MINOR_VERSION constants
- Fix undefined variable issue in version detection
* Fix: Update getavatars.pl to use HTTPS and reverse git log
- Changed the URL from HTTP to HTTPS for Gravatar
- Added `--reverse` flag to git log command to process commits in chronological order (faster)
- Updated error message to indicate .git repository instead of .git directory (+ correct test)
* fix: Correct spelling in error messages and prompts
- Fixed typo in error message for missing environment variables
- Corrected spelling in prompt for module name input
- Improved clarity in comment for target checking
