Commit Graph

65 Commits

Author SHA1 Message Date
MDW
6a98adcc3c Qual: Further phpdoc fixes for phpstan (#30506)
* Fix int<0> typing to int<0,0> for phpstan

* Fix phpdoc for phpstan

* Fix phpdoc for phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-01 13:25:01 +02:00
MDW
46eb5f83c2 Qual: Updates for phpstan notices (#30509)
* Fix int<0> typing to int<0,0> for phpstan

* Fix phpdoc for phpstan

* Fix phpdoc for phpstan

* Qual: Several phpstan notice fixes

* Fix phpdoc

* Qual: totalpaid is never null, remove null test

* improve phpdoc typing

* Also return null to statisfy phpstan

* Allow null value for $var

* object->Object to make it meaningful

* Type EvalMathStack properties

* Comment out unused private methods (phpstan)

* Changes for phpstan (return values, phpdoc, code)

* Change order of tests for phpstan

* phpdoc object to Object for correct typing

* Typing hing for phpstan

* UPdate test for phpstan

* Change phpdoc position for phpstan

* Update phpdoc for phpstan

This needs further improvement

* Change $op to $ope to fix phpstan

* Update sqlite3.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-01 12:59:45 +02:00
Frédéric FRANCE
173dc1a70e fix constructor expects int (#30512)
* constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-01 10:52:53 +02:00
Laurent Destailleur
6210c2429a Fix phan 2024-08-01 10:50:52 +02:00
Laurent Destailleur
32d3424423 Fix warning 2024-07-31 14:29:42 +02:00
Laurent Destailleur
2f7a252244 Fix warnings 2024-07-31 13:09:10 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
thibdrev
30b9b71396 phpdoc (#29481) 2024-04-27 04:19:35 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
7b0177a84d Move to getDolGlobalString 2024-03-22 00:37:56 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
4aa0ccd870 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:54:14 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
13fcaf19f2 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:40:31 +01:00
Laurent Destailleur
5c80d4b4fd CSS 2024-03-05 15:43:11 +01:00
thibdrev
c93905cf81 qual: phpstan for htdocs/variants/class/ProductAttribute.class.php (#28122)
htdocs/variants/class/ProductAttribute.class.php	1401	Parameter #7 $seller (string) of method ProductAttribute::printObjectLine() should be compatible with parameter $seller (Societe) of method CommonObject::printObjectLine()
htdocs/variants/class/ProductAttribute.class.php	1401	Parameter #8 $buyer (string) of method ProductAttribute::printObjectLine() should be compatible with parameter $buyer (Societe) of method CommonObject::printObjectLine()
2024-02-12 02:06:42 +01:00
thibdrev
5a15ff9931 qual: phpstan for htdocs/variants/class/ProductAttribute.class.php
htdocs/variants/class/ProductAttribute.class.php	1315	Parameter #2 $seller (string) of method ProductAttribute::printObjectLines() should be compatible with parameter $seller (Societe) of method CommonObject::printObjectLines()

htdocs/variants/class/ProductAttribute.class.php	1315	Parameter #3 $buyer (string) of method ProductAttribute::printObjectLines() should be compatible with parameter $buyer (Societe) of method CommonObject::printObjectLines()

htdocs/variants/class/ProductAttribute.class.php	1401	Parameter #7 $seller (string) of method ProductAttribute::printObjectLine() should be compatible with parameter $seller (Societe) of method CommonObject::printObjectLine()

htdocs/variants/class/ProductAttribute.class.php	1401	Parameter #8 $buyer (string) of method ProductAttribute::printObjectLine() should be compatible with parameter $buyer (Societe) of method CommonObject::printObjectLine()
2024-01-25 12:03:22 +01:00
MDW
39769482b1 Qual: Fix typing hints for DoliDB (#27484)
# Qual: Fix typing hints for DoliDB

This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
MDW
342ab85195 Qual: Spelling htdocs/[q-z]* (#27447)
# Qual: Fix spelling htdocs/[q-z]*

Probably fixes a bug:

- htdocs/webservices/server_thirdparty.php
  No other occurence of adress found.
  -'adress'=>->adress,- +'address'=>->address,+
2024-01-12 17:18:52 +01:00
Frédéric FRANCE
61b79fda17 avoid phpstan error with phpdoc 2023-12-06 15:46:39 +01:00
Laurent Destailleur
619155f65e Fix with php-cs-fixer 2023-12-04 13:53:48 +01:00
Frédéric FRANCE
53c8a3acf8 clean phpdoc for phpstan (#26905) 2023-12-01 19:51:32 +01:00
Laurent Destailleur
075ee02901 Fix php8.2 warnings 2023-11-27 12:08:48 +01:00
Laurent Destailleur
e910c3fa4e CSS 2023-11-16 15:14:01 +01:00
Laurent Destailleur
91fa48199a Fix warnings 2023-09-10 17:41:22 +02:00
Laurent Destailleur
7ce9bf6b23 Clean code 2023-08-05 15:44:28 +02:00
Laurent Destailleur
e16d944284 Clean code 2023-05-30 13:37:56 +02:00
Laurent Destailleur
e2ec34e1e5 Clean code 2023-05-01 14:33:08 +02:00
Frédéric FRANCE
c8de4a35f0 doc 2023-02-20 20:38:10 +01:00
Laurent Destailleur
236b3aa9e8 Revert default type of hooks. Default is now 'addreplace' hooks (and
exception become 'output' hooks, that become deprecated).
2023-01-14 12:28:44 +01:00
Laurent Destailleur
43a0ccce2b Clean code 2023-01-04 11:37:24 +01:00
Laurent Destailleur
198e477142 Debug v17 2022-11-14 12:38:10 +01:00
Frédéric France
835441d437 remove blank line 2022-09-07 20:14:49 +02:00
Philippe GRAND
0551bfbfa6 FIX php8 compatibility 2022-08-28 14:43:08 +02:00
Laurent Destailleur
95dc25587c Standardize code of the fetch_lines() 2022-03-28 13:50:47 +02:00
kamel
26a462dce0 NEW : Update variants to standard card and list (permission) 2022-03-18 15:43:32 +01:00
kamel
1418fd7054 NEW : Update variants to standard card and list 2022-03-18 15:38:44 +01:00
Laurent Destailleur
43e7547611 Fix sql errors 2022-03-17 11:49:14 +01:00
Laurent Destailleur
6e422d26f3 FIX #yogosha5746 - next step (wip) 2021-03-30 16:20:18 +02:00
Laurent Destailleur
15440917b1 Fix #ygosha5698 2021-03-22 11:30:18 +01:00
Frédéric FRANCE
db871994fb code syntax variants webservice directory 2021-02-26 13:10:10 +01:00
stickler-ci
61903a1079 Fixing style errors. 2020-09-07 15:24:35 +00:00
Cédric
5992641360 Merge branch 'develop' into patch-3 2020-09-07 17:22:18 +02:00
Scrutinizer Auto-Fixer
b78ff67d7e Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-09-07 08:18:17 +00:00
stickler-ci
8d6c19a432 Fixing style errors. 2020-09-04 10:10:37 +00:00
Cédric
b841a4354e NEW ref_ext for Attributes 2020-09-04 12:06:09 +02:00
stickler-ci
d7a65a540e Fixing style errors. 2020-08-08 20:58:51 +00:00
Cédric
e73a7c78f7 NEW triggers create, modify, delete 2020-08-08 22:10:50 +02:00