Commit Graph

78 Commits

Author SHA1 Message Date
ldestailleur
bb3989c9a7 NEW The signature is on the good page even if another module add pages 2025-03-20 12:01:18 +01:00
Mélina JOUM
fdd642c5cc FIX: Retrieves the name of external or internal PDF 2025-02-26 11:33:07 +01:00
MDW
9ec4618199 Qual: Fix FunctionArray phan notices (#31754)
* Qual: Fix FunctionArray phan notices

* Fix class name in typing of htdocs/modulebuilder/index.php

* Fix customreports phpdoc

* Adjust file type after completeFileArrayWithDatabaseInfo

* Further phpdoc typing improvements

* More phpdoc

* Improve typing with cast on position field

* Force phpstan version

* Add phpstan exception

* Fix array index type + adjust phan config comment
2024-11-11 14:48:18 +01:00
Frédéric FRANCE
1adc883b56 add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
UltraViolet33
c0035cdf60 Fix set tiers as customer on online propal signature (#31316)
* fix set tiers as customer on online propal signature

* use setAsCustomer instead of set_as_client

---------

Co-authored-by: Ulysse Valdenaire <uvaldenaire@easya.solutions>
2024-10-09 01:06:23 +02:00
William Mead
e644f05f98 Qual clean use of CommonSignedObject trait (#30927)
* Cleaned & refactored code to make full use of CommonSignedObject trait

* Fixed Phan warning

* Revert "Fixed Phan warning"

This reverts commit b79b362733.

* Try @static tag

* Cleaned code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 17:45:05 +02:00
William Mead
3922b855da Fixed intervention online signature position (#30926)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:11:10 +02:00
William Mead
72aec91064 NEW shipment signed status update (#30928)
* Added event message

* Added CommonSignedObject trait. Updated LibStatut method. Removed unnecessary properties.

* Added SHIPPING_MODIFY notification

* Refactored to use setSignedStatus method

* Updated PHPDoc. Removed unnecessary properties. Added contributor details.

* Added signed status to shipping list

* Added signed status to fetch method

* Fixed type

* Added signed status to notification message

* Updated EN localization

* Fixed static property

* Added event message localization

* Updated EN localization

* Updated PHPDoc

* Added signed status for use in tooltip

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:09:53 +02:00
William Mead
fb6677010d NEW contract signed status update (#30779)
* Moved signed status constants to array dictionary

* Added getLibSignedStatus & getSignedStatusLocalisedArray methods

* Updated fetch & create methods for signed_status

* Added signed status to status badge

* Updated signed_status module builder field

* Added object context signed status for action trigger

* Added signed status to contract list

* Fixed signed status for contract list

* Added sign, unsign, confirm_sign, confirm_unsign actions. Added sign button.

* Fixed old contract without signed status

* Added contract modify notification

* Added contract signed status update

* Updated EN localizations

* Fixed contract notification administration

* Fixed notification message

* Fixed contract status badge

* Fixed langs

* Fixed langs key

* Fixed duplicate localization
2024-09-10 03:04:49 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
William Mead
e8e9e96bf4 FIX contract online signature image position (#30788)
* Moved online signature image to third party box

* Refactored xofrimgstart
2024-09-01 14:41:16 +02:00
William Mead
30805c68da NEW intervention signed status update (#30629)
* Added confirm_sign, confirm_unsign, sign & unsign actions. Added sign-unsign button.

* Updated create & fetch methods with signed_status

* Added EN localization

* Added intervention signed notification

* Added intervention signed auto event. Updated EN localization. Fixed trigger.

* Cleaned code

* Added signed label to status badge

* Cleaned code

* Added signed statues dictionary. Added method to get signed status label badge.

* Added signed status to intervention list

* Added sign localizations

* Added sign confirm select. Refactored signed statuses dictionary.

* Added method to get localized signed statuses arrray. Refactored code. Added EN localization.

* Fixed signed status update

* Cleaned code

* Updated EN localization

* Cleaned code

* Changed sign workflow to exclude only drafts

* Added signed status change with online sign

* Improved signed status workflow

* Removed db structure changes

* Updated action trigger to FICHINTER_MODIFY

* Updated EN localizations

* Refactored to use FICHINTER_MODIFY trigger with localized context message. Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Updated EN localizations.

* Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Cleaned Ecode.

* Fixed undeclared constant

* Added contributor details

* Updated notification logic to use object context to pass signature status

* Refactored to make use of object context for event notification. Cleaned code.

* Fixed deprecated method

* Cleaned code
2024-08-27 07:01:03 +02:00
Laurent Destailleur
1c52869e3b Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-05 16:59:07 +02:00
Anthony Berton
7ca87d9874 FIX - Pos propal sign page number starting from the end (#30243)
* FIX - Pos propal sign page number starting from the end

* Update onlineSign.php

---------

Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-04 21:34:43 +02:00
Alexandre SPANGARO
96afcaa476 Better comments (#30200)
* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* CI Missing language key

* Update eventorganization.lang

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-30 21:02:50 +02:00
Anthony Berton
44d4abd6a1 FIX - Online Sign pos on last page (#30158)
Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
2024-06-26 17:06:08 +02:00
Anthony Berton
020f38339a FIX - Online Sign pos on last page (#30139)
Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-24 22:31:39 +02:00
Laurent Destailleur
6e6271c47e Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-06-03 17:37:42 +02:00
MaximilienR-easya
a4f8866a86 Add hook to put signature on pdf (#29798)
* Add hook to put signature depending of the default pdf model

* phan warning

* travis fix

* travis fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-03 17:31:21 +02:00
Laurent Destailleur
236230585d Debug v20 2024-05-31 13:30:05 +02:00
IC-Mathieu
c01720ff31 NEW Can force position of signature on PDF using a setup constant (#29676)
* Fix waning during migration

* FIX-POSITION SIGNATURE ON ALL PAGES

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-15 15:12:26 +02:00
lamrani abdelwadoud
999bdaa719 NEW online signature of shipments (#29559)
* New functionality for signed shipment

* Add attribute for check if was already signed

* Update expedition.class.php

* Update onlineSign.php

* Update expedition.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 02:48:02 +02:00
Frédéric FRANCE
26da44e254 fix phpstan (#29431)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* remove params not used

* add WARNING
2024-04-27 12:45:50 +02:00
Laurent Destailleur
42b0fa2e88 Add option PROPAL_SIGNATURE_ON_SPECIFIC_PAGE 2024-04-18 00:01:22 +02:00
Laurent Destailleur
b58e439a17 Clean use of $_POST 2024-03-28 21:29:02 +01:00
Laurent Destailleur
3e8c3edd6d Clean code from _GET 2024-03-28 17:10:22 +01:00
MDW
69e335a13b Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname

PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-12 18:40:02 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491)
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
Laurent Destailleur
7193fae3dd Fix security on doc signature. Fix bad position of signature file. 2023-12-18 16:41:40 +01:00
Laurent Destailleur
7c756574b6 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2023-12-02 14:52:36 +01:00
HENRY Florian
722e266afb fix: add customer name ad sign date on PDF Soleil (#26919)
* fix: add customer anme ad sign date on PDF Soleil

* fix: review pos of text
2023-12-01 19:50:09 +01:00
MDW
e036e32caa qual Annotation/initialisation fixes (#26318) 2023-10-23 19:19:10 +02:00
MDW
706d0f6053 Fix __METHOD__ usage outside class-method (#26286) 2023-10-20 11:20:02 +02:00
Laurent Destailleur
b37a438067 The property ->user_validation to store ID of user validating has been
renamed into ->user_validation_id.
2023-10-17 11:10:25 +02:00
Florian HENRY
ce2b2f345f feat: RIB Online Sign 2023-05-05 11:48:24 +02:00
Florian HENRY
93255a0250 feat: RIB Online Sign 2023-05-03 23:59:45 +02:00
Florian HENRY
a071e873ff feat: RIB Online Sign 2023-05-03 22:11:49 +02:00
Laurent Destailleur
498b2d5279 Fix secured the Ajax components 2023-03-27 11:52:56 +02:00
Laurent Destailleur
54d1250887 Merge + Clean duplicate trigger code. We must use the context. 2023-03-02 02:19:24 +01:00
Laurent Destailleur
14a59483f5 Debug v17 2023-03-01 23:50:02 +01:00
Anthony Berton
1ff1d5fd68 size font 2023-02-28 22:07:49 +01:00
Anthony Berton
31adaf3e29 FIX getpost onlignsignname 2023-02-28 21:58:55 +01:00
Anthony Berton
5e8fc026cb add name and date on sign propal 2023-02-25 01:54:13 +01:00
Florian HENRY
8202bc6930 NEW: Notification for Sign or Refused Propal from Online Page 2022-12-01 13:56:14 +01:00
Laurent Destailleur
7238575a6d Clean code and add context information for onlineSign 2022-11-14 22:40:42 +01:00
stickler-ci
fadd77ef47 Fixing style errors. 2022-10-20 16:54:45 +00:00
Javier Núñez
1f02fb2419 Change signature lib to take fichinter into account 2022-10-20 16:52:57 +02:00
Laurent Destailleur
be10cdee95 Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into develop 2022-10-06 16:03:50 +02:00
Laurent Destailleur
8fdf4876d9 Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 16.0 2022-10-06 15:39:10 +02:00
Regis Houssin
65b5f002ea FIX missing class "societe" when create another object with workflow 2022-10-03 08:22:27 +02:00