Commit Graph

4126 Commits

Author SHA1 Message Date
Laurent Destailleur
069edfcf2a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-13 20:32:52 +02:00
hansemschnokeloch
6ba48c5db2 refactor redundant code (#31331) 2024-10-13 19:38:38 +02:00
Laurent Destailleur
6ef95acc43 Doc 2024-10-13 19:23:51 +02:00
Laurent Destailleur
e63fcc9fed Debug v20 2024-10-13 19:20:47 +02:00
UltraViolet33
a38af69395 use target='blank' for mailto links (#31342)
Co-authored-by: Ulysse Valdenaire <uvaldenaire@easya.solutions>
2024-10-13 17:41:22 +02:00
MDW
611019ec4d Qual: Fix WARNING messages in syslog - add getCallerInfoString() (#31351)
* Qual: Fix dolIsTms() call with empty string

# Qual: Fix dolIsTms() call with empty string

The dolibarr log indicated that dolIsTms() was called with the
empty string:

- Add code to log the caller in the log;
- Fix the dolIsTms() calls by updating project/element.php

* Fix comparison of ''<0

# Fix comparison of ''<0

As ''<0 is true, non-existing errors were added resulting in
Try to add a message in stack, but value to add is empty message
in the log.
2024-10-13 17:17:37 +02:00
MDW
d7b2f95baf Qual: Fix phan notices (#31372)
* fix llx_webhook_target-webhook.sql

* Fix commande/list & facture-rec.class

* Fix bonprelevement

* Qual: Fix prelevement/create notices

* Qual: fix quadridetail notices & update baseline

* Qual: Fix CommonDocGenerator notices

* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-10-13 16:45:42 +02:00
Laurent Destailleur
740bfe3442 Fix style section in html header lost 2024-10-13 02:01:14 +02:00
Laurent Destailleur
fc8e85158d NEW Can set parameters with setup type yesno. 2024-10-12 01:50:18 +02:00
Laurent Destailleur
7ec900d1de comment 2024-10-11 12:24:45 +02:00
UltraViolet33
615d13d815 Fix: complete fix for #31117 (#31300)
* Fix: complete fix for #31117
Use getSommePaiement(), getSumCreditNotesUsed() and getSumDepositsUsed() to get already paid amount of invoice
to display correct invoice status

* fix for PHPStan

---------

Co-authored-by: Ulysse Valdenaire <uvaldenaire@easya.solutions>
2024-10-09 01:55:38 +02:00
Laurent Destailleur
8ba82ecfa0 Enhancement for textbrowser 2024-10-08 20:58:09 +02:00
Laurent Destailleur
efe6571e16 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-08 20:49:01 +02:00
Laurent Destailleur
21eb8e585f Fix detection of text browser with w3m 2024-10-08 20:48:37 +02:00
Laurent Destailleur
e79292cb19 Enhance vat edition 2024-10-08 09:59:46 +02:00
John BOTELLA
7faa9bad67 Fix 20.0 Action buttion url autocomplete (button dropdown part04) (#31266)
* Fix dol get action buttion url autocomplette

* change mailto

* change mailto

* Remove anonymous function

* Remove anonymous function

* Update functions.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-07 15:42:17 +02:00
Laurent Destailleur
a7db9f8b75 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-10-07 15:23:41 +02:00
Laurent Destailleur
081d3fabfc Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-07 15:20:16 +02:00
Laurent Destailleur
b07cc82058 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-10-07 15:17:49 +02:00
Laurent Destailleur
58cc96cd33 QUAL All $conf->global->module->enabled are replaced with isModEnabled() 2024-10-07 14:40:29 +02:00
Laurent Destailleur
63d4b5e3d8 FIX Backport fix fatal error on price with some truncating setup 2024-10-06 22:17:26 +02:00
MDW
34e3717dda Qual: Fix phan/phpstan notices (#31289)
* Qual: Fix phan/phpstan notices

# Qual: Fix phan/phpstan notices

Fix several phan/phpstan notices

* Fix spelling in Changelog
2024-10-06 13:03:43 +02:00
MDW
f70c945931 Qual: Fix phan/stan notices (#31271)
# Qual: Fix phan/stan notices in relation with UnknownObjectMethodCall

Fix notices in classes with UnknownObjectMethodCall notices or classes
related with these.
2024-10-05 18:55:36 +02:00
Frédéric FRANCE
7fe28032d1 phpstan (#31276)
* phpstan

* phpstan
2024-10-05 18:49:54 +02:00
Mohamed DAOUD
4a7ad31f85 NEW Stars Field for Module Builder (#31216)
* stars field for modulebuilder

* Update commonobject.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-04 18:37:41 +02:00
Laurent Destailleur
bd4dbe7b1a Remove not used method 2024-10-04 12:35:23 +02:00
MDW
6e01a60f59 Qual: Fix phan/phpstan notices (#31259)
# Qual: Fix phan/phpstan notices

Fix notices by adjusting phpdoc
2024-10-04 08:25:17 +02:00
Laurent Destailleur
d24069d5e2 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-03 20:35:33 +02:00
Laurent Destailleur
eebb16c693 Redice cyclomatic complexity 2024-10-03 20:08:09 +02:00
MDW
1834c37c16 Qual: Fix phan notices (#31212)
* Qual: Fix phan notices

# Qual: Fix phan notices

Fix several phan notices related to classes with UnknownObject
classes.

* Qual: Fix phan notices

* Qual: Fix phan notices

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-03 19:40:34 +02:00
Laurent Destailleur
e412dbbe05 Merge manually fix of #31217 + other fix for use by external modules 2024-10-03 19:30:06 +02:00
Laurent Destailleur
6f6a87cd78 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-03 17:25:10 +02:00
Laurent Destailleur
88b488cfbb Fix for better compatibility 2024-10-03 17:23:29 +02:00
John BOTELLA
a272d929a5 Fix $ in key (#31215) 2024-10-03 17:14:28 +02:00
Frédéric FRANCE
7d36fe0715 fix typo phan and Co 💊 (#31214)
* fix typo

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* translation missing

* test win mariadb version

* test win mariadb version

* phpdoc

* phpdoc

* phpdoc
2024-10-03 15:43:04 +02:00
Laurent Destailleur
2d4ea679cc Debug v21 2024-10-03 12:43:21 +02:00
Laurent Destailleur
b87b0b92b8 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-02 17:31:42 +02:00
Laurent Destailleur
11ea0ad9fd Fix fatal error with bad parameters 2024-10-02 15:15:52 +02:00
Laurent Destailleur
b5730db759 Fix error 2024-10-02 12:19:29 +02:00
Laurent Destailleur
8bdd3fe3cd Fix error 2024-10-02 12:19:21 +02:00
Laurent Destailleur
9c98e3816a Fix error 2024-10-02 12:18:55 +02:00
Laurent Destailleur
7f8a0860cf Fix error 2024-10-02 12:16:46 +02:00
Laurent Destailleur
6f7b0c1815 NeW Can add the info messages (error, waring...) at the top of the stack 2024-09-30 14:30:28 +02:00
Laurent Destailleur
61e8382869 Fix SERVICE_ARE_ECOMMERCE_200238EC #31159 in transfer of sale journal 2024-09-30 10:46:51 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Frédéric FRANCE
138ffa3158 fix phpstan (#31181)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-29 21:49:52 +02:00
Laurent Destailleur
c5163d0d96 CSS 2024-09-29 17:31:46 +02:00
Frédéric FRANCE
0e1292e253 fix phpstan (#31177)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-29 02:49:34 +02:00
Laurent Destailleur
a423da6a4b CSS Look and feel v21 2024-09-29 01:20:02 +02:00
Laurent Destailleur
5f21a3a4e3 NEW The margin section can now be shown/hidden 2024-09-28 15:10:28 +02:00