Commit Graph

9579 Commits

Author SHA1 Message Date
Laurent Destailleur
0617d43460 Fix link to create an event 2024-03-15 14:39:40 +01:00
Laurent Destailleur
f0821a6b42 Fix date param must use the day/hour/year instead of one string date. 2024-03-15 13:34:49 +01:00
Laurent Destailleur
905ed49726 Merge pull request #28875 from W1W1-M/qual-list-new-action-time
QUAL use real time when creating action from list
2024-03-15 13:23:23 +01:00
William Mead
6d7ce609ca Updated add button to use minutes and local user time 2024-03-15 12:30:00 +01:00
Laurent Destailleur
470e68829d Merge branch 'develop' into fix/PhanTypeInvalidUnaryOperandNumeric 2024-03-15 10:03:50 +01:00
Laurent Destailleur
80e2e59373 Merge pull request #28862 from mdeweerd/fix/PhanTypeMismatchPropertyDefault
Fix & enable PhanTypeMismatchPropertyDefault
2024-03-15 09:33:40 +01:00
Laurent Destailleur
e238cc204e Merge pull request #28750 from mdeweerd/fix/PhanPluginSuspiciousParamPosition
Fix: Resolve several PhanPluginSuspiciousParamPosition cases
2024-03-15 08:45:25 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
00e65bb09d Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:44:44 +01:00
MDW
803249fc3b Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:44:43 +01:00
Laurent Destailleur
1729129a9f Merge pull request #28834 from W1W1-M/qual-deprecated-user-done
Qual deprecated user done
2024-03-14 22:57:31 +01:00
MDW
eba0344460 Qual: suppress PhanPluginSuspiciousParamPosition notice 2024-03-14 19:39:56 +01:00
MDW
69be3bbca6 Fix PhanTypeInvalidUnaryOperandNumeric & remove from exceptions
# Fix PhanTypeInvalidUnaryOperandNumeric & remove from exceptions

Fix by casting result of date() or by adding typing hints.

(This notification indicates a unary '-' or similar is performed
on a value that may not be a number).
2024-03-14 19:39:49 +01:00
MDW
6745fe4a51 Fix PhanPluginSuspiciousParamPosition by renaming arg (local assign) 2024-03-14 19:39:39 +01:00
MDW
8b00d0c359 Fix PhanPluginSuspiciousParamPosition by renaming arg (local assign) 2024-03-14 19:39:38 +01:00
MDW
4719e1a280 Fix PhanPluginSuspiciousParamPosition by renaming arg (local assign) 2024-03-14 19:39:37 +01:00
MDW
a7274050d2 Fix PhanPluginSuspiciousParamPosition 2024-03-14 19:39:31 +01:00
William Mead
da2546d9d3 Added contributor details 2024-03-14 13:48:44 +01:00
William Mead
93a2ab24c8 Deleted AGENDA_ENABLE_DONEBY option. Cleaned code. 2024-03-14 13:43:44 +01:00
William Mead
1134d9a7f0 Deleted userdoneid. Cleaned code. 2024-03-14 13:39:43 +01:00
William Mead
7629455b7d Added deprecated for user done 2024-03-14 09:29:51 +01:00
Laurent Destailleur
c867bc2706 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-13 22:36:45 +01:00
Laurent Destailleur
8bfc0779c4 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-13 22:20:08 +01:00
Laurent Destailleur
a0b26ae7cd FIX Amount of localtaxes in foreign currency was wrong on screen and PDF 2024-03-13 22:04:44 +01:00
Laurent Destailleur
2b5ea3fa74 Merge pull request #28810 from W1W1-M/fix-cactioncomm-php-warnings
Fix PHP warnings cactioncomm class
2024-03-13 14:31:53 +01:00
William Mead
b9007acbf1 Fixed PHP warnings 2024-03-13 14:03:27 +01:00
MDW
fb2aadf006 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:36 +01:00
MDW
3c24140ccf Fix PhanPluginRedundantAssignment 2024-03-13 00:40:35 +01:00
MDW
ce626d72ed Fix PhanPluginMixedKeyNoKey by using explicit keys 2024-03-12 21:35:44 +01:00
MDW
7eb27d1891 Fix PhanPluginMixedKeyNoKey by using explicit keys 2024-03-12 21:35:43 +01:00
Laurent Destailleur
a6926c29c0 Merge pull request #28778 from fappels/develop_fix_delivery_note
Fix shipping is not a delivery_note (is sub module of shipping)
2024-03-12 14:53:51 +01:00
Laurent Destailleur
74b8162d22 Merge pull request #28700 from mdeweerd/urlencode/fixuptype
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
Laurent Destailleur
9e16016125 Merge pull request #28770 from mdeweerd/typing/fields
Fix: Repeat fields typing in CommonClass children
2024-03-12 14:30:36 +01:00
Francis Appels
6f1b184f17 Merge remote-tracking branch 'Dolibarr/develop' into develop_fix_delivery_note 2024-03-12 14:13:41 +01:00
Laurent Destailleur
0b936bebe7 Merge pull request #28773 from frederic34/clean_mod_code
clean code and phpdoc
2024-03-12 14:09:23 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
Francis Appels
7ff68a5819 Fix shipping is not a delivery_note (sub module of shipping) 2024-03-12 11:07:18 +01:00
Laurent Destailleur
7869c1a309 AI support both plain text and HTML generation 2024-03-12 10:01:39 +01:00
Frédéric France
7fabf59b46 clean code and phpdoc 2024-03-11 23:13:30 +01:00
MDW
ed703c7241 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:55 +01:00
MDW
4ec7a53e3f Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:52 +01:00
Lamrani Abdel
5e2a06a177 Add layout and prompt ai on create emmailing 2024-03-11 15:23:26 +01:00
MDW
b72cf193c4 Fix some cases of PhanTypeSuspiciousStringExpression (#28751)
* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-11 14:01:28 +01:00
MDW
dbfb1180ee Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions (#28749)
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions

Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
2024-03-11 12:58:51 +01:00
MDW
d524e97137 Qual: Fix & enable PhanPluginRedundantAssignmentInLoop (#28733)
# Qual: Fix & enable PhanPluginRedundantAssignmentInLoop

Fixes the occurences that generated this notice & enable the report
for PhanPluginRedundantAssignmentInLoop
2024-03-10 01:54:34 +01:00
MDW
4fa993fe8a Fix: Ensure string type for urlencode() 2024-03-09 16:57:05 +01:00
MDW
92ae7239cb Fix: Ensure string type for urlencode() 2024-03-09 16:53:15 +01:00
MDW
448e4ae322 Fix: Ensure string type for urlencode() 2024-03-09 16:53:14 +01:00
MDW
014fb8d967 Fix: Ensure string type for urlencode() 2024-03-09 16:53:12 +01:00
MDW
54f05cc69e Fix: Ensure string type for urlencode() 2024-03-09 16:53:11 +01:00