Commit Graph

1175 Commits

Author SHA1 Message Date
ldestailleur
a674676ded Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-05-10 13:33:53 +02:00
ldestailleur
0b3811a7e4 Better protection on approval 2025-05-05 12:32:57 +02:00
ldestailleur
aa81500780 Better protection on approval 2025-05-05 12:30:50 +02:00
ldestailleur
390b6719ab FIX Approver must be able to approve even if user not in hierarchy. 2025-05-05 12:22:23 +02:00
ldestailleur
ae59c409f6 Modulebuilderization 2025-03-26 00:56:24 +01:00
MDW
2cd6459d10 Qual: Fix phan notices (*card) (#33450) 2025-03-14 17:25:11 +01:00
Mohamed DAOUD
881b5eb631 FIX #33169 Anyone can cancel vacation requests (#33343)
* fix anyone can cancel

* Fix cancel button visibility based on user permissions

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-03-07 11:12:00 +01:00
MDW
928402c847 Qual: Fix phan (project-1) 2025-02-11 00:22:39 +01:00
Laurent Destailleur (aka Eldy)
b6ac3ea2e9 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2025-02-05 10:45:38 +01:00
Laurent Destailleur (aka Eldy)
31daa4a2f0 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0 2025-02-04 23:25:24 +01:00
Regis Houssin
ecf1d2553b FIX wrong file path + avoid warning 2025-02-04 02:27:34 +01:00
MDW
2cd13853d5 Qual: Fix phan notices (ftp, holiday)
# Qual: Fix phan notices (ftp, holiday)
2025-02-03 16:06:02 +01:00
MDW
a42bc6755c Qual: Fix PhanPluginUnknownPropertyType, PhanPossiblyUndeclaredVariable 2025-01-27 10:24:16 +01:00
Laurent Destailleur (aka Eldy)
0932c2e492 Debug v21 2025-01-24 17:28:10 +01:00
Laurent Destailleur (aka Eldy)
b024b95948 Fix typo 2025-01-09 19:35:01 +01:00
Laurent Destailleur (aka Eldy)
56710ce9b7 FIX CVE-2024-55227 and CVE-2024-55228 CSRF when
MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is
on (hidden option not on by default)
2025-01-09 19:35:01 +01:00
Laurent Destailleur (aka Eldy)
56571b09ec Debug v21 2024-12-30 16:59:16 +01:00
Frédéric France
b2c3ec675b fix phpstan 2024-12-03 21:30:01 +01:00
Frédéric France
1a4c9736b7 fix phpstan 2024-12-03 21:17:10 +01:00
MDW
9ec4618199 Qual: Fix FunctionArray phan notices (#31754)
* Qual: Fix FunctionArray phan notices

* Fix class name in typing of htdocs/modulebuilder/index.php

* Fix customreports phpdoc

* Adjust file type after completeFileArrayWithDatabaseInfo

* Further phpdoc typing improvements

* More phpdoc

* Improve typing with cast on position field

* Force phpstan version

* Add phpstan exception

* Fix array index type + adjust phan config comment
2024-11-11 14:48:18 +01:00
Frédéric FRANCE
15490b292f fix phpstan and fix CI (#31739)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-11-10 11:16:23 +01:00
Laurent Destailleur
31f147622a The deprecated GET parameter "&sall=" has been removed, use now the
"&search_all=".
2024-11-07 12:26:42 +01:00
Frédéric FRANCE
1adc883b56 add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
Laurent Destailleur
e6f1d4835f Clean sql code 2024-10-29 02:58:20 +01:00
Laurent Destailleur
2a39e9edca Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-26 15:56:30 +02:00
Laurent Destailleur
f5e4ab0220 Rewrite code to prepare refactoring 2024-10-26 15:24:54 +02:00
Laurent Destailleur
c42605b0c5 FIX Filter on month of the balance of leaves. 2024-10-25 16:41:25 +02:00
Frédéric FRANCE
331c5e9f4b fix phpstan (#31547)
* fix phpstan

* fix phpstan

* fix phpstan
2024-10-25 13:24:10 +02:00
Laurent Destailleur
046166f483 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-14 21:38:12 +02:00
Laurent Destailleur
916014707d Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-14 21:18:24 +02:00
Laurent Destailleur
b099e103b3 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-10-14 21:00:26 +02:00
Laurent Destailleur
d819d88718 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-10-14 20:18:46 +02:00
Laurent Destailleur
278eea6fae Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2024-10-14 20:18:22 +02:00
Laurent Destailleur
fa22ebd893 Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0 2024-10-14 19:31:08 +02:00
Yannis Hoareau
42089e3542 New: add configuration to choose if holiday are updated at the end of month (#29438)
* New setting for holiday updates

* FIX: holidays accounting at the end of taken month: log consumption for every request + update translations

* FIX: holidays accounting at the end of taken month: update conf name

* FIX: holidays accounting at the end of taken month: refactor monthly cron update

* FIX: holidays accounting at the end of taken month: update conf translation

* FIX: holidays accounting at the end of taken month: initialize holiday array + delete duplicate code

* New setting for holiday updates

* FIX: holidays accounting at the end of taken month: log consumption for every request + update translations

* FIX: holidays accounting at the end of taken month: update conf name

* FIX: holidays accounting at the end of taken month: refactor monthly cron update

* FIX: holidays accounting at the end of taken month: update conf translation

* FIX: holidays accounting at the end of taken month: initialize holiday array + delete duplicate code

* FIX: holidays accounting at the end of taken month: clean code

* FIX: holidays accounting at the end of taken month: empty now used on variables

* FIX: holidays accounting at the end of taken month: resolve not casted var in sql request

* FIX: holidays accounting at the end of taken month: now using only dolibarr functions

* FIX: holidays accounting at the end of taken month: fix php-stan and rework casting to int

* FIX: holidays accounting at the end of taken month: fix php-stan and rework casting to int (2)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Yannis Hoareau <93135242+JustRaosha@users.noreply.github.com>
2024-10-10 00:13:36 +02:00
Laurent Destailleur
9509929f5d Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 15.0 2024-10-07 15:11:42 +02:00
MDW
0c26110636 Qual: Fix notices related to user classes (#31291)
# Qual: Fix notices related to user classes

This fixes several notices related to user classes (and reveals
some actual bugs or inconsistent typing).
2024-10-06 13:52:05 +02:00
MDW
2d0b1de36f Qual: Add codespell entries to catch some css typos (#31222)
# Qual: Add codespell entries to catch some css typos

Added some codespell entries based on the observed typos in css
tags
2024-10-03 19:36:59 +02:00
thomas-Ngr
e71631abe0 fix : missing update for extrafields on holidays (#31256) 2024-10-03 19:33:33 +02:00
MDW
8236aed22f Qual: Fix phan notices (#31193)
# Qual: Fix phan notices

Fix phan notices in several classes that have UnknownObjectMethod calls and classes
that had notices in relation with these classes
2024-09-30 10:05:24 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Laurent Destailleur
b32225283d Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop 2024-09-25 22:32:36 +02:00
Laurent Destailleur
59dadd88a3 FIX Duplicate trigger printFieldPreListTitle 2024-09-25 13:43:11 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081)
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Laurent Destailleur
c79f72f785 Fix missing tests on permissions 2024-09-03 16:19:18 +02:00
Laurent Destailleur
6240ac9bce Look and feel v21 2024-09-03 14:57:25 +02:00
Laurent Destailleur
14d5b4bcc3 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-02 12:14:51 +02:00
Laurent Destailleur
ef84ba2a13 Debug v20 2024-09-02 10:21:24 +02:00
MDW
a8367a6cd8 Qual: Fix getNextValue related phan notices (part2) (#30752)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Fix getNextValue related phan notices (part2)

* Update baseline

* Qual: Fix phan notice
2024-08-29 13:34:24 +02:00
Laurent Destailleur
ba25c49333 Fix permiss 2024-08-22 14:10:59 +02:00