ldestailleur
8a89cc3f04
FIX phpunit
2025-03-24 20:52:13 +01:00
Laurent Destailleur
746b7cc23e
Merge branch 'develop' into patch-11
2025-03-05 20:56:57 +01:00
ldestailleur
77d2be9087
Fix CI
2025-03-05 20:53:39 +01:00
Frédéric FRANCE
68676d5ac6
no label property on RecruitmentCandidature
2025-03-05 20:00:35 +01:00
Frédéric FRANCE
f9f93287ea
no label property on RecruitmentCandidature
2025-03-05 18:56:51 +01:00
MDW
c405666765
Qual: Fix phan notices (recruitment)
2025-02-13 22:37:20 +01:00
MDW
24fa28dfe2
Qual: Fix getKanban phpdoc
...
# Qual: Fix getKanban phpdoc
Array phpdoc for getKanban corrections.
2025-02-05 01:43:37 +01:00
Laurent Destailleur (aka Eldy)
732f97d73c
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2025-02-05 00:40:06 +01:00
Laurent Destailleur (aka Eldy)
de321e8f01
Fix typo
2025-01-09 02:01:49 +01:00
Laurent Destailleur (aka Eldy)
c0250e4c91
FIX CVE-2024-55227 CSRF when MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is
...
on (hidden option not on by default)
2025-01-08 17:41:45 +01:00
Frédéric France
22be2de259
fix phpstan
2024-12-15 09:01:36 +01:00
Frédéric France
27a1edb6fc
fix phpstan
2024-12-15 08:58:20 +01:00
Laurent Destailleur
0953ce3ca2
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-12-09 01:07:33 +01:00
Laurent Destailleur
e2db3d213b
Fix phpunit
2024-12-09 00:03:09 +01:00
Laurent Destailleur (aka Eldy)
352d156dd7
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-12-08 17:07:14 +01:00
Laurent Destailleur (aka Eldy)
774a48fa29
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-12-08 16:53:21 +01:00
MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
...
# Qual: Update fields phpdoc to include fields that are defined/used in some cases
comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Hystepik
41d58cd88e
Fix #26009 better fix
2024-12-04 12:13:41 +01:00
Laurent Destailleur
7b2d0bcd53
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-11-21 18:41:14 +01:00
Laurent Destailleur
3d2adf511e
Debug v21
2024-11-21 18:39:48 +01:00
Laurent Destailleur
63073f7e71
FIX #32021
2024-11-21 18:15:34 +01:00
MDW
278d301f32
Qual: Fix phan/phpstan notices in class files (part 6) ( #31634 )
...
* Qual: Fix notices for paymentdonation...workstationusergroup.class
* Qual: Fix PhanPluginRedundantReturnComment, update baseline
* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
Laurent Destailleur
e6f1d4835f
Clean sql code
2024-10-29 02:58:20 +01:00
MDW
d7b2f95baf
Qual: Fix phan notices ( #31372 )
...
* fix llx_webhook_target-webhook.sql
* Fix commande/list & facture-rec.class
* Fix bonprelevement
* Qual: Fix prelevement/create notices
* Qual: fix quadridetail notices & update baseline
* Qual: Fix CommonDocGenerator notices
* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)
---------
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com >
2024-10-13 16:45:42 +02:00
MDW
f4c91d5bb6
Qual: Fix phan/phpstan notices ( #31297 )
...
# Qual: Fix phan/phpstan notices
Fix several phan and phpstan notices.
2024-10-07 14:07:24 +02:00
Lucas Marcouiller
b595b30a5b
New create public page for recruitment candidature ( #31220 )
...
* New creation of public recruitement candidature
* Fix some problems
* fix lang file
* Fix CI
* Fix CI
---------
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-10-04 09:00:17 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-29 21:52:31 +02:00
Lucas Marcouiller
9ecfe2609b
Fix add ip field by adding it in module builder recruitement candidature fields ( #31060 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
2024-09-20 18:10:56 +02:00
Lucas Marcouiller
23b3b07526
New add ip field on recurtementcandidature and societe ( #31045 )
...
* New add ip field on recurtementcandidature and societe
* fix CI
* fix CI
---------
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
2024-09-20 00:22:42 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
ptibogxiv
42a79c3dc0
Update api_recruitments.class.php with pagination ( #30677 )
...
* Update api_recruitments.class.php with pagination
* Update api_recruitments.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-20 09:44:07 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-15 17:05:00 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 03:05:02 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Frédéric FRANCE
4b275dc148
add phpdoc ( #30208 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* clean phpdoc
2024-06-30 19:39:01 +02:00
Laurent Destailleur
920cf5f70f
Debug v20
2024-06-26 13:47:19 +02:00
Frédéric FRANCE
741e75ee47
add phpdoc ( #29832 )
...
* add phpdoc
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* add phpdoc
* fix phan
* fix phan
2024-06-04 14:46:54 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-05-05 00:34:19 +02:00
Laurent Destailleur
b5de782c6b
Fix use the good HTTP code
2024-04-07 14:59:25 +02:00
Laurent Destailleur
fd9475be03
Use same doc comment eveywhere.
2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d
PHPDoc
2024-04-05 13:44:59 +02:00
Laurent Destailleur
990216b13f
NEW Api parameters are sanitized by the WAF, same code than GET/POST
2024-04-02 13:07:13 +02:00
Laurent Destailleur
7b0177a84d
Move to getDolGlobalString
2024-03-22 00:37:56 +01:00
MDW
b452a89cc3
Fix $mybool |=... which is binary op, not boolean op
...
# Fix $mybool |=... which is binary op, not boolean op
This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:48 +01:00
MDW
105a4d0402
Fix $mybool |=... which is binary op, not boolean op
...
# Fix $mybool |=... which is binary op, not boolean op
This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:47 +01:00
MDW
fd9d48faac
Fix phpstan CommonObject->fields - notnull is optional field
2024-03-19 00:32:00 +01:00
MDW
23785393a3
Add csslist to json keys
2024-03-15 03:55:52 +01:00
MDW
72bc4cbe74
Fix PhanTypeMismatchPropertyDefault
2024-03-15 03:54:11 +01:00
MDW
ccc93dfdc8
Fix PhanTypeMismatchPropertyDefault
2024-03-15 03:54:10 +01:00
