Commit Graph

37415 Commits

Author SHA1 Message Date
Frédéric FRANCE
f2e580f46f fix phpstan (#30958)
* fix phpstan

* fix phpstan

* Update html.formadmin.class.php
2024-09-17 02:38:56 +02:00
Laurent Destailleur
cb3ce12bfc Debug webportal module Fix #30981 2024-09-17 02:29:43 +02:00
Laurent Destailleur
c617ab7c0e Debug webportal module Fix #30981 2024-09-17 02:25:45 +02:00
Laurent Destailleur
e9559d7d31 Fix phpstan 2024-09-17 00:39:32 +02:00
Frédéric FRANCE
763405a34c fix phpstan (#30985)
* fix phpstan

* fix phpstan
2024-09-17 00:23:25 +02:00
Frédéric FRANCE
e43789a3d7 fix phpstan (#30984)
* fix phpstan

* fix phpstan

* fix phpstan
2024-09-17 00:22:47 +02:00
Laurent Destailleur
cd8ddb7a8b FIX better compatibility with some old extrafield syntax filter 2024-09-16 15:59:13 +02:00
Laurent Destailleur
65edbd5f9f FIX better compatibility with some old extrafield syntax filter 2024-09-16 15:50:47 +02:00
Laurent Destailleur
f56a1d23b2 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-16 11:38:14 +02:00
Laurent Destailleur
9727a37967 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-16 11:37:59 +02:00
Laurent Destailleur
1ae4bf4337 Fix duplicate of doc 2024-09-16 11:34:58 +02:00
John BOTELLA
8bfbbf7971 extend drop down behavior to all drop down (#30933)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-16 01:52:33 +02:00
MDW
9a9e851494 Qual: Fix new UndeclaredGlobalVariable notices & enable (#30963)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: Fix new UndeclaredGlobalVariable notices & enable

# Qual: Fix new UndeclaredGlobalVariable notices & enable

This fixes several new notices regarding 'undeclared globals' which
mostly correspond to missing initialisations in views and some real
bugs where the variable name was incorrect.
Some less obvious cases are unsolved and ignored (adherents/list,
and fourn/commande/card).

This is in preparation of fixing the notices in the other files
where the baseline was already set to ignore them where most just
need a phan-var-force declaration which will help with verifying
type compatibity and object member verifications
2024-09-16 01:50:58 +02:00
MDW
115627a054 Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice (#30957)
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice

* Update phan baseline

* Fix $website global type in some contexts
2024-09-16 01:49:38 +02:00
MDW
320f0590d2 Qual: More specific phpstan exceptions (#30967)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: More specific phpstan exceptions

# Qual: More specific phpstan exceptions

Avoid ignoring new types of code errors
2024-09-16 01:46:20 +02:00
Laurent Destailleur
22ae541e3b Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-16 00:08:33 +02:00
Laurent Destailleur
283bd723ec Debug v20 - Fix filter on extrafields for select from table 2024-09-15 23:51:03 +02:00
Laurent Destailleur
2593561ab6 Fix label of menu 2024-09-15 18:21:36 +02:00
Laurent Destailleur
26ba862540 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-14 02:45:04 +02:00
Laurent Destailleur
c462a572ee Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-09-14 02:44:26 +02:00
Laurent Destailleur
2cb8eeee77 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-14 01:37:10 +02:00
Laurent Destailleur
3025f7ba25 NEW Add getImageFromHtmlContent() method 2024-09-14 01:36:31 +02:00
Laurent Destailleur
057fcdfaef Fix: In v20, all global caches must use $conf->cache['nameofcache']
instead of a global variable.
2024-09-13 18:44:23 +02:00
William Mead
e644f05f98 Qual clean use of CommonSignedObject trait (#30927)
* Cleaned & refactored code to make full use of CommonSignedObject trait

* Fixed Phan warning

* Revert "Fixed Phan warning"

This reverts commit b79b362733.

* Try @static tag

* Cleaned code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 17:45:05 +02:00
Josep Lluís
fa62be55d9 Update pdf_vinci.modules.php (#30946)
The date_approve field doesn't exist and has been replaced by date_start_planned
2024-09-13 17:39:39 +02:00
John BOTELLA
308178d5bc QUAL : Ergo btn and fix (#30947)
* Clean sql

* Doc

* Fix ergo feedback and accessibility button

* Add hsl color var to allow css use user color with variants

* Add hsl color var to allow css use user color with variants

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 17:30:41 +02:00
Laurent Destailleur
04ebf52bd0 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-13 11:13:51 +02:00
Laurent Destailleur
4a303a61d1 More robust test on missing permission for CTI 2024-09-13 11:13:38 +02:00
Laurent Destailleur
75d62b5f0a Fix check on permissions 2024-09-13 04:47:07 +02:00
Laurent Destailleur
857405bea6 Doc 2024-09-13 03:47:30 +02:00
William Mead
3922b855da Fixed intervention online signature position (#30926)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:11:10 +02:00
William Mead
72aec91064 NEW shipment signed status update (#30928)
* Added event message

* Added CommonSignedObject trait. Updated LibStatut method. Removed unnecessary properties.

* Added SHIPPING_MODIFY notification

* Refactored to use setSignedStatus method

* Updated PHPDoc. Removed unnecessary properties. Added contributor details.

* Added signed status to shipping list

* Added signed status to fetch method

* Fixed type

* Added signed status to notification message

* Updated EN localization

* Fixed static property

* Added event message localization

* Updated EN localization

* Updated PHPDoc

* Added signed status for use in tooltip

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:09:53 +02:00
MDW
f89245b354 Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00
Laurent Destailleur
1f33c81038 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 22:06:18 +02:00
Laurent Destailleur
6a15df3a52 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-12 22:01:08 +02:00
Laurent Destailleur
5b4c404957 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-09-12 21:59:59 +02:00
Laurent Destailleur
1b24270a46 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-09-12 21:59:42 +02:00
Laurent Destailleur
65e5899442 Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2024-09-12 21:58:28 +02:00
Marc de Lima Lucio
d17890f05b FIX: purge files cron: php warnings when rest module enabled (#30919) 2024-09-12 21:57:41 +02:00
Laurent Destailleur
cc63d3f8f5 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 21:50:57 +02:00
Laurent Destailleur
bf697f83eb Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-09-12 21:50:31 +02:00
Mohamed DAOUD
797ec9a709 fix-seo-meta-tags-sanitization (#30924)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-12 21:35:38 +02:00
Lucas Marcouiller
ef2ec011f5 Fix #30828 bad save of contract id in ticket card (#30916)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-09-12 21:34:28 +02:00
MDW
76eaf8bd8d Qual: Fix phan notices in classes related to class using getNextValue. (#30925)
* FIX 🛟 phan

* getToolTip() can take null for $coc

* Fix uninitialized vars & arg types

* PHPDoc typing, argument fixes

* PHPDoc typing, argument fixes for AdherentType

* PHPDoc typing, argument fixes for AdherentStats

* Update baseline to enable adherent notices

* Fix PHPDoc typing in api_members

* Minor bug fixes, typing

* PHPDoc api_subscriptions

* PHPDoc Societe

* Ignore empty foreach notice

* Add initialiser

* Categorie is string, old int mode is deprecated

* Fix missing initialisations

* Fix missing initialisations adherents/note

* Fix typing (cast), initialisation of var

* Fix initialisations

* Fix argument types

* Improve array PHPDoc type

* PHPDoc array type

* PHPDoc: Improve typing

* Correct argument type to getNomUrl

* Improve typing for timespent

* Fix typing for getNextValue args

* Improve typing

* Fix typing hints contrat/card

* Update baseline

* Fix typing

* Fix extraparams property typing

* Fix argument typing

* Qual: Correct covariant type

* Impove typing for timespent

* Remove exclusion no longer matched (level 6)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-09-12 21:16:42 +02:00
John BOTELLA
aaa65ddf6b Fix v20 php8 patch001 (#30932)
* Fix PHP 8 notices, warninngs, fatal

* precommit
2024-09-12 21:10:01 +02:00
Laurent Destailleur
3bf7bab967 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 02:21:46 +02:00
Laurent Destailleur
a52963020d Doc 2024-09-12 02:21:14 +02:00
Laurent Destailleur
b1ee18864f Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 01:43:43 +02:00
Laurent Destailleur
cbf3cbfa1f Better debug log 2024-09-12 01:33:58 +02:00
Laurent Destailleur
2bd701a87f Debug v20 2024-09-11 16:46:16 +02:00