Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
MDW
f4ff437026
Qual: Fix phan/phpstan notices in class files (part 4) ( #31598 )
...
* Qual: Fix phan notices for DolibarrModules.class
* Qual: Fix notices for classes actioncomm..task.class.php
* fixup! Qual: Fix notices for classes actioncomm..task.class.php
* Qual: Fix new notices blocking PR
2024-10-30 21:33:30 +01:00
Frédéric FRANCE
6dd6ab7906
fix phpstan ( #31614 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-10-29 17:40:56 +01:00
MDW
0d2f1cf666
Qual: Fix phpstan notices (int expected) ( #31485 )
...
# Qual: Fix phpstan notices (int expected)
Fix several notices where int was expected (casting/phpdoc/GETPOSTINT).
Separate phpstan exceptions for methods containing 'pdf' from
other methods/functions.
2024-10-24 14:01:30 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
000173c7b9
fix phpstan ( #31075 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-23 01:59:14 +02:00
Frédéric FRANCE
d12fd8d175
fix phpstan ( #30869 )
...
* fix phpstan
* fix phpstan
2024-09-06 13:50:27 +02:00
MDW
c496e84916
Qual: Fix phan issues related to getNextValue() notices ( #30747 )
...
* Qual: 🛟 Fix reference to $db with $this->db
# Qual: reference to $db with $this->db
$db was undeclared, use $this->db.
* Fix suspected issue with environment max size and md5sum working on limited files
* Qual: Fix LDAP typing
* Qual: Fix some phan typing related to getNextValue()
# Qual: Fix some phan typing related to getNextValue()
This fixes a few typings in relation to getNextValue().
* Update phan baseline
* PHPDoc: set arguments as nullable (+update array types)
* Improve PHPDoc
* Force toselect type to int[]
* Enable all phan notices on actions_massactions.inc.php
* Test was wrong, can not count when it's not an array
* Update baseline
* Remove ignore for notice that no longer exists
* Update baseline
* Fix format argument
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-29 15:01:42 +02:00
MDW
a8367a6cd8
Qual: Fix getNextValue related phan notices (part2) ( #30752 )
...
* Qual: 🛟 Fix reference to $db with $this->db
# Qual: reference to $db with $this->db
$db was undeclared, use $this->db.
* Fix suspected issue with environment max size and md5sum working on limited files
* Qual: Fix LDAP typing
* Qual: Fix getNextValue related phan notices (part2)
* Update baseline
* Qual: Fix phan notice
2024-08-29 13:34:24 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
Frédéric FRANCE
97392965e1
fix ignored phpstan ( #30645 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
2024-08-16 20:13:02 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 03:05:02 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Vincent de Grandpré
b0cd32bf68
NEW Implementing Billable tasks on projects using new attribute "billable" ( #30092 )
...
* Implementing Billable task function on projects using new attribute in #30014
* added billable to Task->initAsSpecimen()
* default billable to 1 in initAsSpecimen
* set billable to 1 in ProjectTest::testTaskCreate
* Moving attribut usage in usage_bill_time condition of project
* PPDoc
* fusion
* pre-commit + typo
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-07-03 03:29:05 +02:00
Frédéric FRANCE
3da9e53b03
Project phpdoc ( #30233 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
2024-07-02 01:46:40 +02:00
Frédéric FRANCE
f1302291de
fix phan emailcollector ( #30196 )
...
* fix phan emailcollector
* fix phpstan
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
2024-06-29 18:57:43 +02:00
Laurent Destailleur
cbb458486b
Debug v20
2024-06-06 09:27:25 +02:00
Lucas Marcouiller
678c76b80e
Fix merge time spent task ( #29834 )
...
* Fix time spent task
* Update task.class.php
---------
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-06-04 14:46:01 +02:00
Laurent Destailleur
3f13d944f5
Clean code
2024-06-03 19:19:52 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-05-05 00:34:19 +02:00
Laurent Destailleur
8db9b30fbb
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-04-27 04:07:00 +02:00
Can Arslan
74bc383fb0
FIX: TASK_CREATE Trigger ( #29483 )
...
TASK_CREATE Trigger should be called after insertExtraFields (like in TASK_MODIFY trigger) otherwise TASK_CREATE Trigger will be without projet_task_extrafields record
2024-04-27 03:59:37 +02:00
Laurent Destailleur
75103c251b
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-04-24 21:10:06 +02:00
Laurent Destailleur
090d079641
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-04-24 21:08:47 +02:00
Laurent Destailleur
0693fa9149
Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
2024-04-24 21:08:18 +02:00
Laurent Destailleur
07dedd3d2c
Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0
2024-04-24 21:06:46 +02:00
Laurent Destailleur
8d5dd565a6
Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0
2024-04-24 21:05:22 +02:00
Laurent Destailleur
7259195caf
Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 15.0
2024-04-24 21:04:48 +02:00
Laurent Destailleur
3723ae025f
Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 14.0
2024-04-24 21:01:44 +02:00
Laurent Destailleur
2d971f3a05
Fix regression
2024-04-24 21:00:38 +02:00
Can Arslan
a45b62b2d6
FIX: duplicate error check ( #29433 )
...
we are checking if there is an error on previous line
2024-04-24 15:17:44 +02:00
Eric
c8ef530d52
note_private and note_public was forgotten too ( #29440 )
...
* note_private and note_public was forgotten
* sql error missing comma
* sql error missing comma for rang=
2024-04-24 15:11:27 +02:00
Laurent Destailleur
d4b7332c76
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-04-22 14:24:14 +02:00
Laurent Destailleur
6303bceecd
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-04-22 14:19:59 +02:00
Laurent Destailleur
c454729f90
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
2024-04-22 14:19:30 +02:00
Laurent Destailleur
79353a6cbb
Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0
2024-04-22 14:17:06 +02:00
Laurent Destailleur
98fc0033f5
Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0
2024-04-22 14:16:37 +02:00
Laurent Destailleur
8e0369440f
Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 15.0
2024-04-22 14:16:18 +02:00
Laurent Destailleur
2768d80b9b
FIX Regression #29340
2024-04-14 03:15:49 +02:00
Laurent Destailleur
459ff72732
FIX Regression #29340
2024-04-14 02:56:17 +02:00
Eric
2a93168d48
object tasks: priority is fetch but not updated and others... ( #29340 )
...
* priority is fetch but not updated and others...
* insert too
2024-04-14 00:52:01 +02:00
Lucas Marcouiller
232800d776
NEW feature to merge 2 tasks ( #29214 )
...
* first push select not saved
* add working merge
* ass merge of contact for task
* fix typo
* add of merge timespent
* Fix integration error + use of good SelectTasks
* fix precommit
* Fix CI
* fix CI
* fix bad change
* fix to make merge only an update
* remove useless field update
* fix empty array
* fix CI
* fix unused code
---------
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
2024-04-08 20:50:16 +02:00
Laurent Destailleur
6ef81a05dc
typo
2024-04-04 19:13:12 +02:00
Laurent Destailleur
a2ec7400eb
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-03-28 10:55:44 +01:00
MDW
d245dab56b
Fix PhanTypeMismatchReturnNullable by setting variable
2024-03-20 21:58:36 +01:00
MDW
10b260a31d
Fix PhanTypeSuspiciousStringExpression
2024-03-19 02:44:02 +01:00
Laurent Destailleur
d3262ace71
Fix phpunit error due to regression in removing the $conf
2024-03-16 23:22:12 +01:00
MDW
38e7d389a9
Fix PhanTypeMismatchDefault by updating default to null
2024-03-15 14:53:05 +01:00
MDW
a408288ba1
Fix & enable PhanPluginUnknownClosureParamType
...
# Fix & enable PhanPluginUnknownClosureParamType
Typing of anonymous functions to fix this notice.
Optimised some minor things.
2024-03-14 22:42:26 +01:00
MDW
f4e1026e7d
Qual: Fix PHPdoc to match parent
2024-03-11 22:21:08 +01:00
