ldestailleur
f0eaae6a1d
Debug v22
2025-05-05 17:09:24 +02:00
ldestailleur
e4e5b1e597
Clean code
2025-05-05 02:22:02 +02:00
Florian Mortgat
9d0d8f7ec5
Fix/140/t250062/extrafields multicompany data loss ( #34022 )
...
* insertExtrafields(): simplify by returning 0 early if array_options is empty
* insertExtrafields(): simplify by using local variables $newValue and $attributeType
* insertExtrafields(): refactor by grouping the empty value cases for geodatabase-type extrafields
* insertExtrafields(): refactor by using a static mapping of geodata types to their ST_* db function on ExtraField class
* FIX: when an object that is shared across multiple entities already has some extrafields from another entity that are not reachable from the current entity, their values are lost
* Compliance with
- phan ( Closure Closure($key) has no declared or inferred parameter type for $key)
- php-stan (Error: Property ExtraFields::$geoDataTypes has no type specified)
2025-05-04 18:42:01 +02:00
ldestailleur
2aa17f9c3f
Fix update of foregin rate on recurring invoices
2025-04-25 03:39:04 +02:00
ThomasNgr-OpenDSI
a56a8e05f0
FIX : set default extrafield value for supplier order ( #33971 )
...
* fill extrafields default values in case THIRDPARTY_PROPAGATE_EXTRAFIELDS_TO_SUPPLIER_ORDER applies
* Fix: send param changecompany when changing company on a supplier order creation
2025-04-24 19:19:39 +02:00
ThomasNgr-OpenDSI
730667ed5a
NEW : force Extrafields values when constants THIRDPARTY_PROPAGATE_EXTRAFIELDS_TO_(ORDER|INVOICE) are set ( #33954 )
...
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-04-24 15:46:56 +02:00
Laurent Destailleur
e034b4b0ef
Standardize code
2025-04-24 00:51:47 +02:00
ldestailleur
4d80dc9d69
Debug v22
2025-04-12 16:18:40 +02:00
ldestailleur
6da74b90ce
Debug v22
2025-04-10 21:25:45 +02:00
ldestailleur
50b6281041
FIX #33353
2025-04-10 21:20:37 +02:00
ldestailleur
ee0c465421
Doc
2025-04-10 16:27:44 +02:00
Frédéric FRANCE
ac3364138d
fix sql ( #33754 )
...
if ref or ref_ext doen't exists in object (by example ref with llx_societe) sql will fails
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-04-07 16:37:08 +02:00
ThomasNgr-OpenDSI
b431b1bc90
FIX sales representatives can affect contacts from thirdparties they are not allowed to see ( #33353 )
...
* introduce method User::getAffectedThirdparties()
* Forbid to display thirdparties on contact tab is user has no right to see them
* add control in add_contacts
* fix precommit
* fix phan, phpstan
* fix travis + fix using wrong table
* Forbid to display thirdparties on contact tab is user has no right to see them (more secure way)
* try to fix TRAVIS
* more efficient way to check user is allowed to ad a socpeople
* remove dead code
2025-04-06 19:51:30 +02:00
ldestailleur
ef95c311a7
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-04-03 21:09:46 +02:00
VIAL-GOUTEYRON Quentin
3ad05c2dde
FIX: Incorrect entity used when downloading a document generated in another entity ( #33565 )
...
* FIX : Wrong entity to download document
* MODIFICATION : Remplacement de l'ID d'entité par l'objet dans les fonctions de gestion des fichiers pour une meilleure cohérence.
* Update files.lib.php
* Update files.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-04-01 23:13:31 +02:00
Etienne BENDER
d73df8d931
Add hook printObjectLinesList in CommonObject::printObjectLines() ( #33641 )
...
* Add hook printObjectLinesList in CommonObject::printObjectLines()
* Update commonobject.class.php
* Update commonobject.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-04-01 22:24:35 +02:00
ldestailleur
ffa7413cda
Clean code
2025-04-01 22:14:56 +02:00
Frédéric FRANCE
387e3b1da7
shipping can manage its contacts ( #33680 )
...
* shipping can manage its contacts
* shipping can manage its contacts
* fix
* add contacts from origin
* clean code
* apply changes
* apply changes
2025-04-01 20:47:40 +02:00
ldestailleur
1325b249b0
Clean code to fix some phan warnings
2025-04-01 09:36:36 +02:00
ldestailleur
ca1afd6535
Clean code
2025-03-31 12:39:19 +02:00
ldestailleur
ae59c409f6
Modulebuilderization
2025-03-26 00:56:24 +01:00
ldestailleur
507262a1a8
Test fix CI
2025-03-25 22:27:52 +01:00
ldestailleur
e1351bdd18
FIX Translation of column in list of invoice
2025-03-24 12:54:32 +01:00
ldestailleur
911bfa2883
FIX Translation of column in list of invoice
2025-03-24 12:49:46 +01:00
Nicolas Domenech
3d1276fa41
Fix: PHP8 warning on showOutputField for various type ( #33556 )
2025-03-21 00:36:35 +01:00
Laurent Destailleur
395157d16c
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-03-17 19:46:08 +01:00
ldestailleur
23244ddc9d
Fix getCallerInfoString() return empty when only one function used
2025-03-17 11:33:06 +01:00
ldestailleur
e863b1f01a
Add info to help debug several troubles
2025-03-17 10:55:13 +01:00
MDW
c3104905b3
Qual: Fix phan notices (html/core) ( #33474 )
...
* FIX: Replace compromised tj-actions/changed-files
# FIX: Replace compromised tj-actions/changed-files
See https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised .
* Add changed php file for test
* Qual: Fix phan notices (html/core)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-03-15 16:34:35 +01:00
atm-irvine
e417e0e8f6
fix(insertExtraFields): removed useless fetch product for a SQL request ( #33460 )
...
* fix(insertExtraFields): removed useless fetch product for a SQL for better perf
* Returns of PR
2025-03-15 11:20:48 +01:00
Yannis Hoareau
9bf2b187f9
Fix fatal error occuring if fk_parent_line set to false ( #33412 )
2025-03-12 19:23:56 +01:00
ldestailleur
d20e730c66
Clean code
2025-03-06 04:56:54 +01:00
MDW
acf6b62822
Fix PhanTypeMismatchArgument in commonobject, commande/card,
2025-03-05 12:15:12 +01:00
Frédéric France
f7a4ce3b5f
fix phpstan
2025-03-01 11:04:07 +01:00
ldestailleur
10fd8b2111
Clean code
2025-02-24 16:16:26 +01:00
ldestailleur
abcd0d2cf2
Qual: Clean code related to categories
2025-02-23 19:42:49 +01:00
Laurent Destailleur
4a1199a00e
Merge pull request #31419 from frederic34/extrafields_object_filter
...
can filter on object properties
2025-02-19 18:33:03 +01:00
ldestailleur
dd726641c7
Clean code
2025-02-19 17:32:11 +01:00
Laurent Destailleur
65cd5351a8
Merge pull request #33108 from mdeweerd/phan/fix.2025.2.17
...
Qual: Fix phan notices (stripe, supplier_proposal)
2025-02-18 20:38:12 +01:00
Frédéric FRANCE
d11a8884f6
Merge branch 'develop' into extrafields_object_filter
2025-02-18 19:44:50 +01:00
ldestailleur
12848fcdd5
Avoid fatal error if hookmanager not defined
2025-02-18 16:25:51 +01:00
MDW
11ed394b4b
Qual: Fix phan notices (supplier_proposal)
2025-02-18 14:16:49 +01:00
ldestailleur
7fc8136362
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-02-16 14:50:09 +01:00
ldestailleur
415c38ed6b
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
2025-02-16 14:32:33 +01:00
ldestailleur
cb18bebb87
Fix warning on date
2025-02-16 14:23:16 +01:00
Laurent Destailleur (aka Eldy)
eeb8907f33
Fix missing properties
2025-02-14 02:09:59 +01:00
Laurent Destailleur (aka Eldy)
c3aaa6a510
Clean code
2025-02-13 15:22:03 +01:00
Laurent Destailleur (aka Eldy)
62e441ad3d
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-02-12 22:51:21 +01:00
Laurent Destailleur (aka Eldy)
964bbfa982
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
2025-02-12 22:43:31 +01:00
Laurent Destailleur (aka Eldy)
0ef79d47d8
Fix warning
2025-02-12 22:43:01 +01:00