Commit Graph

33 Commits

Author SHA1 Message Date
MDW
8669993ecf Qual: Fix phan notices (compta/prel..fichinter) (#33485)
* Qual: Fix phan notices (asset..compta/paiement)

* Qual: Fix phan notices (compta/prel..fichinter)
2025-03-19 15:21:48 +01:00
MDW
c3104905b3 Qual: Fix phan notices (html/core) (#33474)
* FIX: Replace compromised tj-actions/changed-files

# FIX: Replace compromised tj-actions/changed-files

See https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised .

* Add changed php file for test

* Qual: Fix phan notices (html/core)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-03-15 16:34:35 +01:00
MDW
67e9eaff46 Qual: Fix phan/phpstan notices in class files (part 2) (#31523)
* Qual: Fix phan notices in class files (part 2)

* Qual: Fix phan notices doleditor...events.class

* Qual: Fix phan notices defaultvalues...formprojet.class

* Qual: Fix notices formsetup...formwebsite.class

* Qual: Fix phan notices in class files (part 2)

* Qual: Fix phan notices doleditor...events.class

* Qual: Fix phan notices defaultvalues...formprojet.class

* Qual: Fix notices formsetup...formwebsite.class
2024-10-26 18:24:40 +02:00
MDW
46eb5f83c2 Qual: Updates for phpstan notices (#30509)
* Fix int<0> typing to int<0,0> for phpstan

* Fix phpdoc for phpstan

* Fix phpdoc for phpstan

* Qual: Several phpstan notice fixes

* Fix phpdoc

* Qual: totalpaid is never null, remove null test

* improve phpdoc typing

* Also return null to statisfy phpstan

* Allow null value for $var

* object->Object to make it meaningful

* Type EvalMathStack properties

* Comment out unused private methods (phpstan)

* Changes for phpstan (return values, phpdoc, code)

* Change order of tests for phpstan

* phpdoc object to Object for correct typing

* Typing hing for phpstan

* UPdate test for phpstan

* Change phpdoc position for phpstan

* Update phpdoc for phpstan

This needs further improvement

* Change $op to $ope to fix phpstan

* Update sqlite3.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-01 12:59:45 +02:00
Laurent Destailleur
04d213e676 Doxygen 2024-07-31 13:24:23 +02:00
Frédéric FRANCE
4372f329b8 phpstan ignore unused method in evalmath.class.php (#30048) 2024-06-16 12:56:42 +02:00
MDW
78f2e8752e Fix PhanPluginUnsafeEval by ignoring notification 2024-03-17 20:12:33 +01:00
MDW
3384a0b847 Fix & enable PhanUndeclaredTypeReturnType
# Fix & enable PhanUndeclaredTypeReturnType

One typo, and replace 'number' with int or int|float
2024-03-15 10:07:15 +01:00
thibdrev
bda7cee900 qual: phpstan for htdocs/core/class/evalmath.class.php
htdocs/core/class/evalmath.class.php	389	Method EvalMath::pfx() should return string but returns bool.
htdocs/core/class/evalmath.class.php	392	Method EvalMath::pfx() should return string but returns bool.
htdocs/core/class/evalmath.class.php	406	Method EvalMath::pfx() should return string but returns bool.
htdocs/core/class/evalmath.class.php	422	Method EvalMath::pfx() should return string but returns bool.
htdocs/core/class/evalmath.class.php	434	Method EvalMath::pfx() should return string but returns bool.
htdocs/core/class/evalmath.class.php	448	Method EvalMath::pfx() should return string but returns bool.
htdocs/core/class/evalmath.class.php	454	Method EvalMath::pfx() should return string but returns bool.
2024-01-31 13:28:44 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491)
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
Laurent Destailleur
54e6de0d7f Fix with php-cs-fixer 2023-12-04 12:04:36 +01:00
Laurent Destailleur
e2ec34e1e5 Clean code 2023-05-01 14:33:08 +02:00
Laurent Destailleur
b3b0fe2444 Clean code 2023-01-06 20:12:58 +01:00
Laurent Destailleur
27792fe1ad Fix qodana 2023-01-04 18:34:54 +01:00
Frédéric FRANCE
2f60b5f847 add ceil in evalmath 2022-10-27 10:29:18 +02:00
Laurent Destailleur
6fb1e126c5 Merge pull request #21245 from Quatadah/dolicloud-qnasdami-scrutinizer-003
BUG FIX : Changing type of the parameter
2022-06-29 10:30:49 +02:00
Quatadah Nasdami
92e9b550cd removing one empty line 2022-06-23 17:56:17 +02:00
Laurent Destailleur
ca6d47aba0 Merge pull request #21247 from Quatadah/dolicloud-qnasdami-scrutinizer-004
BUG FIX: evaluate() doesn't cover the case where $expr is empty
2022-06-17 15:28:50 +02:00
NASDAMI Quatadah
5b93c103a3 evaluate function checks if is empty + unit test 2022-06-15 15:18:37 +02:00
Quatadah Nasdami
821a5a833a Merge branch 'develop' into dolicloud-qnasdami-scrutinizer-003 2022-06-15 11:00:57 +02:00
Laurent Destailleur
ac3d3528ff Doc 2022-06-14 18:19:02 +02:00
NASDAMI Quatadah
f5b3890721 BUG FIX: checking if array is empty with empty() function instead of comparing it to a boolean 2022-06-13 15:47:31 +02:00
NASDAMI Quatadah
8729b9f2dd array instead of string in @param pfx() function 2022-06-13 13:34:18 +02:00
Frédéric FRANCE
554e449e40 code syntax core directory 2021-02-23 22:03:23 +01:00
Scrutinizer Auto-Fixer
7f52920716 Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-10-31 13:32:18 +00:00
Laurent Destailleur
fd617658ef Fix syntax 2020-07-03 00:36:56 +02:00
Je2fb
b45bfd258d fix #14143 2020-07-03 00:34:50 +02:00
Scrutinizer Auto-Fixer
444c293c01 Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-04-10 08:59:32 +00:00
Laurent Destailleur
99669583d5 Fix phpcs 2020-03-13 16:46:07 +01:00
Laurent Destailleur
d90bf25351 Fix phpcs 2020-03-13 13:11:04 +01:00
Laurent Destailleur
893ae21d3a Fix phpcs 2020-03-13 11:29:27 +01:00
Laurent Destailleur
6dda972ff5 Doxygen 2020-03-13 04:12:42 +01:00
Laurent Destailleur
94589158c0 Move class from external project as internal class (project is dead) 2020-03-13 02:32:33 +01:00