Commit Graph

8199 Commits

Author SHA1 Message Date
MDW
3d130e3bd5 Fix double $conf->global->$conf into $conf->global->...
# Fix double $conf->global->$conf into $conf->global->...

Found with PhanTypeInvalidPropertyName - may be appropriate for backport
2024-03-23 15:17:12 +01:00
Laurent Destailleur
d448b57cf2 Debug v20 2024-03-22 19:58:33 +01:00
Laurent Destailleur
922f30eceb Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-03-21 15:38:11 +01:00
Laurent Destailleur
61eefe5fa9 Merge branch 'develop' into fix/PhanTypeMismatchReturnNullable 2024-03-21 12:51:27 +01:00
Laurent Destailleur
ae10eedf2a Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-21 11:29:16 +01:00
Laurent Destailleur
57eb393dad Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-21 11:22:28 +01:00
MDW
2496d20d4f Fix nullable return with if($ok == 1) in stead of if($ok)
# Fix nullable return with if($ok == 1) in stead of if($ok)

This seems to be a bug in Phan where if($ok) changes the type of $ok.
Testing with '$ok == 1' instead fixes the issue.

This has been reported to the phan team.
2024-03-21 00:28:14 +01:00
MDW
942239b5d6 Update PHPdoc to show nullable return 2024-03-20 23:54:32 +01:00
MDW
9ecb4bd639 Fix null return by returning empty string in else case 2024-03-20 21:58:47 +01:00
MDW
e105b577ee Fix PhanTypeMismatchReturn by changing return and logging error 2024-03-20 21:58:39 +01:00
Kamel Khelifa
9e7aeca447 FIX: Fix save directory for invoice ODT and multientities 2024-03-20 15:26:19 +01:00
Laurent Destailleur
cb3880cc62 Clean translations 2024-03-20 15:15:28 +01:00
Laurent Destailleur
96bca35d43 Merge pull request #28972 from mdeweerd/fix/PhanTypeMismatchInternal4
Fix PhanTypeMismatchInternal notifications (part 4)
2024-03-20 01:00:45 +01:00
MDW
de13b93e43 Fix arg type to preg_match(),str_replace() with casts 2024-03-19 22:52:37 +01:00
MDW
4262637a5e Fix arg type to preg_match(),str_replace() with casts 2024-03-19 22:52:36 +01:00
MDW
e74c473e72 Fix arg type to preg_match(),str_replace() with casts 2024-03-19 22:52:35 +01:00
MDW
439c32237c Fix arg type to preg_match() with cast 2024-03-19 22:52:34 +01:00
MDW
0590395119 Fix arg type to preg_match() with cast 2024-03-19 22:52:33 +01:00
MDW
72e3522ac5 Fix arg type to abs() with casts 2024-03-19 22:52:33 +01:00
MDW
b8fca80953 Fix arg type to preg_match(),str_replace() with casts 2024-03-19 22:52:32 +01:00
MDW
873db9b477 Fix arg type to preg_match(),str_replace() with casts 2024-03-19 22:52:31 +01:00
MDW
b9f03d7704 Fix arg type to strlen() with cast, improve conversion to int 2024-03-19 22:52:30 +01:00
MDW
bd2f8e0255 Fix arg type to str_replace() with casts 2024-03-19 22:52:29 +01:00
MDW
4dc6b98766 Fix arg type to str_replace() with casts 2024-03-19 22:52:28 +01:00
MDW
20943dc8c2 Fix arg type to str_replace() and preg_match() with casts 2024-03-19 22:52:27 +01:00
MDW
afff9695c3 Fix arg type to str_replace() and preg_match() with casts 2024-03-19 22:52:26 +01:00
Laurent Destailleur
5d073ac208 Fix hasRights into hasRight 2024-03-19 22:02:42 +01:00
Christophe Battarel
e3a5977274 Merge branch 'develop' into rdb4 2024-03-19 15:58:40 +01:00
Christophe Battarel
446b574de5 renaming of columns impact db access 2024-03-19 15:49:42 +01:00
MDW
750ffdc9d2 Fix args to substr by casting (value from user setting) 2024-03-19 02:59:21 +01:00
MDW
cde95b3037 Fix bad typing in thirdparty lib (TCPDF) with cast 2024-03-19 02:59:20 +01:00
MDW
b683ad4b66 Fix $labelToUse 2024-03-19 02:43:25 +01:00
Laurent Destailleur
ebba438fbe Merge pull request #27528 from altairisfr/rdb
[DATA_MODEL] rename commande_fournisseur_dispatch into receptiondet_batch
2024-03-17 21:31:27 +01:00
MDW
012f284b3d Fix PhanParamSuspiciousOrder by suppressing notification 2024-03-17 20:12:53 +01:00
Laurent Destailleur
7aef2022d6 Merge pull request #28026 from ariel-bentu/fix-pdf-lines-header-height
QUAL fix lines' title height calculation
2024-03-17 12:38:59 +01:00
Laurent Destailleur
1b9db96e4f Fix picto 2024-03-17 00:35:06 +01:00
Laurent Destailleur
75fae0f27d Merge branch 'develop' into fix/PhanTypeMismatchReturn 2024-03-16 16:08:08 +01:00
MDW
9eed23c6d0 Fix return type by cast or typing update
# Fix return type by cast or typing update

Fix most PhanTypeMismatchReturn notifications.

The remaining ones are likely real bugs or need more Dolibarr
knowledge to fix them efficiently
2024-03-16 13:52:12 +01:00
MDW
13ab939691 Fix deprecated function calls 2024-03-16 13:27:51 +01:00
Laurent Destailleur
e994d6650f Fix regression in GETPOST limit 2024-03-16 11:41:00 +01:00
Laurent Destailleur
25dd05c35e Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-16 10:45:55 +01:00
Frédéric France
41fccbaac5 fix phpstan warnings 2024-03-16 08:49:50 +01:00
Laurent Destailleur
79aa9fb1f1 Code simpler 2024-03-15 20:29:21 +01:00
Laurent Destailleur
372c8445fd Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak
Fix & enable PhanPluginPrintfIncompatibleArgumentTypeWeak occurrences
2024-03-15 16:32:40 +01:00
Laurent Destailleur
0ee6fd6bad Merge pull request #28877 from mdeweerd/PhanTypeMismatchDefault
Fix & enable PhanTypeMismatchDefault
2024-03-15 15:44:30 +01:00
Laurent Destailleur
7d585f2a48 Merge pull request #28839 from lamrani002/fixTypagePAram
FIX PHPStan warnings
2024-03-15 15:25:51 +01:00
Lamrani Abdel
d9694bec3d fix type by adding both to doc function 2024-03-15 14:38:22 +01:00
Lamrani Abdel
4a53b3dd17 fix type by adding both to doc function 2024-03-15 14:37:35 +01:00
MDW
920e1fbe77 Fix PhanTypeMismatchDefault by removing defaults ($object is required) 2024-03-15 14:29:21 +01:00
MDW
972028bb95 Fix PhanTypeMismatchDefault by removing defaults ($object is required) 2024-03-15 14:29:20 +01:00