Commit Graph

3221 Commits

Author SHA1 Message Date
Laurent Destailleur
70c6ce9bfb Enhance error catching on dol_eval 2023-02-04 15:21:32 +01:00
Rept0id
3cc415af47 Updated function dol_eval, added error handling
- There were cases that dol_eval() would break the whole system.

-That was happening in case of using a new version plugin on an old version dolibarr. New plugin validates through isModActive() instead of $conf->moduleName->enabled. Even if you were deactivating the plugin, or totally delete it, the records were still on database for menu, so there were no obvious solution. This update adds a backwards compatibility, makes doli more stable and counterparts the use of eval, making it more safe.

- Use of eval is not bad, as well there are techniques in any project that are project-related useful and smart. For example, Linux kernel uses GOTO. But in such cases, there needs to be a safety net.

-I found out this after a lot of trouble, I hope this small fix will save other developers.

👍
2023-02-04 15:17:51 +01:00
Laurent Destailleur
53b64feb7b Merge pull request #23760 from rept0id/develop
Fix : Updated function dol_eval, added error handling
2023-02-04 15:16:38 +01:00
Laurent Destailleur
1f195a3be5 Fix #yogosha14963 2023-02-04 14:04:25 +01:00
Rept0id
fb655a0b0a Updated function dol_eval, added error handling
- There were cases that dol_eval() would break the whole system.

-That was happening in case of using a new version plugin on an old version dolibarr. New plugin validates through isModActive() instead of $conf->moduleName->enabled. Even if you were deactivating the plugin, or totally delete it, the records were still on database for menu, so there were no obvious solution. This update adds a backwards compatibility, makes doli more stable and counterparts the use of eval, making it more safe.

- Use of eval is not bad, as well there are techniques in any project that are project-related useful and smart. For example, Linux kernel uses GOTO. But in such cases, there needs to be a safety net.

-I found out this after a lot of trouble, I hope this small fix will save other developers.

👍
2023-02-02 16:50:50 +02:00
Laurent Destailleur
a6f6192d78 Fix warnings 2023-02-01 11:20:52 +01:00
Laurent Destailleur
9fb08b5a0a Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-01-31 21:28:59 +01:00
Laurent Destailleur
36cf05318b Debug v17 2023-01-31 21:17:06 +01:00
Laurent Destailleur
a6daba61ce Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-01-26 02:32:08 +01:00
Laurent Destailleur
dbfa172e19 Debug view of thumbs for svg 2023-01-25 17:39:21 +01:00
Laurent Destailleur
faa44379e8 Debug view of thumbs for svg 2023-01-25 17:38:04 +01:00
Laurent Destailleur
5429882147 Debug v17 2023-01-24 18:23:46 +01:00
Laurent Destailleur
5b5a3547e2 Debug v17 2023-01-24 13:00:09 +01:00
Laurent Destailleur
1513c46c77 Doxygen 2023-01-22 19:25:37 +01:00
Laurent Destailleur
f7302232df Fix rounding 2023-01-20 19:34:26 +01:00
Laurent Destailleur
7668233d0c NEW Tooltip to explain how to add a photo on product 2023-01-17 10:22:23 +01:00
Laurent Destailleur
bd8a48b6dd css 2023-01-15 01:45:54 +01:00
Laurent Destailleur
97061a9a92 NEW Use a cache file for external RSS in calendar 2023-01-13 17:17:23 +01:00
Laurent Destailleur
8eb89e0ad1 Remove merged feature with too many pb:
1=Not yet implemented everywhere.
2=Seems a duplicate info with the picto warning when late (so in past
not done)
3=Is also a duplicate with the existing css event-future, event-past,
event-current
4=It overwrites to choice done by the theme
5=Implementation is wrong, it must use css and not #background

Use CSS instead
2023-01-13 12:14:20 +01:00
Laurent Destailleur
8ced29cb00 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-01-11 21:32:41 +01:00
Laurent Destailleur
4f350d878c Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2023-01-11 21:07:43 +01:00
Laurent Destailleur
2da8c1d9bc Fix rounding 2023-01-10 11:33:17 +01:00
atm-florian
36c51de284 Merge branch 'develop' of github.com:Dolibarr/dolibarr into NEW_18_helper_functions_for_dates 2023-01-10 11:06:29 +01:00
Laurent Destailleur
2f3d87f27a Add option MAIN_SALETAX_AUTOSWITCH_I_CS_FOR_INDIA for India 2023-01-09 13:44:29 +01:00
Laurent Destailleur
7ca337cf8b Add option MAIN_SALETAX_AUTOSWITCH_I_CS_FOR_INDIA for India 2023-01-09 13:40:02 +01:00
Laurent Destailleur
de681fee07 Comment in english 2023-01-09 13:07:55 +01:00
Laurent Destailleur
75d9793145 Fix virtual card feature 2023-01-07 14:34:30 +01:00
Laurent Destailleur
00740ca267 WIP Work on public virtual card 2023-01-07 04:42:24 +01:00
Laurent Destailleur
37528e6544 Add CRC to currency with symbol before amount 2023-01-04 09:43:26 +01:00
Laurent Destailleur
4ea81b4a96 Fix syntax error 2023-01-04 09:42:39 +01:00
Laurent Destailleur
23865e5a4b Merge pull request #23325 from randallmoraes/patch-6
NEW Add CRC for currency symbol before amount
2023-01-04 08:35:39 +01:00
Laurent Destailleur
ee564ac3bb Merge pull request #23391 from JavierNR/feature/intervention_url
NEW create email substitution variable __ONLINE_SIGN_FICHINTER_URL__
2023-01-04 08:22:14 +01:00
Laurent Destailleur
67144020c6 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-01-02 20:24:13 +01:00
Laurent Destailleur
d62fb2af64 css 2023-01-02 20:15:34 +01:00
Javier Núñez
4ddf0b27dc NEW create email substitution variable for intervention signature URL 2023-01-02 18:15:33 +01:00
Laurent Destailleur
2970f039dd Fix warning 2022-12-31 16:52:23 +01:00
Laurent Destailleur
65a2093cd1 Fix regression 2022-12-31 16:50:30 +01:00
Laurent Destailleur
8774f4f092 Fix warning qodana 2022-12-31 13:44:11 +01:00
Laurent Destailleur
c593d990e4 Clean deprecated code for adodbtime 2022-12-30 18:55:10 +01:00
Laurent Destailleur
24e3e278ed Fix warning 2022-12-30 14:24:39 +01:00
Laurent Destailleur
e8ea213503 Fix warning 2022-12-30 13:51:58 +01:00
Laurent Destailleur
9d777497db NEW dol_sort_array can sort on alphabetical order even if val is num 2022-12-29 22:07:26 +01:00
Laurent Destailleur
5997b916d8 Enhance qodana rules 2022-12-28 03:50:19 +01:00
Laurent Destailleur
a4c1ae1b82 Fix permission 2022-12-27 11:54:11 +01:00
Laurent Destailleur
886baf6aa2 Fix permission 2022-12-27 01:41:20 +01:00
Laurent Destailleur
7c7f0a3322 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2022-12-26 23:59:45 +01:00
Laurent Destailleur
5a26eadfea Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2022-12-26 23:59:19 +01:00
Laurent Destailleur
08b81203f0 Debug v17 2022-12-26 13:55:29 +01:00
Laurent Destailleur
1368128743 Debug v17 2022-12-26 13:00:22 +01:00
Randall Mora
92d9d31b8c Update functions.lib.php
Agrega el tipo de moneda CRC (colones Costa Rica) para que se muestre al incio como simbolo de moneda.
Adds the CRC currency (Costa Rican colones) so that it is displayed at the beginning as a currency symbol.
2022-12-23 13:18:04 -06:00