Fix PhanPluginPrintfNotPercent by setting format length to non 0 value.
Example of Notification message:
'Format string "%0.10F" contains something that is not a percent sign, it will be treated as a format string '%0.10F' with padding of "0" and alignment of '' but no width. Use %% for a literal percent sign, or '%1$.10F' to be less ambiguous' .
# Fix PhanPluginUnknownFunctionParamType
PHPdoc for $object was incorrect.
Also updated the return type and the parameter typing for $head
in complete_head_from_modules
# FIX get_string_between
Noticed that the typing of the arguments was incorrect and then found
the implementation suspicious. The implemented test confirmed that it
was flawed. Fixed.
Apparently this method is used in get_next_value .
# Fix: Duplicate test on "shipping", replaced duplicate with delivery_note
The second test on "shipping" was without effect but as the module was set to
"expedition_bon", I modified the test to delivery_note and put it closer to
the test on "shipping"
When you set FCKEDITOR_ENABLE_DETAILS_FULL to 1 you can add pictures in description proposal with the WYSIWYG bar.
Add preg_replace() to show this pictures in the PDF
# Fix: PhanTypeMismatchDeclaredParamNullable notices
PHPDoc must indicate param is nullable if the default is null
with explicit typing.
(+Improved some other typing from generic Object to CommonObject).
* FIX: online signature (#28608) Update signature.lib.php
If Commercial proposal numbering contains a mask that’s includes a space, that will affect the result of the online signature form. When generating the online signature form, the code in signature.lib.php line 77, will remove any existing space in the Commercial proposal numbering. The result is that the online signature form will miss data in field “Third-party” and “Amount”.
* FIX: online signature (#28608) Update payments.lib.php
If Commercial proposal numbering contains a mask that’s includes a space, that will affect the result of the online signature form. When generating the online signature form, the code in core/lib/payments.lib.ph, will remove any existing space in the Commercial proposal numbering.
