Commit Graph

14120 Commits

Author SHA1 Message Date
William Mead
72aec91064 NEW shipment signed status update (#30928)
* Added event message

* Added CommonSignedObject trait. Updated LibStatut method. Removed unnecessary properties.

* Added SHIPPING_MODIFY notification

* Refactored to use setSignedStatus method

* Updated PHPDoc. Removed unnecessary properties. Added contributor details.

* Added signed status to shipping list

* Added signed status to fetch method

* Fixed type

* Added signed status to notification message

* Updated EN localization

* Fixed static property

* Added event message localization

* Updated EN localization

* Updated PHPDoc

* Added signed status for use in tooltip

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:09:53 +02:00
MDW
f89245b354 Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00
Laurent Destailleur
1f33c81038 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 22:06:18 +02:00
Laurent Destailleur
6a15df3a52 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-12 22:01:08 +02:00
Laurent Destailleur
5b4c404957 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-09-12 21:59:59 +02:00
Laurent Destailleur
1b24270a46 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-09-12 21:59:42 +02:00
Laurent Destailleur
65e5899442 Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2024-09-12 21:58:28 +02:00
Marc de Lima Lucio
d17890f05b FIX: purge files cron: php warnings when rest module enabled (#30919) 2024-09-12 21:57:41 +02:00
Lucas Marcouiller
ef2ec011f5 Fix #30828 bad save of contract id in ticket card (#30916)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-09-12 21:34:28 +02:00
MDW
76eaf8bd8d Qual: Fix phan notices in classes related to class using getNextValue. (#30925)
* FIX 🛟 phan

* getToolTip() can take null for $coc

* Fix uninitialized vars & arg types

* PHPDoc typing, argument fixes

* PHPDoc typing, argument fixes for AdherentType

* PHPDoc typing, argument fixes for AdherentStats

* Update baseline to enable adherent notices

* Fix PHPDoc typing in api_members

* Minor bug fixes, typing

* PHPDoc api_subscriptions

* PHPDoc Societe

* Ignore empty foreach notice

* Add initialiser

* Categorie is string, old int mode is deprecated

* Fix missing initialisations

* Fix missing initialisations adherents/note

* Fix typing (cast), initialisation of var

* Fix initialisations

* Fix argument types

* Improve array PHPDoc type

* PHPDoc array type

* PHPDoc: Improve typing

* Correct argument type to getNomUrl

* Improve typing for timespent

* Fix typing for getNextValue args

* Improve typing

* Fix typing hints contrat/card

* Update baseline

* Fix typing

* Fix extraparams property typing

* Fix argument typing

* Qual: Correct covariant type

* Impove typing for timespent

* Remove exclusion no longer matched (level 6)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-09-12 21:16:42 +02:00
Laurent Destailleur
1a651ad80b Implement a TODO for possible perf enhancement. 2024-09-11 14:55:57 +02:00
CODE42 FR
d76f689bc2 [#29371] Fixed : Php wanring on separate type extra field update (#30910)
Co-authored-by: TREBUCHET <ravi@code42.fr>
2024-09-10 16:39:11 +02:00
CODE42 FR
c4a19f4022 [#29371] Fixed : Php wanring on separate type extra field update (#30910)
Co-authored-by: TREBUCHET <ravi@code42.fr>
2024-09-10 16:38:33 +02:00
William Mead
d0c96c99e0 Qual common signed object trait (#30913)
* Moved signed status properties & methods to reusable class trait

* Cleaned code

* Updated EN localization

* Fixed Phan warnings

* Fixed Phan warnings

* Added type check. Updated PHPDoc.

* Refactored class properties

* Cleaned PHPDoc

* Revert "Refactored class properties"

This reverts commit 1beb40a7

* Reapply "Refactored class properties"

This reverts commit 9e3d9d554c.

* Fixed PHPDoc

* Fixed class file name
2024-09-10 16:22:25 +02:00
Laurent Destailleur
e847c072a2 Debug v20 2024-09-10 11:25:28 +02:00
Laurent Destailleur
9eb61af370 Debug v20 2024-09-10 11:24:55 +02:00
William Mead
fb6677010d NEW contract signed status update (#30779)
* Moved signed status constants to array dictionary

* Added getLibSignedStatus & getSignedStatusLocalisedArray methods

* Updated fetch & create methods for signed_status

* Added signed status to status badge

* Updated signed_status module builder field

* Added object context signed status for action trigger

* Added signed status to contract list

* Fixed signed status for contract list

* Added sign, unsign, confirm_sign, confirm_unsign actions. Added sign button.

* Fixed old contract without signed status

* Added contract modify notification

* Added contract signed status update

* Updated EN localizations

* Fixed contract notification administration

* Fixed notification message

* Fixed contract status badge

* Fixed langs

* Fixed langs key

* Fixed duplicate localization
2024-09-10 03:04:49 +02:00
Laurent Destailleur
fc1b4c9697 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-09-10 02:14:08 +02:00
MDW
506454b10a Qual: Resolve ~200 phan notices/~100 phpstan notices (#30879)
* bookkeeping\card.php, productaccount

* Fix bookkeeping/listbyaccount

* Typing for accountancycategory

* Fix typing accountancyimport

* Typing accountingaccount

* Typing api_accountancy

* bookkeeping typing

* Fix typing lettering

* Typing for accountancy/customer/list

* Typing accountancy/journal/bankjournal

* typing accountancy/journal/variousjournal

* Typing accountancy/supplier/list

* Initialisations in accountancy/journal/expensereportsjournal

* Initialisations in accountancy/journal/purchasesjournal

* Initialisations in accountancy/journal/sellsjournal

* Update baseline
2024-09-10 02:11:53 +02:00
kkhelifa-opendsi
d29ebee2ac FIX avoid from re-initializing array result on nested hook getEntity (#30626) 2024-09-09 04:35:13 +02:00
Laurent Destailleur
96cdb50886 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-09 03:54:14 +02:00
Laurent Destailleur
9f693ea049 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-09 03:53:42 +02:00
Laurent Destailleur
3e9a0cfa99 Debug v20 2024-09-09 03:52:25 +02:00
MDW
32732d37d2 Qual: Improve typing in Export class (#30859)
* Update baseline

* Qual: Improve typing in Export class

* Add 'abstract' methods to help with typing

* Add some typing

* Improve typing in export modules

* Improve typing for AccountancyExport

* Qual: PHPDoc executeCLI (nullable arguments, range)

* PHPDoc for export function

* Fix $permissiontoClose -> $permissiontoclose

* PHPDoc - Improve AccountingJournal typing

* Improve export_journal tpl typing

* Improve html.formsetup typing

* Impove commonfieldsexport typing

* Improve extrafieldsinexport typing

* Fix typing, initialisation

* Fix typing intracommreport

* Ensure string in $error for CronJob
2024-09-09 03:15:26 +02:00
Laurent Destailleur
e003c6a516 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-07 02:20:15 +02:00
Laurent Destailleur
b1b1491299 Debug the numbering module of tasks. Secodn param must be Project. 2024-09-06 15:38:52 +02:00
Frédéric FRANCE
80999f9a61 fix phpstan (#30871)
* fix phpstan

* fix phpstan
2024-09-06 13:47:24 +02:00
Frédéric FRANCE
eb04c5c427 fix phpstan (#30860)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-06 13:44:29 +02:00
Laurent Destailleur
c972f44dc2 Debug v20 - Fix mandatory fields 2024-09-06 02:59:21 +02:00
Laurent Destailleur
40f0173678 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-09-05 22:44:57 +02:00
Laurent Destailleur
07546f4d7e Debug v20 2024-09-05 18:10:24 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
c98273fed1 Fix phan error; Currently getExample has different signature defined
into parents
2024-09-03 17:59:06 +02:00
Laurent Destailleur
f23ff1867a Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-03 17:52:25 +02:00
Laurent Destailleur
d2608dfb08 Fix type 2024-09-03 17:50:36 +02:00
Laurent Destailleur
14d5b4bcc3 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-02 12:14:51 +02:00
Laurent Destailleur
aa096719b2 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-02 11:18:06 +02:00
atm-lucas
c3e6df4d91 FIX - Substitution error in ticket emails in the subject (#30778)
* fix missing substitutions

* test on ->substit
2024-09-01 14:55:59 +02:00
Laurent Destailleur
8d786cb73a Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-01 14:35:58 +02:00
Laurent Destailleur
3f9b2d9d57 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-01 14:15:57 +02:00
John BOTELLA
079f6487fd Fix : php 8 warnings v19.0 (#30799)
* fix php8 err

* Fix php 8

* fix missing precommit hooks

* Update htdocs/commande/list.php

* Update htdocs/commande/list.php
2024-08-31 19:42:15 +02:00
Laurent Destailleur
4904eea6ce Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-31 18:19:06 +02:00
Laurent Destailleur
79b1a293e9 Fix barcode for virtual card must not pass content on get url. 2024-08-31 18:18:45 +02:00
MDW
a8367a6cd8 Qual: Fix getNextValue related phan notices (part2) (#30752)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Fix getNextValue related phan notices (part2)

* Update baseline

* Qual: Fix phan notice
2024-08-29 13:34:24 +02:00
Lucas Marcouiller
2662725819 Fix select with text area and generalisation for update (#30794)
* Fix select with text area and generalisation for update

* fix CI

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-08-29 13:32:06 +02:00
Frédéric FRANCE
5947bea924 🛟 fix phpstan (#30793) 2024-08-29 13:28:49 +02:00
Lucas Marcouiller
94b3566ddc fix textarea with select by adding a button (#30785)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-08-29 09:27:42 +02:00
William Mead
8bbe0516f4 Fix ticket category html form warnings (#30773)
* Fixed undefined properties

* Added contributor details
2024-08-29 09:26:00 +02:00
MDW
00e2ed5529 Qual: 🛟 Fix CI Issues ($db to $this->db / LDAP typing / Win-ci cache md5sum) (#30774)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Qual: Fix LDAP typing

* Fix suspected issue with environment max size and md5sum working on limited files

* Correct typing hint for email_date
2024-08-29 09:24:33 +02:00
MDW
e6630cd7d1 Qual: Improve dol_syslog (#30782)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Improve dol_syslog

# Qual: Improve dol_syslog

The changes:
- Keep the log file open for less time (better for concurrency);
- Open the log file only to append data (no internal preparation for writing);
- Avoids re-assigning a constant array;
- Add PHPDoc information about the array parameters and return values;
- May reduce the computation of global settings;
- Result in a slight performance improvement.
2024-08-29 08:49:27 +02:00