Commit Graph

301 Commits

Author SHA1 Message Date
Laurent Destailleur
81790d0667 Debug v23 2025-11-09 23:12:34 +01:00
MDW
c4712cbca7 Qual: Fix PhanTypeComparisonFromArray in pertype.php and peruser.php (#36068)
# Qual: Fix PhanTypeComparisonFromArray in pertype.php and peruser.php

- Update pertype.php and peruser.php to resolve PhanTypeComparisonFromArray notices.
When an array value is set, it's already an array so comparing to '' is
useless and invalid.
- Update baseline.txt to reflect reduced occurrences of phan issues.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-02 16:56:31 +01:00
Laurent Destailleur
cd2f4bb7d2 Merge branch '22.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-10-24 19:46:38 +02:00
Laurent Destailleur
9f2c33aa75 Merge branch '22.0' of git@github.com:Dolibarr/dolibarr.git into 22.0 2025-10-24 19:39:15 +02:00
Laurent Destailleur
1e84852825 Clean code 2025-10-23 14:26:47 +02:00
Regis Houssin
d37cf4b38a FIX wrong socpeople id when multiple assigned + avoid php warnings (#35878) 2025-10-22 02:29:05 +02:00
ldestailleur
74cc569329 Merge branch '22.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-09-15 18:14:11 +02:00
HENRY Florian
644a9ea179 fix: Filter event in agenda par Type (#35287)
* fix filter event per Type

* fix filter event per Type

* fix: php code sniffer

* fix: php code sniffer

* fix: php code sniffer

* fix: php code sniffer
2025-09-11 12:09:33 +02:00
Frédéric FRANCE
7e9d2a94f4 clean code (#35170)
* clean code

* clean code
2025-09-02 22:52:11 +02:00
ldestailleur
5ea9be671c Merge branch '22.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-07-28 18:42:58 +02:00
ldestailleur
e6e3486f95 Fix CI 2025-07-28 17:29:51 +02:00
ldestailleur
c75663b2de Fix CI 2025-07-28 15:40:54 +02:00
ldestailleur
6a18353eb0 Fix CI 2025-07-24 11:00:42 +02:00
ldestailleur
6964a34697 Debug v22 2025-07-21 14:30:58 +02:00
ldestailleur
2e47121024 Debug v22 2025-07-21 14:25:48 +02:00
ldestailleur
a800af3b91 Debug v22 2025-07-21 10:47:45 +02:00
ldestailleur
70173993a3 Fix CI 2025-06-23 18:21:37 +02:00
ldestailleur
4a0cf5a2f9 Debug v22 2025-06-22 23:35:22 +02:00
Frédéric FRANCE
b7a00127a9 add missing translation (#33461)
* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation
2025-03-15 11:21:03 +01:00
MDW
d64298f6c1 Qual: Fix phan notices (htdocs/compta) (#33427) 2025-03-12 20:41:50 +01:00
ldestailleur
3658bc20b6 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-03-09 22:29:21 +01:00
ldestailleur
64d9b28b70 FIX Blank page on agenda event per user 2025-03-09 21:51:41 +01:00
Laurent Destailleur (aka Eldy)
c4f52d0484 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-02-04 22:51:31 +01:00
Laurent Destailleur (aka Eldy)
66dc3e810a Debug v21 2025-02-04 15:06:28 +01:00
MDW
2696c9a107 Fix ci phan/phpstan notices
# Fix ci phan/phpstan notices

Fix most notices, except undefined fk_website in SocieteAccount
as it is not clear if that is supposed to be a property there
(more specifically, that it is set).
2025-01-27 13:21:30 +01:00
Laurent Destailleur
18d593005c Fix phan 2025-01-27 03:50:46 +01:00
Frédéric France
2035f5f7a5 fix phan 2025-01-26 11:34:15 +01:00
Frédéric France
1e43b2f836 fix phan 2025-01-26 11:33:15 +01:00
Frédéric France
01bb6b7d85 fix phpstan branch 21 2025-01-25 09:16:52 +01:00
Frédéric France
45042afe4b fix phpstan branch 21 2025-01-25 09:04:43 +01:00
Laurent Destailleur (aka Eldy)
e9e7b85410 Debug v21 - pb holiday view into agenda 2025-01-24 21:20:20 +01:00
Laurent Destailleur (aka Eldy)
0932c2e492 Debug v21 2025-01-24 17:28:10 +01:00
Laurent Destailleur (aka Eldy)
ff2aa10145 Debug v21 2024-12-18 21:35:52 +01:00
Laurent Destailleur
22da15fc6a Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-11-20 23:30:16 +01:00
HENRY Florian
88a1eadfc7 fix: php warning (#32020)
* fix: php warning

* fix php warning

* fix php warning
2024-11-20 19:50:07 +01:00
MDW
9ec4618199 Qual: Fix FunctionArray phan notices (#31754)
* Qual: Fix FunctionArray phan notices

* Fix class name in typing of htdocs/modulebuilder/index.php

* Fix customreports phpdoc

* Adjust file type after completeFileArrayWithDatabaseInfo

* Further phpdoc typing improvements

* More phpdoc

* Improve typing with cast on position field

* Force phpstan version

* Add phpstan exception

* Fix array index type + adjust phan config comment
2024-11-11 14:48:18 +01:00
Frédéric FRANCE
1adc883b56 add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
Laurent Destailleur
e149f8ba6c Debug v21 2024-10-27 02:40:58 +01:00
Laurent Destailleur
ff4344d5c8 Clean code 2024-10-24 01:12:58 +02:00
MDW
0c26110636 Qual: Fix notices related to user classes (#31291)
# Qual: Fix notices related to user classes

This fixes several notices related to user classes (and reveals
some actual bugs or inconsistent typing).
2024-10-06 13:52:05 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Frédéric FRANCE
000173c7b9 fix phpstan (#31075)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-23 01:59:14 +02:00
MDW
099dbd9c1e Qual: Fix notices for htdocs/admin/* (#30982)
* Fix (Possibly)UndeclaredGlobalVariable

* Update phan baseline

* Fix (Possibly)UndeclaredGlobalVariable (2)

* Qual: Fix notices for htdocs/admin/*

# Qual: Fix notices for htdocs/admin/*

Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Frédéric FRANCE
97392965e1 fix ignored phpstan (#30645)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-16 20:13:02 +02:00
Frédéric FRANCE
4c51d61fc5 fix ignored phpstan (#30644)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-15 16:55:13 +02:00
Laurent Destailleur
b58c93833e Fix phan warning 2024-07-13 18:35:03 +02:00
Laurent Destailleur
8d279a535c Fix phan 2024-07-13 18:29:28 +02:00
Laurent Destailleur
150e162022 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-13 18:22:59 +02:00
Laurent Destailleur
30f9215846 Debug v20 2024-07-13 17:58:47 +02:00