Commit Graph

371 Commits

Author SHA1 Message Date
MDW
11c43e8c63 Fix: ticket.class phan/phpstan notices (#31448)
* Qual: Fix ticket.class notices

* Do not analyze custom

* Fix: Correct reference to cache (+phpdoc)

* Update baseline, ignore everything in custom

* Qual: Fix notices in files related to ticket class
2024-10-19 01:21:41 +02:00
IC-Victorien
cf22007541 NEW HOOK FORMCONFIRM IN TICKET (#31321) 2024-10-13 21:11:16 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Zephyriony
bda0a99c03 NEW #31103 (#31140)
* NEW #31103

* Update card.php

* Update card.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 16:05:15 +02:00
Frédéric FRANCE
5fd996821b fix phpstan (#30962)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* Update html.formadmin.class.php
2024-09-17 02:54:44 +02:00
MDW
f89245b354 Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00
Lucas Marcouiller
ef2ec011f5 Fix #30828 bad save of contract id in ticket card (#30916)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-09-12 21:34:28 +02:00
Laurent Destailleur
9eb61af370 Debug v20 2024-09-10 11:24:55 +02:00
Laurent Destailleur
9f693ea049 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-09 03:53:42 +02:00
Laurent Destailleur
3e9a0cfa99 Debug v20 2024-09-09 03:52:25 +02:00
HENRY Florian
2c39f6cacb fix: missing triggername args on re-open ticket (#30889)
* fix: missing triggername args on re-open ticket

* Update card.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-09 02:43:02 +02:00
Laurent Destailleur
70a8f2e9ee Fix test on permission 2024-09-06 16:40:06 +02:00
Laurent Destailleur
b02a891f2f Enhance the protection on missing permissions 2024-09-06 15:49:57 +02:00
Laurent Destailleur
14d5b4bcc3 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-02 12:14:51 +02:00
Laurent Destailleur
aa096719b2 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-02 11:18:06 +02:00
Laurent Destailleur
c8505f9c0a Fix missing test on permissions 2024-09-01 21:04:53 +02:00
boudet jean pascal
10924547ea FIX : attached file on first page load (#30694)
* fix attached file on first page load

* PRE-COMMIT

* set mode init

* Update 18.0.0-19.0.0.sql

Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>

---------

Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: jpb <jean-pascal.boudet@atm-consulting>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-01 15:13:53 +02:00
Laurent Destailleur
5fcda2157e Fix missing test on permissions 2024-09-01 14:32:49 +02:00
Laurent Destailleur
8958aed2ef Fix cursor 2024-08-28 03:30:06 +02:00
Laurent Destailleur
367cdd7ccc Fix emailcollector from tickets 2024-08-27 22:21:29 +02:00
Laurent Destailleur
1277c19a2d Fix emailcollector from tickets 2024-08-27 22:20:51 +02:00
Frédéric FRANCE
97392965e1 fix ignored phpstan (#30645)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-16 20:13:02 +02:00
Laurent Destailleur
9e01c45df6 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-28 16:56:07 +02:00
Laurent Destailleur
e5e1f385b5 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-07-28 16:49:12 +02:00
Laurent Destailleur
6428a1d892 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-07-28 15:05:02 +02:00
Laurent Destailleur
73e4aa3147 Fix no html allowed into the subject of email/message 2024-07-27 15:47:17 +02:00
Laurent Destailleur
290f164b4f Sanitize output 2024-07-27 15:41:14 +02:00
Laurent Destailleur
16e48da91e Fix CTI 2024-07-23 19:35:06 +02:00
Laurent Destailleur
1c6dfc4508 Removed duplicate info subject on ticket page. 2024-07-23 09:22:10 +02:00
Laurent Destailleur
6ed6900c79 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-22 16:46:40 +02:00
Laurent Destailleur
3633762298 Fix dolPrintHTML when MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is off 2024-07-22 16:36:24 +02:00
Laurent Destailleur
8d7e2d7aa0 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-22 13:23:00 +02:00
Laurent Destailleur
940b946dfb Debug v20 2024-07-22 13:19:35 +02:00
Frédéric FRANCE
f99beb9023 fix expects int (#30304) 2024-07-06 14:30:13 +02:00
Alexandre SPANGARO
96afcaa476 Better comments (#30200)
* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* CI Missing language key

* Update eventorganization.lang

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-30 21:02:50 +02:00
Laurent Destailleur
cf5daf7c25 Removed useless option. Default dolibarr behaviour is to be open. 2024-06-27 00:29:51 +02:00
Laurent Destailleur
82614d7fca Debug v20 2024-06-15 18:55:17 +02:00
Anthony Damhet
61c9245498 Add llxHeader to tickets (#29932) 2024-06-08 14:50:14 +02:00
Laurent Destailleur
5ee4af14ed Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-05-31 16:30:50 +02:00
Charles
fb1e5b9dd5 Update card.php Issue #29757 (#29758)
Bug-Fix Issue #29757  Prevent the check for a duplicate ref from populating the new ticket object fields with values from the conflicting ticket.
2024-05-25 13:04:39 +02:00
Laurent Destailleur
283f16234f Debug v20 2024-05-03 01:02:40 +02:00
atm-irvine
71c2256a6d NEW : Edit ticket (#29497)
* NEW : Edit ticket

* Fixed for travis

* Fix pre-commit

* Fix for phan

* Update html.formticket.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-27 12:43:04 +02:00
Laurent Destailleur
1908d6cf98 Look and feel v20 - All combo of categories are using the colored picto 2024-04-24 02:40:53 +02:00
Laurent Destailleur
f94d0cd907 Debug v20 2024-04-20 14:28:59 +02:00
Laurent Destailleur
cf912c53d2 Look and feel v20 2024-04-14 01:42:31 +02:00
Francis Appels
73af628c6d Fix TICKET ERROR WHEN TRY TO DELET #29297 (#29319)
Regression on GETPOST to GETPOSTINT
2024-04-11 20:09:31 +02:00
Laurent Destailleur
e92d6230df Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/ticket/class/ticket.class.php
	htdocs/ticket/list.php
	htdocs/ticket/stats/index.php
2024-03-20 02:31:33 +01:00
Laurent Destailleur
dd5d70ad5d Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
Conflicts:
	htdocs/core/triggers/interface_50_modTicket_TicketEmail.class.php
	htdocs/public/ticket/create_ticket.php
	htdocs/public/ticket/index.php
	htdocs/public/ticket/list.php
	htdocs/public/ticket/view.php
	htdocs/ticket/agenda.php
	htdocs/ticket/card.php
	htdocs/ticket/class/ticket.class.php
	htdocs/ticket/contact.php
	htdocs/ticket/document.php
	htdocs/ticket/index.php
	htdocs/ticket/list.php
	htdocs/ticket/messaging.php
	htdocs/ticket/stats/index.php
2024-03-20 02:25:58 +01:00
MDW
61cae896ec Force variable typing to avoid false positives 2024-03-19 03:16:00 +01:00
mrozniecki
fcff03c66d Add substitution for mail intro and signature on ticket mail 2024-03-18 16:10:39 +01:00