Commit Graph

1060 Commits

Author SHA1 Message Date
MDW
0c26110636 Qual: Fix notices related to user classes (#31291)
# Qual: Fix notices related to user classes

This fixes several notices related to user classes (and reveals
some actual bugs or inconsistent typing).
2024-10-06 13:52:05 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081)
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
000173c7b9 fix phpstan (#31075)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-23 01:59:14 +02:00
Laurent Destailleur
f5c57e1608 deprecate method getrights that is conflict with getRights() of
CommonObject.
2024-09-07 18:03:43 +02:00
Laurent Destailleur
4c0e978d42 Fix phan 2024-09-01 12:46:17 +02:00
Laurent Destailleur
f126e015a3 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-31 12:25:43 +02:00
Laurent Destailleur
ff79295e2c Debug v20 2024-08-31 12:24:49 +02:00
thibdrev
3dbd79dad8 qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. (#30712)
* Update adherent.class.php

* Update adherent_type.class.php

* Update availabilities.class.php

* Update propal.class.php

* Update account.class.php

* Update paymentvarious.class.php

* Update cashcontrol.class.php

* Update localtax.class.php

* Update remisecheque.class.php

* Update bonprelevement.class.php

* Update chargesociales.class.php

* Update contact.class.php

* Update contrat.class.php

* Update commonorder.class.php

* Update timespent.class.php

* Update don.class.php

* Update conferenceorbooth.class.php

* Update expedition.class.php

* Update expensereport.class.php

* Update paymentexpensereport.class.php

* Update fichinter.class.php

* Update fournisseur.commande.class.php

* Update holiday.class.php

* Update evaluation.class.php

* Update job.class.php

* Update position.class.php

* Update skill.class.php

* Update intracommreport.class.php

* Update knowledgerecord.class.php

* Update loan.class.php

* Update mo.class.php

* Update partnership.class.php

* Update inventory.class.php

* Update entrepot.class.php

* Update project.class.php

* Update holiday.class.php - fix phan error

* Update task.class.php

* Update reception.class.php

* Update recruitmentcandidature.class.php

* Update recruitmentjobposition.class.php

* Update paymentsalary.class.php

* Update salary.class.php

* Update supplier_proposal.class.php

* Update ticket.class.php

* Update user.class.php

* Update usergroup.class.php

* Update webportalinvoice.class.php

* Update webportalorder.class.php

* Update webportalpropal.class.php

* Update workstation.class.php

* Update facture.class.php
2024-08-22 03:31:04 +02:00
MDW
be0f28245c Qual: Fix phan notices wrt main.inc.php, menus (#30633)
* Qual: Fix phan notices wrt main.inc.php, menus

# Qual: Fix phan notices wrt main.inc.php, menus

This fixes phan notices stemming from main.inc.php and the menu classes.

* Qual: Fix phpstan notice that dol_authmode always set

# Qual: Fix phpstan notice that dol_authmode always set

dol_authmode is always set because it is now initialised.
2024-08-14 14:05:56 +02:00
MDW
d6948077b2 Qual: Fix spelling/update .pre-commit configuration (versions) (#30546)
* Qual: Update pre-commit configuration

* Qual: Update spelling

* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
MDW
e3d3bad080 Fix: 🛟Fix getrights usage & Update the documentation to suggest to use loadRights (#30543)
* Qual: Update the documentation to suggest to use loadRights

# Qual: Update the documentation to suggest to use loadRights

Given the pending issues, update the documention regarding getrights to
point to loadRights.

* Fix: call loadRights on User (not getRights)
2024-08-04 18:47:22 +02:00
Laurent Destailleur
823e53803d Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-03 15:45:33 +02:00
Laurent Destailleur
6558c69ac7 Doc 2024-08-02 11:17:14 +02:00
Laurent Destailleur
5727dadfdd Fix condition to get permission 2024-08-02 10:55:53 +02:00
Laurent Destailleur
f002fb4ed1 Use the non deprecated function loadRights instead of getrights 2024-08-02 10:36:43 +02:00
Laurent Destailleur
46cde6431a NEW Can use a specific profile to send email for password forgotten 2024-08-01 11:36:21 +02:00
Laurent Destailleur
292080ca14 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-30 12:28:15 +02:00
Laurent Destailleur
4223c6241c Fix tooltip 2024-07-30 11:52:40 +02:00
Laurent Destailleur
6ac589b0a9 NEW Introduce value 'password' formode of sanitization in GETPOST. 2024-07-21 14:44:14 +02:00
Frédéric FRANCE
2f5647e4e3 fix checkFunctionArgumentTypes (#30234)
* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* add ignore

* add ignore

add ignore

add ignore

add ignore

add ignore

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes
2024-07-03 02:30:53 +02:00
Frédéric FRANCE
facb1930a7 fix phpstan Property Product::$oldcopy in empty() is not falsy (#30003)
* fix phpstan Property Product::$oldcopy in empty() is not falsy

* add token

* doc

* fix phpstan Property Product::$oldcopy in empty() is not falsy

* fix phpstan Property Product::$oldcopy in empty() is not falsy

* fix phpstan
2024-06-13 08:11:11 +02:00
Laurent Destailleur
82908a30eb Clean phan warnings 2024-05-30 13:37:17 +02:00
Laurent Destailleur
b1f4f09b1c Code comment 2024-05-06 18:25:06 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Laurent Destailleur
577491b799 Fix permissions on external users 2024-05-02 21:48:50 +02:00
Laurent Destailleur
50aa16c270 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-05-02 21:03:26 +02:00
Laurent Destailleur
cb604da904 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-04-28 22:16:01 +02:00
Laurent Destailleur
d35dd5a5a2 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-28 21:57:00 +02:00
Laurent Destailleur
1af7ad923c Fix phan 2024-04-28 21:56:41 +02:00
Frédéric FRANCE
7c73d7d2bd fix phpstan (#29520)
* fix phpstan

* Update user.class.php

* typo
2024-04-28 18:20:58 +02:00
Laurent Destailleur
b8b964169a Merge 2024-04-27 03:32:22 +02:00
Laurent Destailleur
50833e00d0 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-04-27 03:14:17 +02:00
Laurent Destailleur
078c1dd489 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-04-27 03:13:12 +02:00
Laurent Destailleur
3a887ab2fa FIX #29496 - filtering a record should not hide its child not filtered 2024-04-27 03:12:17 +02:00
Laurent Destailleur
905476dece Debug v20 2024-04-24 00:07:31 +02:00
Laurent Destailleur
f1bc41d100 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-23 22:36:13 +02:00
Laurent Destailleur
60c0fc2386 Fix warning PHP 8.2 2024-04-22 18:42:34 +02:00
Laurent Destailleur
d9278f8580 Fix phan 2024-04-22 15:17:38 +02:00
Laurent Destailleur
8ca94fd521 Fix warning 2024-04-22 14:51:58 +02:00
Laurent Destailleur
57b2b90730 Remove field egroupware_id that seems never itinialised/used 2024-04-22 14:50:25 +02:00
Laurent Destailleur
7f780fcb57 It seems constant are for storing data only and used for
DolibarrModules.class.php file only (main code shoud only use
->hasRight), so i try to move them.
2024-04-08 11:53:49 +02:00
Regis Houssin
68eb5e409a NEW module user rights enhancement (#29150)
* NEW module user rights enhancement

* FIX syntax error

* FIX fuck

* FIX syntax error

* FIX Add label with the current language (key or with PermissionXXX)

* FIX wrong test

* FIX optimize

* FIX doc

* FIX add class "Rights" for constant

* FIX replace with constants

* FIX missing constant

* FIX wrong check

* TODO sql error : data too long for column 'libelle'

* FIX syntax error

* FIX synax error "the return"... i'll be back

* FIX use operator with double question mark

* FIX add comment

* FIX just remplace integer with constant

* FIX remove unused code

* FIX add an example

* FIX remove the possibility to have entity = 0 (too complicated)

* FIX perms must not be empty

* FIX sql syntax error

* FIX phpstan undefined property DolibarrModules::$modules

* FIX same fix of frederic34

* Update llx_rights_def.sql

* Update DolibarrModules.class.php

* Update DolibarrModules.class.php

* Update DolibarrModules.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-08 11:40:02 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
MDW
04c3e80fc5 Fix typing 2024-03-29 18:26:48 +01:00
Lenin Rivas
fa65546800 Enable user establishment 2024-03-29 08:04:02 -05:00
Laurent Destailleur
787b1a1c83 Merge branch 'develop' into fix/filebyfile 2024-03-28 14:23:54 +01:00
MDW
ebb4c2111a Improve gender, admin, entity typing 2024-03-27 10:18:47 +01:00
MDW
d60a630d35 Fix: note<->note_private aliasing is handled by DeprecationHandler
# Fix: note<->note_private aliasing is handled by DeprecationHandler

The extra copy is useless, the aliasing for the deprecated property is already handled
2024-03-24 17:39:06 +01:00
MDW
1986888333 Update PHPdoc for User::$users 2024-03-24 15:40:26 +01:00