Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2025-12-12 20:41:26 +01:00
Code Issues Packages Projects Releases Wiki Activity
143,481 Commits 36 Branches 190 Tags
4abab4ee4bc371b3451864fa57dc1910366ce0aa
Commit Graph

854 Commits

Author SHA1 Message Date
MDW
d71cd352d5 Qual: Fix PhanUndeclaredMethod (#30661) 
* Qual: Fix PhanUndeclaredMethod cases

* Fix PhanUndeclaredMethod cases

* Qual: Remove PhanUndeclaredMethod exceptions

* Fix spelling "disacard"

* Improve phpdoc, add abstract method to trait for typing

* Improve phpdoc typing for PHanUndeclaredMethod

* Suppress phan notices for guarded AliasNbPages calls

* Fix return value for printFile stub

* Fix getting message from Exception

* Define dummy getAllByProducts(), typing for it.

* Fix typo in comment

* Qual: Better typing for apiService (phan)

* Test that the Generic OAuth Service is provided

* Qual: Fix getSqlArrayForStats typing

* Force modTcpdfbarcode

* Correct typing hint

* Set ModelePDFAsset typehint

* Fix ModelePDFUserGroup typing hint

* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php

* Fix write_file in ModelePDFStock*

* Update printsheet.php

* Adjust typing hint for barcode generator

* Update printsheet.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-19 02:05:27 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542) 
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-15 17:05:00 +02:00
Frédéric FRANCE
a9f93f35c7 add phpdoc (#30631) 
* add phpdoc

* Update contrat.class.php
 2024-08-13 20:31:03 +02:00
Frédéric FRANCE
17c887a433 fix typos (#30630) 
* fix typos

* fix typos
 2024-08-13 20:29:40 +02:00
Laurent Destailleur
b3b21d56b6 Fix doxygen 2024-08-07 02:49:38 +02:00
MDW
d6948077b2 Qual: Fix spelling/update .pre-commit configuration (versions) (#30546) 
* Qual: Update pre-commit configuration

* Qual: Update spelling

* Ignore use of deprecated constant
 2024-08-07 01:20:43 +02:00
kkhelifa-opendsi
572061ff80 NEW: Add ID of the line in the trigger context for addLine(), updateLine() and deleteLine() on contract (#30343) 2024-07-10 18:49:49 +02:00
Frédéric FRANCE
29f223fd3c fix checkFunctionArgumentTypes (#30249) 
* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes
 2024-07-04 17:47:31 +02:00
Frédéric FRANCE
2f5647e4e3 fix checkFunctionArgumentTypes (#30234) 
* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* add ignore

* add ignore

add ignore

add ignore

add ignore

add ignore

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes
 2024-07-03 02:30:53 +02:00
Frédéric FRANCE
4b275dc148 add phpdoc (#30208) 
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* clean phpdoc
 2024-06-30 19:39:01 +02:00
Laurent Destailleur
db61320098 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 
Conflicts:
	htdocs/contrat/class/contrat.class.php
	htdocs/core/menus/standard/eldy.lib.php
	htdocs/product/price.php
	htdocs/product/stock/stocktransfer/class/stocktransfer.class.php
	htdocs/user/list.php
 2024-06-30 04:05:46 +02:00
Laurent Destailleur
b2e288f8ec Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 
Conflicts:
	htdocs/accountancy/bookkeeping/list.php
	htdocs/core/menus/standard/eldy.lib.php
 2024-06-30 03:53:16 +02:00
Laurent Destailleur
f64e4b4981 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-06-29 20:53:10 +02:00
HENRY Florian
9c6a1eac94 fix: bad errors variable for error return (#30145) 
* fix: bad errors variable for error return

* fix: bad errors variable for error return

* Update contrat.class.php

fix review
 2024-06-24 23:47:34 +02:00
Laurent Destailleur
6d8debd95e Clean files not used in v20 2024-06-18 14:14:41 +02:00
Frédéric FRANCE
facb1930a7 fix phpstan Property Product::$oldcopy in empty() is not falsy (#30003) 
* fix phpstan Property Product::$oldcopy in empty() is not falsy

* add token

* doc

* fix phpstan Property Product::$oldcopy in empty() is not falsy

* fix phpstan Property Product::$oldcopy in empty() is not falsy

* fix phpstan
 2024-06-13 08:11:11 +02:00
Mathieu Moulin
abcb1dad4b Define CommonObject relation in CommonObjectLine classes (#29956) 2024-06-10 16:08:39 +02:00
Frédéric FRANCE
741e75ee47 add phpdoc (#29832) 
* add phpdoc

* fix phan

* fix phan

* fix phan

* fix phan

* fix phan

* fix phan

* fix phan

* fix phan

* fix phan

* add phpdoc

* fix phan

* fix phan
 2024-06-04 14:46:54 +02:00
Frédéric FRANCE
652c8526fa fix cti (#29813) 
* fix cti

* fix cti

* no photo in asset lines

* no photo in asset lines

* no photo in asset lines

* no photo in asset lines

* no photo in recruitment lines

* no photo in recruitment lines

* fix

* fix dead catch
 2024-06-03 13:44:14 +02:00
Laurent Destailleur
1756796caa Debug v20 2024-05-21 17:00:11 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602) 
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-05-05 00:34:19 +02:00
Laurent Destailleur
60c0fc2386 Fix warning PHP 8.2 2024-04-22 18:42:34 +02:00
Laurent Destailleur
b5de782c6b Fix use the good HTTP code 2024-04-07 14:59:25 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
c64bba12ee Merge pull request #29171 from JonBendtsen/contact_update_single_array_option_element 
allow updating contract single Complementary Attribute
 2024-04-02 14:49:35 +02:00
Laurent Destailleur
7715513ac9 Some API HTTP return code were moved from 401 to 403 to better follow 
REST specification.
 2024-04-02 14:47:49 +02:00
Laurent Destailleur
2dc3306e70 Merge branch 'develop' into contact_update_single_array_option_element 2024-04-02 13:38:45 +02:00
Laurent Destailleur
990216b13f NEW Api parameters are sanitized by the WAF, same code than GET/POST 2024-04-02 13:07:13 +02:00
Jon Bendtsen
0d4ef406c4 will allow updating 1 contract single Complementary Attribute without specifying complementary attributes that we don't want to change. Similar to # 29115 but just for contracts 2024-04-01 11:02:29 +02:00
Laurent Destailleur
a7e33e6573 Merge pull request #29047 from mdeweerd/fix/PhanPluginUnknownObjectMethodCall1 
Fixes for PhanPluginUnknownObjectMethodCall
 2024-03-28 14:20:57 +01:00
Laurent Destailleur
22aa30bd3c Debug v20 2024-03-28 12:44:14 +01:00
MDW
d0631e60bf Force typing (phan) for typing checks 2024-03-27 10:18:07 +01:00
MDW
c16a4f5951 Fix PhanNonClassMethodCall with extra test 2024-03-24 15:40:23 +01:00
MDW
6a14a8304d Fix $mybool |=... which is binary op, not boolean op 
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
 2024-03-21 13:45:10 +01:00
MDW
4d4d3ba175 Fix arg type to preg_replace(),preg_match(),trim() with cast + phpdoc 2024-03-20 04:08:41 +01:00
MDW
f74273cdec Fix arg type for trim by casting to string 2024-03-19 20:38:47 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
MDW
61e05a9fde Fix Typing on $fields for 2nd class in file 
# Fix Typing on $fields for 2nd class in file

This fixes the PHPstan notification for the $fields property of the
second CommonObject subclass in the files.

Example: 'PHPDoc type array of property BOMLine::$fields is not covariant with PHPDoc type array of overridden property CommonObject::$fields.'
 2024-03-15 17:10:30 +01:00
Laurent Destailleur
1a722fa436 Merge branch 'develop' into fix/PhanTypeMismatchPropertyProbablyReal 2024-03-15 15:07:35 +01:00
evarisk-micka
d43c3227db Add signed status CRUD to contract and fichinter 2024-03-15 12:12:21 +01:00
MDW
23fecf4524 Fix Add to errors, not error which is not an array 2024-03-15 10:11:53 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
27fc56c70a Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:09 +01:00
MDW
d199883ec1 Fix PhanPluginDuplicateExpressionAssignment (NOOP assignment) 2024-03-12 22:25:35 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)') 
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
 2024-03-12 13:38:08 +01:00
MDW
640eb1b75d Fix: Repeat fields typing in CommonClass children 
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
 2024-03-11 17:39:11 +01:00
Frédéric FRANCE
fba15178eb all initAsSpecimen return int (#28577) 
* all initAsSpecimen return int

* all initAsSpecimen return int

* all initAsSpecimen return int
 2024-03-02 16:38:35 +01:00
Laurent Destailleur
9d48dcbd3d Fix phpstan 2024-02-22 01:32:55 +01:00
Frédéric FRANCE
5f1c679142 fix warning (#28177) 
* fix warning

* clean properties

* clean properties
 2024-02-15 13:59:19 +01:00