Commit Graph

108 Commits

Author SHA1 Message Date
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
MDW
be0f28245c Qual: Fix phan notices wrt main.inc.php, menus (#30633)
* Qual: Fix phan notices wrt main.inc.php, menus

# Qual: Fix phan notices wrt main.inc.php, menus

This fixes phan notices stemming from main.inc.php and the menu classes.

* Qual: Fix phpstan notice that dol_authmode always set

# Qual: Fix phpstan notice that dol_authmode always set

dol_authmode is always set because it is now initialised.
2024-08-14 14:05:56 +02:00
MDW
c6d0cb3f5b Fix PhanTypeSuspiciousStringExpression 2024-03-19 02:43:41 +01:00
MDW
1fc3c3a46d Fix PhanTypeSuspiciousStringExpression 2024-03-19 02:43:29 +01:00
MDW
dbe8aacd0a Fix PhanParamSuspiciousOrder by ignoring notification 2024-03-17 20:12:43 +01:00
MDW
84131ca971 Fix PhanPluginRedundantAssignment 2024-03-13 01:03:59 +01:00
Laurent Destailleur
949c885477 Merge branch 'develop' into fix/phpdoc1 2024-03-12 14:11:30 +01:00
Laurent Destailleur
4f64c683ee Better support for MAIN_OPTIMIZEFORTEXTBROWSER 2024-03-12 01:55:26 +01:00
MDW
85efac2257 Qual: Update PHPdoc to correspond to code 2024-03-11 21:47:38 +01:00
MDW
b72cf193c4 Fix some cases of PhanTypeSuspiciousStringExpression (#28751)
* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-11 14:01:28 +01:00
MDW
dbfb1180ee Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions (#28749)
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions

Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
2024-03-11 12:58:51 +01:00
Laurent Destailleur
7e31aedf94 FIX Picto in top menu 2024-03-09 23:46:38 +01:00
Laurent Destailleur
0580ac2ca6 Better accessibility 2024-02-29 00:52:56 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491)
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
MDW
0391e02b28 Fix seen as undeclared by static checker.
# Fix  seen as undeclared by static checker.
https://github.com/Dolibarr/dolibarr/pull/26480/checks#step:5:79
https://github.com/Dolibarr/dolibarr/pull/26480/checks#step:5:80
2023-12-18 05:00:39 +01:00
Laurent Destailleur
d0b6b9fe65 Fix with php-cs-fixer 2023-12-04 12:07:53 +01:00
Laurent Destailleur
53dab922fd Fix php8.2 warnings 2023-11-27 11:39:32 +01:00
Frédéric FRANCE
f1ad6d7643 fix phpstan (#26776) 2023-11-21 23:44:26 +01:00
MDW
e7c49922a6 Fix some items detected by phan (see #26262) (#26264)
* Fix some items detected by phan (see #26262)

* Update fournisseur.facture-rec.class.php

* Update fournisseur.facture-rec.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2023-10-20 02:28:51 +02:00
Laurent Destailleur
c507adeef7 NEW Top menu support picto of modules that are font awesome picto. 2023-10-13 15:00:51 +02:00
Laurent Destailleur
4de50da0dd Repare code to forbidden var_dump() into code 2022-05-17 14:55:38 +02:00
Laurent Destailleur
1dd8cfe559 NEW More mode for THEME_TOPMENU_DISABLE_IMAGE 2022-05-02 20:10:42 +02:00
Laurent Destailleur
5dfd38c8f9 Clean code for top menu 2022-05-02 16:54:27 +02:00
Alexandre SPANGARO
3f26ab195b HTML5 - <font> tag is deprecated, replace by <span> 2021-10-05 09:46:48 +02:00
Laurent Destailleur
ce33f39bb0 Clean code. Menu must be greyed in get_menudiv 2021-09-11 15:43:26 +02:00
Frédéric FRANCE
a4e25359e7 add missing rule 2021-03-01 20:37:16 +01:00
Laurent Destailleur
eca010937f FIX Trigger on expense report was not fired
FIX Bad dates on info tabs
2021-02-04 11:56:53 +01:00
Laurent Destailleur
ee0e882607 Clear code 2020-12-07 16:15:47 +01:00
Laurent Destailleur
3fb63e6a4b Look and feel v13 2020-12-07 15:51:22 +01:00
stickler-ci
08e6fcad0d Fixing style errors. 2020-12-04 17:10:39 +00:00
Frédéric FRANCE
b0e40aa215 fix type_user not define in left menu 2020-12-04 18:00:31 +01:00
Scrutinizer Auto-Fixer
7f52920716 Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-10-31 13:32:18 +00:00
Laurent Destailleur
4701656d95 Fix look and field v13 2020-10-06 13:08:20 +02:00
Frédéric FRANCE
b41ac00b98 add new rule 2020-05-21 15:05:19 +02:00
Frédéric FRANCE
ee6fadd0d5 add new rule 2020-05-21 01:41:27 +02:00
Laurent Destailleur
0636682e91 FIX The substitution variable array was not complete 2019-12-19 13:41:43 +01:00
Scrutinizer Auto-Fixer
b40ecc3933 Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2019-11-13 18:37:08 +00:00
Frédéric FRANCE
8f6d38ee82 clean indent 2019-10-27 17:01:23 +01:00
Alexandre SPANGARO
02dbc11f98 Move Gnu.org to https 2019-09-23 21:55:30 +02:00
Laurent Destailleur
f08c07f315 Fix bugs reported by scrutinizer 2019-09-06 10:42:51 +02:00
Laurent Destailleur
7120078b0f NEW Simplification of styles architcture: Showing or not the menuhider
is completely decided by CSS and screen size instead of PHP+CSS.
2019-04-03 13:26:50 +02:00
Frédéric FRANCE
92c5c15033 add visibility 2019-02-28 20:48:07 +01:00
Laurent Destailleur
e18bd6f986 Merge branch 'develop' into nospaceaftercomma 2019-01-30 18:27:35 +01:00
Frédéric FRANCE
b10558bacd Merge remote-tracking branch 'upstream/develop' into nospaceaftercomma 2019-01-27 23:23:38 +01:00
Laurent Destailleur
f30a3d59ba Merge branch 'develop' into toomanylines 2019-01-27 17:59:13 +01:00
Laurent Destailleur
4f9f0fd7b5 Merge branch 'develop' into elseif 2019-01-27 17:54:06 +01:00
Frédéric FRANCE
f0cdf300d1 Squiz.Functions.FunctionDeclarationArgumentSpacing 2019-01-27 15:20:16 +01:00
Frédéric FRANCE
496fa9b0fb PSR2.Files.EndFileNewline.TooMany 2019-01-27 14:10:35 +01:00
Frédéric FRANCE
7ee086b402 PSR2 space after comma in function call 2019-01-27 11:55:16 +01:00
Frédéric FRANCE
6e91b3cefc PSR2 usage of else if is discouraged 2019-01-27 10:49:34 +01:00