Commit Graph

71 Commits

Author SHA1 Message Date
MDW
e105b577ee Fix PhanTypeMismatchReturn by changing return and logging error 2024-03-20 21:58:39 +01:00
MDW
13ab939691 Fix deprecated function calls 2024-03-16 13:27:51 +01:00
Frédéric France
4577a4d432 fix phpstan is incompatible with 2024-03-14 18:40:31 +01:00
MDW
8bd965fb80 Fix duplicate if condition
# Fix duplicate if condition

Removed the duplicate which had a different action but it was not effective in the code
so it was removed (it looks like a leftover).
2024-03-12 19:09:06 +01:00
Frédéric FRANCE
3c055f671e fix phpstan (#28545)
* fix phpstan

* fix phpstan
2024-03-01 12:51:48 +01:00
thibdrev
b0658c48f0 qual: phpstan - Property mod_xxxx::$code_modifiable (string) does not accept int. (#28173)
* qual: phpstan for commonnumrefgenerator.class.php

* qual: phpstan for mod_codeproduct_elephant.php

* qual: phpstan for mod_codeproduct_leopard.php

htdocs/core/modules/product/mod_codeproduct_leopard.php	79	Property mod_codeproduct_leopard::$code_modifiable (string) does not accept int.

* qual: phpstan for mod_lot_free.php

htdocs/core/modules/product_batch/mod_lot_free.php	76	Property mod_lot_free::$code_modifiable (string) does not accept int.

* Update mod_codeclient_elephant.php

htdocs/core/modules/societe/mod_codeclient_elephant.php	46	PHPDoc type int of property mod_codeclient_elephant::$code_modifiable is not covariant with PHPDoc type string of overridden property ModeleThirdPartyCode::$code_modifiable.

* qual: phpstan for mod_codeclient_leopard.php

htdocs/core/modules/societe/mod_codeclient_leopard.php	76	Property mod_codeclient_leopard::$code_modifiable (string) does not accept int.

* qual: phpstan for mod_codeclient_monkey.php

htdocs/core/modules/societe/mod_codeclient_monkey.php	76	Property mod_codeclient_monkey::$code_modifiable (string) does not accept int.

* phpcs

* phpcs

* phpcs

* qual: phpstan for modules_societe.class.php

* Update mod_lot_free.php
2024-02-15 14:59:07 +01:00
Laurent Destailleur
75746ba90e Merge pull request #27373 from mdeweerd/fix/remove_extra_arg_mod_codeclient_constructs
FIX: Update mod_codeclient_* constructor to have $db argument as in callers.
2024-01-10 15:33:55 +01:00
MDW
9d2bc42ee3 FIX: Update mod_codeclient_* constructor to have $db argument as in callers.
None of the mod_codeclient_* constructors has an argument.
Reported by phan as `PhanParamTooMany: Call with 1 arg(s) to \mod_codeclient_leopard::__construct() which only takes 0 arg(s) defined at htdocs/core/modules/societe/mod_codeclient_leopard.php:69`
in all modified files.
One exception in the card.php file because the code has no explicit detail,
but it also uses a mod_codeclient_ constructor.
2024-01-10 14:06:40 +01:00
Laurent Destailleur
9e1b90e4a1 Fix with php-cs-fixer 2023-12-04 12:07:31 +01:00
Laurent Destailleur
53dab922fd Fix php8.2 warnings 2023-11-27 11:39:32 +01:00
Mohamed DAOUD
eba4756156 Fix some warnings -technical debt- (#26514)
* fix-warnings

* fix the last commit

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2023-11-14 01:52:42 +01:00
Laurent Destailleur
24040c78bb Tooltip for help in ODT doc generation setup is now clickable 2023-08-18 01:46:54 +02:00
Laurent Destailleur
db2a70b86a NEW Factorize a lot of code for numbering modules 2023-08-09 14:50:28 +02:00
Laurent Destailleur
57358b618b Clean code 2022-12-31 17:08:10 +01:00
Frédéric FRANCE
42cf7acfe5 doc translation 2022-12-21 17:26:16 +01:00
Frédéric FRANCE
f11418c108 doc translation 2022-12-21 17:23:33 +01:00
Frédéric FRANCE
690562c22e add numbering modules for members 2022-12-21 16:43:38 +01:00
Laurent Destailleur
d6852c31b8 Clean code 2022-03-07 19:31:06 +01:00
Laurent Destailleur
4c505619e3 FIX look and field v14 2021-07-23 00:02:14 +02:00
Philippe GRAND
a2b5a3190d standardization, internationalisation 2021-02-09 14:14:40 +01:00
Philippe GRAND
c1bbd076df standardization, internationalisation 2021-02-09 14:13:49 +01:00
Laurent Destailleur
2b267cf8e4 Fix warnings 2020-12-04 20:06:55 +01:00
Frédéric FRANCE
3a041eed44 simplify function 2020-11-28 23:42:48 +01:00
Frédéric FRANCE
11a978ca08 simplify function 2020-11-28 23:41:44 +01:00
Frédéric FRANCE
cd61e5b0b2 Update modules_societe.class.php 2020-11-01 22:44:09 +01:00
Frédéric FRANCE
b41ac00b98 add new rule 2020-05-21 15:05:19 +02:00
Frédéric FRANCE
ee6fadd0d5 add new rule 2020-05-21 01:41:27 +02:00
Scrutinizer Auto-Fixer
444c293c01 Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-04-10 08:59:32 +00:00
Scrutinizer Auto-Fixer
612bac6598 Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-04-05 00:44:59 +00:00
Laurent Destailleur
e6641b5369 Fix doc 2020-04-03 18:01:54 +02:00
Alexandre SPANGARO
02dbc11f98 Move Gnu.org to https 2019-09-23 21:55:30 +02:00
Alexandre SPANGARO
3ddd123eb1 Traduction 2019-09-08 05:18:52 +02:00
Laurent Destailleur
bd47bd096b NEW Can defined a position of numbering submodules for thirdparties 2019-09-03 15:58:20 +02:00
Laurent Destailleur
f825711206 Code comment 2019-07-29 11:01:29 +02:00
Frédéric FRANCE
bd2e541fd6 add visibility 2019-03-01 18:28:51 +01:00
Frédéric FRANCE
7e31ca48d8 add visibility 2019-02-28 22:07:48 +01:00
Frédéric FRANCE
b10558bacd Merge remote-tracking branch 'upstream/develop' into nospaceaftercomma 2019-01-27 23:23:38 +01:00
Frédéric FRANCE
f0cdf300d1 Squiz.Functions.FunctionDeclarationArgumentSpacing 2019-01-27 15:20:16 +01:00
Frédéric FRANCE
7ee086b402 PSR2 space after comma in function call 2019-01-27 11:55:16 +01:00
Regis Houssin
569d59d251 FIX change my deprecated email 2018-10-27 14:43:12 +02:00
Frédéric FRANCE
70ba223788 move phpcs:ignore 2018-09-06 21:27:18 +02:00
Frédéric FRANCE
57fb3dc2f4 Merge remote-tracking branch 'upstream/develop' into camelCaps 2018-09-01 13:52:51 +02:00
Frédéric FRANCE
6aee680a4f PSR2 ClassDeclaration 2018-08-29 22:06:05 +02:00
Frédéric FRANCE
6b6daf178f Merge remote-tracking branch 'upstream/develop' into camelCaps 2018-08-21 20:57:58 +02:00
Philippe GRAND
edb566501d Update and standardize code 2018-08-17 18:54:41 +02:00
Frédéric FRANCE
850ac34020 mark non camelCaps function 2018-08-13 17:26:32 +02:00
Marcos García de La Fuente
8225b06018 NEW Removed commande_pdf_create, contract_pdf_create,expedition_pdf_create, facture_pdf_create, delivery_order_pdf_create, task_pdf_create, project_pdf_create, propale_pdf_create, supplier_invoice_pdf_create, supplier_order_pdf_create, supplier_proposal_pdf_create deprecated functions 2017-01-16 21:59:02 +01:00
Laurent Destailleur
77ef046af4 Start to mutualize the builddoc and remove_file action. 2015-09-06 14:02:21 +02:00
Scrutinizer Auto-Fixer
918ed34364 Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-04-07 00:45:30 +00:00
Laurent Destailleur
97eec37f1c Uniformize code: property "nom" for thirdparty is aliased into "name"
everywhere.
2014-10-04 17:20:17 +02:00