Commit Graph

2888 Commits

Author SHA1 Message Date
MDW
3d04a7195c Qual: Updates regarding write_file(s) methods for Phan (#30511)
* Fix phpdoc for phpstan

* Add abstract write_file to ModelePDFContract

And update phpdoc for derived classes

* Fix typing for php_standard_actions writefile

* Improve phpdoc for write_files (& related)

* Add abstract write_file to ModelePDFBom

* Add abstract write_file to ModelePDFDeliveryOrder

* Add abstract write_file to ModeleExpenseReport

* Add abstract write_file to ModelePDFFicheinter

* Add abstract write_file to ModelePDFEvaluation

* Add abstract write_file to ModelePDFFactures

* Add abstract write_file to ModelePDFSuppliersInvoices

* Update ModelePDFProjects and ModelePDFTask related classes

* Qual: Add abstract write_file to ModelePdfExpedition

And update phpdoc for derived classes

* Qual: Correct reference (doc) to ModelePDFEvaluation

* Qual: Add abstract write_file to ModelePDFKnowledgeRecord

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFMo & ModelePDFMouvement

And update phpdoc for derived classes

* Qual: Set typehint to ModelePDFFicheinter

* Qual: Add abstract write_file to ModelePDFCommandes

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFPropales

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePdfReception

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFSuppliersOrders

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFSuppliersOrders

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFSuppliersPayments

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFSupplierProposal

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFWorkstation

And update phpdoc for derived classes

* Set typing for doc generator (commonobject)

* Improve typing for write_file

* Set typing for doc generator

* Qual: Add abstract write_file to ModelePDFMember

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFProduct

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFProductBatch

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFRecruitmentJobPosition

And update phpdoc for derived classes

* Add abstract write_file to ModelePDFTicket

* Add abstract write_file to ModelePDFUser

* Add abstract write_file to ModelePDFUserGroup

* Add abstract write_file to ModeleThirdPartyDoc

* Add abstract write_file to ModelePDFAsset

* Find all incompatible classes

* Qual: update phan baseline

* Set typing for doc generator (commonobject)

* Qual: update phan baseline

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-14 19:21:10 +02:00
Noé Cendrier
57e9e5f845 FIX: PHPDoc wrong return value (#30634)
* FIX: PHPDoc wrong return value

* better type

* FIX: there is more types for Categorie::containing() return
2024-08-14 16:05:24 +02:00
MDW
e570f59e2d Qual: Phan fixes (mainly Initial type cannot be inferred) in popular changed classes (#30604)
* Update setValueFrom $id type to include null

* Only 2 arguments for ModeleNumRefMembers::getToolTip

* Fix PhanTypeConversionFromArray

* Only 6 args for PaymentSalary::addPaymentToBank

* Fix typing hints (array -> string)

* Fix uninitialized variables

* Add cssview to attributes phpdoc

* Avoid double typing specification (Phan notice)

* Qual: Ensure variable is defined (phan)

* Ensure phpdoc typing for verif method

* Ensure phpdoc typing for getNextValue method

* Add status as data key in cols array

* Ensure preg_replace operates on string (phan)

* Correct type for desiredstock

* Fix typing with casts (phan)

* Fix check that notification already exists

* Initialise fk_parent_id to fix typing issue

* Qual: Fix phan notices for Societe & related

* Qual: Fix typing for Facture and related

* Qual: Fix typing for Product & related

* Update baseline

* Fix new phpstan notices
2024-08-14 01:24:55 +02:00
MDW
3805b61408 Qual: Fix phpstan message & apply stricter check (#30536) 2024-08-11 00:08:37 +02:00
Laurent Destailleur
b138957cfb Try to fix phpstan 2024-08-02 16:51:31 +02:00
Laurent Destailleur
eabfc6606f Try to fix phpstan warning 2024-08-02 16:16:56 +02:00
Laurent Destailleur
e5aa605994 Debug v21 - Fix regression 2024-08-01 13:58:29 +02:00
MDW
75a4a31841 Qual: CommonObject improvements (Phan notices) (#30507)
Improve phpdoc, initialisation, field test
2024-08-01 12:49:01 +02:00
Laurent Destailleur
ee0412dd27 Fix phan warning 2024-07-31 18:54:52 +02:00
Bahfir Abbes
6b80e2000b Fix: strpos($InfoFieldList[4], 'extra') generates a warning if $InfoFieldList[4] does not exist (#30483) 2024-07-28 17:42:19 +02:00
Laurent Destailleur
c9b92bb32d Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-25 18:21:47 +02:00
Laurent Destailleur
6b076821e3 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-07-25 18:20:01 +02:00
Laurent Destailleur
f4611fcec9 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-07-25 18:06:37 +02:00
Laurent Destailleur
966ac2cdbc Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-07-25 18:04:42 +02:00
Laurent Destailleur
385d98b3e0 Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2024-07-25 18:04:17 +02:00
Laurent Destailleur
c1b8197b8b Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0 2024-07-25 18:02:04 +02:00
Laurent Destailleur
d5004258db Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 15.0 2024-07-25 18:00:55 +02:00
Laurent Destailleur
b494d26f95 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-25 14:51:48 +02:00
Laurent Destailleur
9563f51296 Add a protection against infinit loop. 2024-07-25 14:43:26 +02:00
Laurent Destailleur
4d23ea1229 Try to fix phan 2024-07-24 20:36:02 +02:00
Sébastien NASSIET
ad80e86f10 Bad variables used in updateExtrafield for replacement categorie in categories (#30457) 2024-07-24 17:31:34 +02:00
MaximilienR-easya
30f1d4f18b Backport fix from develop (#30421) 2024-07-20 18:24:01 +02:00
Bahfir Abbes
c4b21bf741 Fix: position of select key is 2 not 4 (#30374)
Fix: position of select key is 2 not 4
2024-07-16 13:01:08 +02:00
Bahfir Abbes
6d52e55702 Fix: position of select key is 2 not 4 (#30374)
Fix: position of select key is 2 not 4
2024-07-16 13:00:02 +02:00
Frédéric FRANCE
2707475a12 fix phpstan (#30319)
* fix phpstan

* fix phpstan expects int, false given ...

* fix phpstan expects int, true given ...
2024-07-08 21:45:35 +02:00
Laurent Destailleur
eb5b3deddf Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/accountancy/journal/bankjournal.php
2024-07-06 14:10:20 +02:00
Laurent Destailleur
8712c1c900 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
Conflicts:
	htdocs/product/card.php
2024-07-06 14:04:23 +02:00
John BOTELLA
ac136ec1ae Fix inconsistant link element (#30258) 2024-07-04 08:56:39 +02:00
Laurent Destailleur
25971c3e6f Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-07-02 13:41:32 +02:00
Laurent Destailleur
6ebcf20b6d Fix phan 2024-07-02 11:33:44 +02:00
Laurent Destailleur
e985d24b52 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-02 02:11:39 +02:00
Laurent Destailleur
d6480594af Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-07-02 02:09:25 +02:00
Laurent Destailleur
6259d02042 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-07-02 02:08:10 +02:00
noec764
96a5479e9e FIX: Error mesg show untranslated extrafield name (#30227)
Co-authored-by: Noé <noe@scopen.fr>
2024-07-02 01:56:45 +02:00
Frédéric FRANCE
4b275dc148 add phpdoc (#30208)
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* clean phpdoc
2024-06-30 19:39:01 +02:00
Laurent Destailleur
4dfef24f2f Doc 2024-06-30 15:03:52 +02:00
Laurent Destailleur
29434544e0 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-06-30 15:01:42 +02:00
Laurent Destailleur
9f54e7f389 doc 2024-06-30 15:01:29 +02:00
lvessiller-opendsi
a967f94850 FIX force rounding mode 0 for expense report (#30191) 2024-06-30 15:01:19 +02:00
Laurent Destailleur
bbbcf57756 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-06-29 19:25:59 +02:00
Laurent Destailleur
2f4c84f4b5 Debug v20 2024-06-29 13:23:05 +02:00
Laurent Destailleur
22b50b2172 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-06-26 13:26:37 +02:00
Laurent Destailleur
bd2a0b9e55 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-06-25 15:13:51 +02:00
Laurent Destailleur
db5ade973c Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-06-25 11:18:31 +02:00
John BOTELLA
322bbd934b fix : 19.0 fix inconsistent link validation (#30141)
* Dirty fix for inconcistant link psedo langage

* add todo

* Update commonobject.class.php

* Update commonobject.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-24 22:53:43 +02:00
Frédéric FRANCE
702cca1502 fix $action is unknown (#30148)
dafbefdc74
2024-06-24 22:15:56 +02:00
Laurent Destailleur
2e938fe9ef Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-06-24 12:44:28 +02:00
lvessiller-opendsi
34a98e369b FIX rounding update price for expense report lines (#30051)
* FIX rounding update price for expense report lines

* fix phan ci error

* fix vat amount diff on rouding mode 1
2024-06-24 02:26:37 +02:00
Laurent Destailleur
c54a97e923 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-06-24 01:47:18 +02:00
Laurent Destailleur
86341f110c Debug v20 2024-06-23 21:31:44 +02:00