Frédéric FRANCE
0e1478206a
clean code ( #35229 )
...
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-09-08 01:48:52 +02:00
ldestailleur
8664a3c2c8
Fix CI
2025-05-05 20:30:26 +02:00
ldestailleur
e7d54cf643
Fix CI
2025-04-08 20:37:49 +02:00
ldestailleur
3aa9169cf0
Fix CI
2025-04-08 19:35:07 +02:00
ldestailleur
9c9099f06b
Fix CI
2025-04-08 19:19:33 +02:00
ldestailleur
7d8607cce5
NEW Module external website is deprecated. Replaced with menu editor.
2025-04-08 18:18:05 +02:00
Laurent Destailleur
25d7c47ce3
WIP Enhance menu editor with showtopmenuinframe
2025-04-07 05:47:47 +02:00
MDW
c3104905b3
Qual: Fix phan notices (html/core) ( #33474 )
...
* FIX: Replace compromised tj-actions/changed-files
# FIX: Replace compromised tj-actions/changed-files
See https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised .
* Add changed php file for test
* Qual: Fix phan notices (html/core)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-03-15 16:34:35 +01:00
MDW
f4ff437026
Qual: Fix phan/phpstan notices in class files (part 4) ( #31598 )
...
* Qual: Fix phan notices for DolibarrModules.class
* Qual: Fix notices for classes actioncomm..task.class.php
* fixup! Qual: Fix notices for classes actioncomm..task.class.php
* Qual: Fix new notices blocking PR
2024-10-30 21:33:30 +01:00
Laurent Destailleur
5b777188e2
Fix Phan
2024-04-28 01:47:18 +02:00
MDW
651b5a22eb
Fix & enable PhanTypeSuspiciousEcho
...
# Fix & enable PhanTypeSuspiciousEcho
Fix occurences by improving typing - array key was not found and
supposed null in a print statement.
Example:
PhanTypeSuspiciousEcho Suspicious argument $menu_array[$i]['prefix'] of type null for an echo/print statement
Enabled detection because all cases are fixed
2024-03-15 10:14:40 +01:00
MDW
b72cf193c4
Fix some cases of PhanTypeSuspiciousStringExpression ( #28751 )
...
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-03-11 14:01:28 +01:00
Laurent Destailleur
7866ee472b
QUAL Clean code around dol_eval use
2024-03-06 17:07:24 +01:00
Frédéric FRANCE
fba15178eb
all initAsSpecimen return int ( #28577 )
...
* all initAsSpecimen return int
* all initAsSpecimen return int
* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
Laurent Destailleur
b666d17eed
FIX #28504
2024-02-28 20:18:35 +01:00
thibdrev
7015827142
qual: phpstan for htdocs/core/class/menubase.class.php
...
htdocs/core/class/menubase.class.php 500 Property Menubase::$fk_menu (int) does not accept string.
htdocs/core/class/menubase.class.php 501 Property Menubase::$position (int) does not accept string.
htdocs/core/class/menubase.class.php 509 Property Menubase::$user (int) does not accept string.
htdocs/core/class/menubase.class.php 510 Property Menubase::$tms (int) does not accept string.
2024-01-26 09:01:32 +01:00
MDW
89004f7e03
Qual: Spelling htdocs/core ( #27491 )
...
Highlights:
- initialY in pdf_standard.modules.php was unused
- remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
Frédéric FRANCE
61b79fda17
avoid phpstan error with phpdoc
2023-12-06 15:46:39 +01:00
Frédéric FRANCE
53c8a3acf8
clean phpdoc for phpstan ( #26905 )
2023-12-01 19:51:32 +01:00
MDW
3c966469ef
QUAL No return values in __construct(), correct PHPDoc for typing ( #26768 )
2023-11-20 23:47:06 +01:00
Laurent Destailleur
4033038d5f
Fix restore ticket top menu entry in auguria module
2023-10-18 16:41:00 +02:00
Laurent Destailleur
c507adeef7
NEW Top menu support picto of modules that are font awesome picto.
2023-10-13 15:00:51 +02:00
Frédéric FRANCE
3f84913087
remove not used variable
2023-08-24 11:36:14 +02:00
Laurent Destailleur
9859720dc3
Clean module dependency system
2023-04-21 13:27:50 +02:00
Regis Houssin
48333a7205
FIX wrong test
2023-03-29 15:09:43 +02:00
Regis Houssin
898a4bad15
FIX menu force entity = 0 if core module
2023-03-29 14:34:52 +02:00
Frédéric FRANCE
53d89bb068
Update menubase.class.php
2023-02-22 20:24:40 +01:00
Laurent Destailleur
c886bad8b6
Fix warning
2022-12-28 17:00:28 +01:00
Anthony Berton
cd6bd2ae4e
FIX - php8 migration
2022-07-20 18:39:11 +02:00
Regis Houssin
399fffa81e
FIX convert core class
2022-01-27 10:19:35 +01:00
Laurent Destailleur
fb46ece906
Fix yogosha 6347
2021-06-09 15:36:47 +02:00
Laurent Destailleur
cc10106a21
Fix protection on int
2021-03-14 12:20:23 +01:00
Laurent Destailleur
12f50a76d7
Fix yogosha #5627
2021-03-14 11:48:39 +01:00
Frédéric FRANCE
a4e25359e7
add missing rule
2021-03-01 20:37:16 +01:00
Frédéric FRANCE
554e449e40
code syntax core directory
2021-02-23 22:03:23 +01:00
Frédéric FRANCE
df67de08b1
modules can add prefix for menu
2021-02-06 10:16:07 +01:00
Laurent Destailleur
c7ca99accb
Fix default value of enabled property of menu entry
2020-10-07 15:38:07 +02:00
Laurent Destailleur
54c0f742b1
Fix escape
2020-09-19 21:19:04 +02:00
Scrutinizer Auto-Fixer
73915d51c8
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-09-14 02:30:04 +00:00
Scrutinizer Auto-Fixer
c263c8a76c
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-09-08 19:27:28 +00:00
Laurent Destailleur
b1e45aef46
Debug opensurvey. Look and feel v13. Removed deprecated properties.
2020-09-07 12:04:50 +02:00
Laurent Destailleur
ab88890f3a
Merge branch '12.0' of git@github.com:Dolibarr/dolibarr.git into develop
2020-06-28 21:48:28 +02:00
Laurent Destailleur
194b92e70f
Fix load of menu when 'perm' or 'enabled' is '0'.
2020-06-27 15:27:09 +02:00
Laurent Destailleur
6f12488e30
Merge branch '12.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/compta/facture/card.php
htdocs/filefunc.inc.php
2020-06-07 19:55:48 +02:00
Laurent Destailleur
09047dc19c
Doc
2020-06-07 19:26:37 +02:00
Laurent Destailleur
81c80b254e
Fix lang property on database menu entry was not propagated
2020-06-07 19:25:25 +02:00
Frédéric FRANCE
b41ac00b98
add new rule
2020-05-21 15:05:19 +02:00
Frédéric FRANCE
ee6fadd0d5
add new rule
2020-05-21 01:41:27 +02:00
Laurent Destailleur
55bef402c4
Fix remove a lot of warnings on Eclipse
2020-02-21 17:47:36 +01:00
Scrutinizer Auto-Fixer
1648fc142e
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2019-11-16 22:24:29 +00:00