* Qual: 🛟 Fix reference to $db with $this->db
# Qual: reference to $db with $this->db
$db was undeclared, use $this->db.
* Qual: Fix LDAP typing
* Fix suspected issue with environment max size and md5sum working on limited files
* Correct typing hint for email_date
* Qual: 🛟 Fix reference to $db with $this->db
# Qual: reference to $db with $this->db
$db was undeclared, use $this->db.
* Fix suspected issue with environment max size and md5sum working on limited files
* Qual: Fix LDAP typing
* Qual: Improve dol_syslog
# Qual: Improve dol_syslog
The changes:
- Keep the log file open for less time (better for concurrency);
- Open the log file only to append data (no internal preparation for writing);
- Avoids re-assigning a constant array;
- Add PHPDoc information about the array parameters and return values;
- May reduce the computation of global settings;
- Result in a slight performance improvement.
* Added confirm_sign, confirm_unsign, sign & unsign actions. Added sign-unsign button.
* Updated create & fetch methods with signed_status
* Added EN localization
* Added intervention signed notification
* Added intervention signed auto event. Updated EN localization. Fixed trigger.
* Cleaned code
* Added signed label to status badge
* Cleaned code
* Added signed statues dictionary. Added method to get signed status label badge.
* Added signed status to intervention list
* Added sign localizations
* Added sign confirm select. Refactored signed statuses dictionary.
* Added method to get localized signed statuses arrray. Refactored code. Added EN localization.
* Fixed signed status update
* Cleaned code
* Updated EN localization
* Cleaned code
* Changed sign workflow to exclude only drafts
* Added signed status change with online sign
* Improved signed status workflow
* Removed db structure changes
* Updated action trigger to FICHINTER_MODIFY
* Updated EN localizations
* Refactored to use FICHINTER_MODIFY trigger with localized context message. Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Updated EN localizations.
* Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Cleaned Ecode.
* Fixed undeclared constant
* Added contributor details
* Updated notification logic to use object context to pass signature status
* Refactored to make use of object context for event notification. Cleaned code.
* Fixed deprecated method
* Cleaned code
* fix: return error when extrafield DDLDropField failed
* fix: return error when delete extrafield failed
* fix: VAT is already calculted if not post (#30683)
* ongoing
* new: add warehouseId parameters inselect_produit to limit result to existing product in select
* new: add warehouseId parameters inselect_produit to limit result to existing product in select
* new: add warehouseId parameters inselect_produit to limit result to existing product in select
* try reveiw
* fix from review
* fix from reiview
* review php stan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Allow null for buyer, and force '' for in printObjectLine(s)
* Allow null for Contact in show_actions_done
* Qual: Enable phan on modulebuilder
# Qual: Enable phan on modulebuilder
Most files of the modulebuilder template can be checked as regular files.
It will help improve the template
* Update baseline (enable modulebuilder notices)
* Add properties that are expected to exist on modules_boxes
* Qual: Ignore false positive (phan)
* Set phpdoc type to include null on formAddObjectLine
* Qual: Fixes for modulebuilder (phan, phpstan, bugs, format)
* Fix phpcs for intracom
* Make ModeleBoxes:showBox() signature match child class's
* Fix *box::showBox() phpdoc types
* Update index.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
# Qual: Correct typing hint for category type in setAsCategory
Type hint was int which is deprecated, so setting type hint to string
which will help detect deprecated uses and not flag the correct uses
* New update for templateMail by creating files
* New updating for get php content
* Update html.formmail.class.php
* Fix updating content news
* Fix CTI Errors
* NEW function for Preview In CKeditor products
* edit html file for news
* Add automaticaly subject value to editor
* Update html.formmail.class.php
* FIX name and path of file
* Fix path for files
* Fix errors variables
* replace file in ajax folder
* rename path
* Fix return function in product class
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Update phan baseline (remove PhanTypeInvalidLeftOperandOfNumericOp)
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Fix: Change argument '' to null as by getAvailableDiscounts signature
* Qual: Cast '' to float for Phan notice
* Fix: Convert $number with price2num before using this parameter
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp
These changes ensure that the left operand is a numeric value
* Add cast to ensure fmod is presented with floats