Commit Graph

4102 Commits

Author SHA1 Message Date
Frédéric FRANCE
7fe28032d1 phpstan (#31276)
* phpstan

* phpstan
2024-10-05 18:49:54 +02:00
Mohamed DAOUD
4a7ad31f85 NEW Stars Field for Module Builder (#31216)
* stars field for modulebuilder

* Update commonobject.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-04 18:37:41 +02:00
Laurent Destailleur
bd4dbe7b1a Remove not used method 2024-10-04 12:35:23 +02:00
MDW
6e01a60f59 Qual: Fix phan/phpstan notices (#31259)
# Qual: Fix phan/phpstan notices

Fix notices by adjusting phpdoc
2024-10-04 08:25:17 +02:00
Laurent Destailleur
d24069d5e2 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-03 20:35:33 +02:00
Laurent Destailleur
eebb16c693 Redice cyclomatic complexity 2024-10-03 20:08:09 +02:00
MDW
1834c37c16 Qual: Fix phan notices (#31212)
* Qual: Fix phan notices

# Qual: Fix phan notices

Fix several phan notices related to classes with UnknownObject
classes.

* Qual: Fix phan notices

* Qual: Fix phan notices

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-03 19:40:34 +02:00
Laurent Destailleur
e412dbbe05 Merge manually fix of #31217 + other fix for use by external modules 2024-10-03 19:30:06 +02:00
Laurent Destailleur
6f6a87cd78 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-03 17:25:10 +02:00
Laurent Destailleur
88b488cfbb Fix for better compatibility 2024-10-03 17:23:29 +02:00
John BOTELLA
a272d929a5 Fix $ in key (#31215) 2024-10-03 17:14:28 +02:00
Frédéric FRANCE
7d36fe0715 fix typo phan and Co 💊 (#31214)
* fix typo

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* translation missing

* test win mariadb version

* test win mariadb version

* phpdoc

* phpdoc

* phpdoc
2024-10-03 15:43:04 +02:00
Laurent Destailleur
2d4ea679cc Debug v21 2024-10-03 12:43:21 +02:00
Laurent Destailleur
b87b0b92b8 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-02 17:31:42 +02:00
Laurent Destailleur
11ea0ad9fd Fix fatal error with bad parameters 2024-10-02 15:15:52 +02:00
Laurent Destailleur
b5730db759 Fix error 2024-10-02 12:19:29 +02:00
Laurent Destailleur
8bdd3fe3cd Fix error 2024-10-02 12:19:21 +02:00
Laurent Destailleur
9c98e3816a Fix error 2024-10-02 12:18:55 +02:00
Laurent Destailleur
7f8a0860cf Fix error 2024-10-02 12:16:46 +02:00
Laurent Destailleur
6f7b0c1815 NeW Can add the info messages (error, waring...) at the top of the stack 2024-09-30 14:30:28 +02:00
Laurent Destailleur
61e8382869 Fix SERVICE_ARE_ECOMMERCE_200238EC #31159 in transfer of sale journal 2024-09-30 10:46:51 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Frédéric FRANCE
138ffa3158 fix phpstan (#31181)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-29 21:49:52 +02:00
Laurent Destailleur
c5163d0d96 CSS 2024-09-29 17:31:46 +02:00
Frédéric FRANCE
0e1292e253 fix phpstan (#31177)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-29 02:49:34 +02:00
Laurent Destailleur
a423da6a4b CSS Look and feel v21 2024-09-29 01:20:02 +02:00
Laurent Destailleur
5f21a3a4e3 NEW The margin section can now be shown/hidden 2024-09-28 15:10:28 +02:00
Laurent Destailleur
f0d1bbf2f8 Use picto instead of link "Use last knwo rate" link. 2024-09-26 19:50:59 +02:00
Laurent Destailleur
0222221a10 Look and feel v21 2024-09-25 12:13:55 +02:00
Laurent Destailleur
ae6e35cc84 Look and feel v21 enhancement on smartphone 2024-09-25 02:35:56 +02:00
Laurent Destailleur
cc95331fc6 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-23 22:09:24 +02:00
Laurent Destailleur
0f5e5e1e5b FIX Maxi debug edit/delete accounting transaction 2024-09-23 21:42:52 +02:00
Laurent Destailleur
33da02bbcd FIX Maxi debug edit/delete accounting tnasaction 2024-09-23 20:16:39 +02:00
Laurent Destailleur
1bf09629cb Fix holiday types common to all entities 2024-09-23 11:32:14 +02:00
Mohamed DAOUD
6ce09ce68d Add town and country as an optionnal column in Partnership list (#31057)
* add town country partnership list

* Update partnership_list.php

* Update partnership_list.php
2024-09-20 18:12:32 +02:00
Laurent Destailleur
c340c34aeb FIX Hide a feature that is a security vulnerability. 2024-09-20 00:19:36 +02:00
Laurent Destailleur
cf931a8a90 FIX retreiving user specific constant 2024-09-19 14:27:08 +02:00
MDW
099dbd9c1e Qual: Fix notices for htdocs/admin/* (#30982)
* Fix (Possibly)UndeclaredGlobalVariable

* Update phan baseline

* Fix (Possibly)UndeclaredGlobalVariable (2)

* Qual: Fix notices for htdocs/admin/*

# Qual: Fix notices for htdocs/admin/*

Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
Frédéric FRANCE
d5fe4f998a fix phpstan (#30989)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-18 02:45:54 +02:00
Laurent Destailleur
37d9e6e9e9 Fix search on string that include partial html content 2024-09-17 14:00:37 +02:00
Laurent Destailleur
e09fa82deb Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-17 02:51:19 +02:00
Laurent Destailleur
f9d347a11c Fix type of field 2024-09-17 02:50:35 +02:00
Laurent Destailleur
721250edc8 Fix type hint 2024-09-17 02:46:39 +02:00
Laurent Destailleur
65edbd5f9f FIX better compatibility with some old extrafield syntax filter 2024-09-16 15:50:47 +02:00
Laurent Destailleur
26ba862540 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-14 02:45:04 +02:00
Laurent Destailleur
c462a572ee Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-09-14 02:44:26 +02:00
Laurent Destailleur
057fcdfaef Fix: In v20, all global caches must use $conf->cache['nameofcache']
instead of a global variable.
2024-09-13 18:44:23 +02:00
John BOTELLA
308178d5bc QUAL : Ergo btn and fix (#30947)
* Clean sql

* Doc

* Fix ergo feedback and accessibility button

* Add hsl color var to allow css use user color with variants

* Add hsl color var to allow css use user color with variants

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 17:30:41 +02:00
Laurent Destailleur
857405bea6 Doc 2024-09-13 03:47:30 +02:00
MDW
f89245b354 Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00