Commit Graph

34874 Commits

Author SHA1 Message Date
MDW
651b5a22eb Fix & enable PhanTypeSuspiciousEcho
# Fix & enable PhanTypeSuspiciousEcho

Fix occurences by improving typing - array key was not found and
supposed null in a print statement.

Example:
  PhanTypeSuspiciousEcho Suspicious argument $menu_array[$i]['prefix'] of type null for an echo/print statement

Enabled detection because all cases are fixed
2024-03-15 10:14:40 +01:00
MDW
e36dccff59 Qual: better typing for getCountry() 2024-03-15 10:12:48 +01:00
MDW
6a606bf7c1 Adjust typing for 'origin' & 'origin_object' 2024-03-15 10:12:46 +01:00
MDW
db0134183d Qual: improve hist typing 2024-03-15 10:11:57 +01:00
MDW
6ab1e6e7d9 Qual: Add typing information 2024-03-15 10:11:56 +01:00
MDW
b57b4c8f17 Qual: Improve typing hints, in particular sendtoid 2024-03-15 10:11:55 +01:00
MDW
3384a0b847 Fix & enable PhanUndeclaredTypeReturnType
# Fix & enable PhanUndeclaredTypeReturnType

One typo, and replace 'number' with int or int|float
2024-03-15 10:07:15 +01:00
Laurent Destailleur
80e2e59373 Merge pull request #28862 from mdeweerd/fix/PhanTypeMismatchPropertyDefault
Fix & enable PhanTypeMismatchPropertyDefault
2024-03-15 09:33:40 +01:00
Laurent Destailleur
30037a5cba Fix: Test removalof one phan exception 2024-03-15 09:30:21 +01:00
jyhere
0872f825ec FIX: use getDolGlobalInt 2024-03-15 09:10:17 +01:00
Laurent Destailleur
e238cc204e Merge pull request #28750 from mdeweerd/fix/PhanPluginSuspiciousParamPosition
Fix: Resolve several PhanPluginSuspiciousParamPosition cases
2024-03-15 08:45:25 +01:00
Laurent Destailleur
1a63080e44 Merge branch 'develop' into fix/PhanTypeMismatchPropertyDefault 2024-03-15 08:41:23 +01:00
Laurent Destailleur
ba4e454827 Merge pull request #28829 from rycks/develop_add_projects_linked_by_a_contact_option
NEW Can show the list of projects having at least one contact that is a contact of the third party
2024-03-15 08:29:39 +01:00
Laurent Destailleur
176d8173a6 Merge pull request #28861 from mdeweerd/fix/PhanPluginPHPDocInWrongComment
Fix & enable PhanPluginPHPDocInWrongComment
2024-03-15 08:28:47 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
1e5dd2f209 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:11 +01:00
MDW
27dfa334d0 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:10 +01:00
Laurent Destailleur
b23e627a05 Merge pull request #28800 from mdeweerd/PhanPluginDuplicateConditionalUnnecessa
Fix & enable PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y"
2024-03-15 00:27:58 +01:00
Laurent Destailleur
1639bc83ca Merge pull request #28817 from frederic34/skiljob
fix warnings
2024-03-15 00:18:44 +01:00
Laurent Destailleur
66855443db Merge pull request #28824 from lamrani002/waitingMsg
New msg for prompt ai before display result
2024-03-15 00:09:20 +01:00
Laurent Destailleur
6d71b4f9c5 Update html.formmail.class.php 2024-03-15 00:08:42 +01:00
Laurent Destailleur
0691839c7b Merge branch 'develop' into develop_add_projects_linked_by_a_contact_option 2024-03-14 23:57:30 +01:00
Laurent Destailleur
c49968bb4b Merge pull request #28825 from mdeweerd/fix/PhanNoopBinaryOperator
Fix & Enable PhanNoopBinaryOperator
2024-03-14 23:55:33 +01:00
Laurent Destailleur
190f2a9d70 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-14 23:46:04 +01:00
Laurent Destailleur
8220626d78 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-14 23:45:24 +01:00
Laurent Destailleur
4d72f22b8a Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-03-14 23:45:07 +01:00
Laurent Destailleur
aa56a170c7 Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2024-03-14 23:44:46 +01:00
Laurent Destailleur
d96fa756c6 Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0 2024-03-14 23:44:26 +01:00
Laurent Destailleur
91c6940818 Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 15.0 2024-03-14 23:44:04 +01:00
Laurent Destailleur
7ecf1ac082 Merge 2024-03-14 23:43:25 +01:00
MDW
ab7879c4a2 Fix & enable PhanPluginPHPDocInWrongComment
# Fix & enable PhanPluginPHPDocInWrongComment

Ignore error in file where the notification occurs & enable detection.
2024-03-14 23:36:24 +01:00
Laurent Destailleur
d8e1bf8844 Clean var 2024-03-14 23:23:38 +01:00
Laurent Destailleur
e478fd8cbc Merge pull request #28859 from mdeweerd/fix/PhanPluginUnknownClosureParamType
Fix & enable PhanPluginUnknownClosureParamType
2024-03-14 23:10:37 +01:00
MDW
0f8b9e73f0 Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
# Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

Fix the PhanPluginPrintfIncompatibleArgumentTypeWeak occurences and fix the rule
2024-03-14 23:00:47 +01:00
MDW
f5ab94634a Fix PhanNoopBinaryOperator by commenting NOOP tests 2024-03-14 22:57:33 +01:00
Laurent Destailleur
009ff45f61 Merge pull request #28835 from W1W1-M/qual-project-lib
Fix undefined task object
2024-03-14 22:54:07 +01:00
Laurent Destailleur
dbcb2c2cd6 Merge pull request #28842 from frederic34/vinci
some fix for vinci
2024-03-14 22:44:41 +01:00
MDW
a408288ba1 Fix & enable PhanPluginUnknownClosureParamType
# Fix & enable PhanPluginUnknownClosureParamType

Typing of anonymous functions to fix this notice.
Optimised some minor things.
2024-03-14 22:42:26 +01:00
Laurent Destailleur
e12faaa663 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-03-14 22:38:31 +01:00
Laurent Destailleur
0a8f9ffb2b Merge pull request #28858 from frederic34/patch-8
Update doc_generic_odt.modules.php
2024-03-14 22:30:28 +01:00
Laurent Destailleur
5de7e73c5a Merge pull request #28855 from frederic34/newfixes
fix phpstan is incompatible with
2024-03-14 22:30:06 +01:00
Laurent Destailleur
390f18f557 FIX #yogosha20932 2024-03-14 22:06:43 +01:00
Frédéric FRANCE
5415273040 Update doc_generic_odt.modules.php 2024-03-14 21:31:44 +01:00
Frédéric France
8ffcda499f fix warnings 2024-03-14 21:14:23 +01:00
Frédéric France
bb8604e265 Merge remote-tracking branch 'upstream/develop' into newfixes 2024-03-14 20:46:47 +01:00
MDW
0f6bddfb9b Fix PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y" (Simplify) 2024-03-14 19:47:18 +01:00
MDW
8823cca117 Fix PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y" (Simplify) 2024-03-14 19:47:17 +01:00
MDW
47a4a3b848 Fix PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y" (Simplify) 2024-03-14 19:47:17 +01:00
MDW
8ff08adbbf Fix PhanPluginSuspiciousParamPosition 2024-03-14 19:39:35 +01:00
MDW
bd0447a8a3 Fix PhanPluginSuspiciousParamPosition 2024-03-14 19:39:34 +01:00