Commit Graph

1100 Commits

Author SHA1 Message Date
Laurent Destailleur
f34b6da91b Debug v20 2024-06-03 13:37:36 +02:00
Frédéric FRANCE
bae0c17811 clean code (#29800)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* Update adherent.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-31 15:09:41 +02:00
Laurent Destailleur
31a626b34d Fix phan 2024-05-31 14:59:16 +02:00
Laurent Destailleur
832aca30dc Debug v20 2024-05-29 22:19:52 +02:00
Laurent Destailleur
c32ece68f4 Debug v20 2024-05-15 17:55:16 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Frédéric FRANCE
b0695abca9 fix phan (#29591)
* fix phan

* fix typos and translations

* fix phan remove code doing nothing

* fix phan remove code doing nothing

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-03 18:01:17 +02:00
Jon Bendtsen
eb1c044419 FIX: API GET /members/types/{id} says it deletes member type #29421 (#29423)
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2024-04-20 22:21:47 +01:00
Frédéric FRANCE
19dbbc752a fix phpstan (#29379) 2024-04-18 11:35:59 +01:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Frédéric FRANCE
7cf6a0821f fix phpdoc for ismultientitymanaged (#29245)
* fix phpdoc

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-06 17:38:39 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
930c8614b1 Merge branch 'develop' into membertype_update_single_array_option_element 2024-04-02 14:54:13 +02:00
Laurent Destailleur
7715513ac9 Some API HTTP return code were moved from 401 to 403 to better follow
REST specification.
2024-04-02 14:47:49 +02:00
Laurent Destailleur
66f3b438f6 Merge branch 'develop' into membertype_update_single_array_option_element 2024-04-02 13:37:01 +02:00
Laurent Destailleur
51f862ad28 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-04-02 13:21:00 +02:00
Laurent Destailleur
990216b13f NEW Api parameters are sanitized by the WAF, same code than GET/POST 2024-04-02 13:07:13 +02:00
Jon Bendtsen
bc56e8f1e7 double fix: do not remove array_options from json + allowing single option_ update without nullifying the other options_ 2024-04-01 19:11:16 +02:00
Jon Bendtsen
c55c0284b1 will allow updating 1 member single Complementary Attribute without specifying complementary attributes that we don't want to change. Similar to # 29115 but just for a member 2024-04-01 12:37:05 +02:00
Laurent Destailleur
b58e439a17 Clean use of $_POST 2024-03-28 21:29:02 +01:00
Laurent Destailleur
13e903aca4 Clean use of $_POST 2024-03-28 20:44:51 +01:00
Laurent Destailleur
787b1a1c83 Merge branch 'develop' into fix/filebyfile 2024-03-28 14:23:54 +01:00
Laurent Destailleur
a7e33e6573 Merge pull request #29047 from mdeweerd/fix/PhanPluginUnknownObjectMethodCall1
Fixes for PhanPluginUnknownObjectMethodCall
2024-03-28 14:20:57 +01:00
Eric Seigne
0e269102ae use MailSentByTo 2024-03-28 09:38:09 +01:00
MDW
c0fd71f922 PHPdoc - correct return type for countMembersByTypeAndStatus 2024-03-27 10:18:46 +01:00
MDW
b29f3a609d Force typing (phan) for typing checks 2024-03-27 10:17:31 +01:00
Laurent Destailleur
4f540ae677 Fix label for date of end of membership 2024-03-25 12:09:19 +01:00
MDW
3b93de2709 Fix PhanTypeMismatchReturnNullable by initialising return value + Some PHPdoc typing 2024-03-20 21:58:34 +01:00
MDW
33486f10c0 Fix PhanTypeMismatchReturnNullable by initialising return value 2024-03-20 21:58:33 +01:00
Laurent Destailleur
932155e71c Merge pull request #28930 from JonBendtsen/api_create_subscription_link2_invoice
API creation of subscription can now link to existing invoice
2024-03-19 01:57:30 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
Jon Bendtsen
b94101a017 direct copy from htdocs/fourn/class/fournisseur.facture-rec.class.php 2024-03-17 23:06:11 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
5be98ff240 Fix PhanTypeMismatchPropertyDefault 2024-03-15 01:23:06 +01:00
MDW
1637ba5c87 Fix PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y" (Simplify) 2024-03-14 19:47:12 +01:00
MDW
fc3cdf51ba Fix PhanPluginRedundantAssignment 2024-03-13 00:40:32 +01:00
Laurent Destailleur
9e16016125 Merge pull request #28770 from mdeweerd/typing/fields
Fix: Repeat fields typing in CommonClass children
2024-03-12 14:30:36 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
Laurent Destailleur
ebf33c4960 Clean code 2024-03-12 02:58:01 +01:00
MDW
f6920538b6 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:38 +01:00
MDW
1350f4d29e Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:36 +01:00
Laurent Destailleur
9a281ed264 Fix undefined property 2024-03-08 21:21:27 +01:00
Laurent Destailleur
afd49868d5 Fix bad route 2024-03-08 16:32:44 +01:00
Laurent Destailleur
a4faa488fd Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-08 11:00:50 +01:00
Laurent Destailleur
fb16af02b4 Clean code. Move member type API in good file. 2024-03-08 11:00:19 +01:00
Laurent Destailleur
e6b2756c19 QUAL The signature for all ->delete() method has been modified to match
the modulebuilder template (so first param is now always $user), except
  the delete for thirdparty (still accept the id of thirdparty to delete
as first parameter). Will probably be modified into another version.
2024-03-07 17:58:02 +01:00
Frédéric FRANCE
bc2f527e41 add phpdoc (#28639)
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc
2024-03-05 17:11:46 +01:00
Laurent Destailleur
ce010a54c7 Clean code and prepare a more powerfull phpunit check for sql forging. 2024-03-05 00:22:12 +01:00
Frédéric FRANCE
fba15178eb all initAsSpecimen return int (#28577)
* all initAsSpecimen return int

* all initAsSpecimen return int

* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
Laurent Destailleur
4279478acd Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-03-01 19:40:36 +01:00