Commit Graph

13831 Commits

Author SHA1 Message Date
MDW
651b5a22eb Fix & enable PhanTypeSuspiciousEcho
# Fix & enable PhanTypeSuspiciousEcho

Fix occurences by improving typing - array key was not found and
supposed null in a print statement.

Example:
  PhanTypeSuspiciousEcho Suspicious argument $menu_array[$i]['prefix'] of type null for an echo/print statement

Enabled detection because all cases are fixed
2024-03-15 10:14:40 +01:00
MDW
6a606bf7c1 Adjust typing for 'origin' & 'origin_object' 2024-03-15 10:12:46 +01:00
MDW
b57b4c8f17 Qual: Improve typing hints, in particular sendtoid 2024-03-15 10:11:55 +01:00
MDW
3384a0b847 Fix & enable PhanUndeclaredTypeReturnType
# Fix & enable PhanUndeclaredTypeReturnType

One typo, and replace 'number' with int or int|float
2024-03-15 10:07:15 +01:00
Laurent Destailleur
80e2e59373 Merge pull request #28862 from mdeweerd/fix/PhanTypeMismatchPropertyDefault
Fix & enable PhanTypeMismatchPropertyDefault
2024-03-15 09:33:40 +01:00
Laurent Destailleur
e238cc204e Merge pull request #28750 from mdeweerd/fix/PhanPluginSuspiciousParamPosition
Fix: Resolve several PhanPluginSuspiciousParamPosition cases
2024-03-15 08:45:25 +01:00
Laurent Destailleur
1a63080e44 Merge branch 'develop' into fix/PhanTypeMismatchPropertyDefault 2024-03-15 08:41:23 +01:00
Laurent Destailleur
176d8173a6 Merge pull request #28861 from mdeweerd/fix/PhanPluginPHPDocInWrongComment
Fix & enable PhanPluginPHPDocInWrongComment
2024-03-15 08:28:47 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
1e5dd2f209 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:11 +01:00
MDW
27dfa334d0 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:10 +01:00
Laurent Destailleur
b23e627a05 Merge pull request #28800 from mdeweerd/PhanPluginDuplicateConditionalUnnecessa
Fix & enable PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y"
2024-03-15 00:27:58 +01:00
Laurent Destailleur
1639bc83ca Merge pull request #28817 from frederic34/skiljob
fix warnings
2024-03-15 00:18:44 +01:00
Laurent Destailleur
66855443db Merge pull request #28824 from lamrani002/waitingMsg
New msg for prompt ai before display result
2024-03-15 00:09:20 +01:00
Laurent Destailleur
6d71b4f9c5 Update html.formmail.class.php 2024-03-15 00:08:42 +01:00
MDW
ab7879c4a2 Fix & enable PhanPluginPHPDocInWrongComment
# Fix & enable PhanPluginPHPDocInWrongComment

Ignore error in file where the notification occurs & enable detection.
2024-03-14 23:36:24 +01:00
MDW
a408288ba1 Fix & enable PhanPluginUnknownClosureParamType
# Fix & enable PhanPluginUnknownClosureParamType

Typing of anonymous functions to fix this notice.
Optimised some minor things.
2024-03-14 22:42:26 +01:00
Frédéric France
8ffcda499f fix warnings 2024-03-14 21:14:23 +01:00
MDW
8823cca117 Fix PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y" (Simplify) 2024-03-14 19:47:17 +01:00
MDW
47a4a3b848 Fix PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y" (Simplify) 2024-03-14 19:47:17 +01:00
MDW
27e89df94d Fix PhanPluginSuspiciousParamPosition 2024-03-14 19:39:33 +01:00
Jon Bendtsen
5eaa6c84f1 missing one 2024-03-14 18:30:19 +01:00
Jon Bendtsen
18f3e3d20d to remove php-stan complaints 2024-03-14 18:20:37 +01:00
Frédéric FRANCE
23b0faeb44 Merge branch 'develop' into skiljob 2024-03-14 11:04:11 +01:00
Lamrani Abdel
a504207ed1 New msg for prompt ai before display result 2024-03-14 01:28:30 +01:00
Jon Bendtsen
390a190094 Merge branch 'develop' into new_thirdparty_notification_api 2024-03-13 23:56:39 +01:00
Jon Bendtsen
5970524872 adding some publics and avoid asking for data we don't use 2024-03-13 23:51:49 +01:00
Jon Bendtsen
b3d660cbcb a few more public values that PHPstan complains about missing 2024-03-13 23:47:34 +01:00
Jon Bendtsen
2a63c527c8 delete and fetch notifications. Based on companybankaccount.class.php 2024-03-13 23:09:47 +01:00
Laurent Destailleur
c867bc2706 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-13 22:36:45 +01:00
Laurent Destailleur
8bfc0779c4 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-13 22:20:08 +01:00
Frédéric France
edb12bc63d Merge remote-tracking branch 'upstream/develop' into skiljob 2024-03-13 18:42:52 +01:00
Laurent Destailleur
3dd6b7a4c7 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-13 18:40:12 +01:00
Laurent Destailleur
3cc9467ee4 Clean code 2024-03-13 18:39:51 +01:00
Frédéric France
26fe76733c fix warnings 2024-03-13 18:20:41 +01:00
Laurent Destailleur
cad8f24322 Merge pull request #28799 from mdeweerd/fix/PhanPluginDuplicateExpressionAssignmentOperation
Fix & enable PhanPluginDuplicateExpressionAssignment
2024-03-13 14:49:21 +01:00
John BOTELLA
f64e8c0689 Merge branch 'develop' of github.com:Dolibarr/dolibarr into fix_element_type_part_05 2024-03-13 14:42:43 +01:00
Eric Seigne
3d449b8fce phpdoc missing argument type, thanks to phpstan ! 2024-03-13 11:54:05 +01:00
Eric Seigne
3a0bf96e92 add password and genericpassword entry types 2024-03-13 11:49:03 +01:00
MDW
a1f332586c Fix PhanPluginRedundantAssignment 2024-03-13 00:40:50 +01:00
MDW
60359aa418 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:49 +01:00
MDW
c3647c3af6 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:48 +01:00
MDW
6d6cbff08e Fix PhanPluginRedundantAssignment 2024-03-13 00:40:47 +01:00
MDW
271525deaa Fix PhanPluginRedundantAssignment 2024-03-13 00:40:46 +01:00
MDW
0302e4f2b5 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:45 +01:00
MDW
81fde8ffc3 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:44 +01:00
MDW
5668974d46 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:44 +01:00
MDW
c76c08e9f0 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:43 +01:00
MDW
509357d632 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:42 +01:00
MDW
d33e0a69ca Fix PhanPluginRedundantAssignment 2024-03-13 00:40:41 +01:00